BigW Consortium Gitlab
The initializers including this were doing so at the top level, so every object loaded after them had a `current_application_settings` method. However, if someone had rack-attack enabled (which was loaded before these initializers), it would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't have that method. To fix this: 1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need `Object.new.current_application_settings` to work. 2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it like that in several places. 3. Change the initializers to use that new form.
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
application_helper_spec.rb | Loading commit data... | |
auth_helper_spec.rb | Loading commit data... | |
avatars_helper_spec.rb | Loading commit data... | |
award_emoji_helper_spec.rb | Loading commit data... | |
blame_helper_spec.rb | Loading commit data... | |
blob_helper_spec.rb | Loading commit data... | |
broadcast_messages_helper_spec.rb | Loading commit data... | |
button_helper_spec.rb | Loading commit data... | |
ci_status_helper_spec.rb | Loading commit data... | |
commits_helper_spec.rb | Loading commit data... | |
components_helper_spec.rb | Loading commit data... | |
defer_script_tag_helper_spec.rb | Loading commit data... | |
diff_helper_spec.rb | Loading commit data... | |
emails_helper_spec.rb | Loading commit data... | |
events_helper_spec.rb | Loading commit data... | |
form_helper_spec.rb | Loading commit data... | |
git_helper_spec.rb | Loading commit data... | |
gitlab_routing_helper_spec.rb | Loading commit data... | |
graph_helper_spec.rb | Loading commit data... | |
groups_helper_spec.rb | Loading commit data... | |
hooks_helper_spec.rb | Loading commit data... | |
icons_helper_spec.rb | Loading commit data... | |
import_helper_spec.rb | Loading commit data... | |
issuables_helper_spec.rb | Loading commit data... | |
issues_helper_spec.rb | Loading commit data... | |
labels_helper_spec.rb | Loading commit data... | |
markup_helper_spec.rb | Loading commit data... | |
members_helper_spec.rb | Loading commit data... | |
merge_requests_helper_spec.rb | Loading commit data... | |
milestones_helper_spec.rb | Loading commit data... | |
milestones_routing_helper_spec.rb | Loading commit data... | |
namespaces_helper_spec.rb | Loading commit data... | |
notes_helper_spec.rb | Loading commit data... | |
notifications_helper_spec.rb | Loading commit data... | |
page_layout_helper_spec.rb | Loading commit data... | |
pagination_helper_spec.rb | Loading commit data... | |
preferences_helper_spec.rb | Loading commit data... | |
profiles_helper_spec.rb | Loading commit data... | |
projects_helper_spec.rb | Loading commit data... | |
rss_helper_spec.rb | Loading commit data... | |
runners_helper_spec.rb | Loading commit data... | |
search_helper_spec.rb | Loading commit data... | |
sidekiq_helper_spec.rb | Loading commit data... | |
storage_health_helper_spec.rb | Loading commit data... | |
storage_helper_spec.rb | Loading commit data... | |
submodule_helper_spec.rb | Loading commit data... | |
tab_helper_spec.rb | Loading commit data... | |
time_helper_spec.rb | Loading commit data... | |
todos_helper_spec.rb | Loading commit data... | |
tree_helper_spec.rb | Loading commit data... | |
u2f_helper_spec.rb | Loading commit data... | |
users_helper_spec.rb | Loading commit data... | |
version_check_helper_spec.rb | Loading commit data... | |
visibility_level_helper_spec.rb | Loading commit data... | |
wiki_helper_spec.rb | Loading commit data... |