BigW Consortium Gitlab
Fix downloading of patches on public merge requests when user logged out ### What does this MR do? This MR makes it possible to download a diff patch on a public merge request when a user is logged out. ### Why was this MR needed? An Error 500 would result when a user attempted to click on the "Email Patches" or "Plain Diff" button: ``` NoMethodError - undefined method `id' for nil:NilClass: lib/gitlab/backend/shell_env.rb:9:in `set_env' lib/gitlab/satellite/action.rb:20:in `in_locked_and_timed_satellite' lib/gitlab/satellite/merge_action.rb:49:in `diff_in_satellite' app/models/merge_request.rb:219:in `to_diff' app/controllers/projects/merge_requests_controller.rb:42:in `block (2 levels) in show' ``` ### What are the relevant issue numbers? * Closes #1225 * Closes #1854 (dup) * Closes #1858 (dup) See merge request !872
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
backend | Loading commit data... | |
bitbucket_import | Loading commit data... | |
diff | Loading commit data... | |
github_import | Loading commit data... | |
gitlab_import | Loading commit data... | |
gitorious_import | Loading commit data... | |
google_code_import | Loading commit data... | |
graphs | Loading commit data... | |
ldap | Loading commit data... | |
markdown | Loading commit data... | |
middleware | Loading commit data... | |
o_auth | Loading commit data... | |
satellite | Loading commit data... | |
sidekiq_middleware | Loading commit data... | |
access.rb | Loading commit data... | |
app_logger.rb | Loading commit data... | |
asciidoc.rb | Loading commit data... | |
auth.rb | Loading commit data... | |
bitbucket_import.rb | Loading commit data... | |
blacklist.rb | Loading commit data... | |
closing_issue_extractor.rb | Loading commit data... | |
compare_result.rb | Loading commit data... | |
config_helper.rb | Loading commit data... | |
contributions_calendar.rb | Loading commit data... | |
contributor.rb | Loading commit data... | |
current_settings.rb | Loading commit data... | |
force_push_check.rb | Loading commit data... | |
git.rb | Loading commit data... | |
git_access.rb | Loading commit data... | |
git_access_status.rb | Loading commit data... | |
git_access_wiki.rb | Loading commit data... | |
git_logger.rb | Loading commit data... | |
git_ref_validator.rb | Loading commit data... | |
gitorious_import.rb | Loading commit data... | |
identifier.rb | Loading commit data... | |
import_formatter.rb | Loading commit data... | |
inline_diff.rb | Loading commit data... | |
issues_labels.rb | Loading commit data... | |
key_fingerprint.rb | Loading commit data... | |
logger.rb | Loading commit data... | |
markdown.rb | Loading commit data... | |
markup_helper.rb | Loading commit data... | |
note_data_builder.rb | Loading commit data... | |
popen.rb | Loading commit data... | |
production_logger.rb | Loading commit data... | |
project_search_results.rb | Loading commit data... | |
push_data_builder.rb | Loading commit data... | |
reference_extractor.rb | Loading commit data... | |
regex.rb | Loading commit data... | |
search_results.rb | Loading commit data... | |
seeder.rb | Loading commit data... | |
sidekiq_logger.rb | Loading commit data... | |
snippet_search_results.rb | Loading commit data... | |
themes.rb | Loading commit data... | |
upgrader.rb | Loading commit data... | |
url_builder.rb | Loading commit data... | |
user_access.rb | Loading commit data... | |
utils.rb | Loading commit data... | |
version_info.rb | Loading commit data... | |
visibility_level.rb | Loading commit data... |