Name |
Last commit
|
Last update |
---|---|---|
.. | ||
admin | ||
dashboard | ||
explore | ||
profile | ||
project | ||
snippets | ||
steps | ||
support | ||
groups.feature | ||
invites.feature | ||
search.feature | ||
snippet_search.feature | ||
user.feature |
BigW Consortium Gitlab
Fix downloading of patches on public merge requests when user logged out ### What does this MR do? This MR makes it possible to download a diff patch on a public merge request when a user is logged out. ### Why was this MR needed? An Error 500 would result when a user attempted to click on the "Email Patches" or "Plain Diff" button: ``` NoMethodError - undefined method `id' for nil:NilClass: lib/gitlab/backend/shell_env.rb:9:in `set_env' lib/gitlab/satellite/action.rb:20:in `in_locked_and_timed_satellite' lib/gitlab/satellite/merge_action.rb:49:in `diff_in_satellite' app/models/merge_request.rb:219:in `to_diff' app/controllers/projects/merge_requests_controller.rb:42:in `block (2 levels) in show' ``` ### What are the relevant issue numbers? * Closes #1225 * Closes #1854 (dup) * Closes #1858 (dup) See merge request !872
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
admin | Loading commit data... | |
dashboard | Loading commit data... | |
explore | Loading commit data... | |
profile | Loading commit data... | |
project | Loading commit data... | |
snippets | Loading commit data... | |
steps | Loading commit data... | |
support | Loading commit data... | |
groups.feature | Loading commit data... | |
invites.feature | Loading commit data... | |
search.feature | Loading commit data... | |
snippet_search.feature | Loading commit data... | |
user.feature | Loading commit data... |