BigW Consortium Gitlab
Memoize Github::Shell's secret token ## What does this MR do? `API::Helpers#secret_token` was reading the secret file on every invocation. This MR reads the file in the `gitlab_shell_secret_token.rb` initializer and saves it as a class variable at `Gitlab::Shell.secret_token` ## Are there points in the code the reviewer needs to double check? - I'm not sure if the use of `cattr_accessor` is the best approach, or if should be moved into the `class << self` block? - Should `API::Helpers#secret_token` be removed in favor of using `Gitlab::Shell.secret_token`? ## Why was this MR needed? Performance optimization. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/22510 See merge request !6599
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
1_settings.rb | Loading commit data... | |
2_app.rb | Loading commit data... | |
4_ci_app.rb | Loading commit data... | |
5_backend.rb | Loading commit data... | |
6_validations.rb | Loading commit data... | |
7_redis.rb | Loading commit data... | |
active_record_query_trace.rb | Loading commit data... | |
ar5_batching.rb | Loading commit data... | |
ar_monkey_patch.rb | Loading commit data... | |
ar_speed_up_migration_checking.rb | Loading commit data... | |
attr_encrypted_no_db_connection.rb | Loading commit data... | |
backtrace_silencers.rb | Loading commit data... | |
bullet.rb | Loading commit data... | |
carrierwave.rb | Loading commit data... | |
chronic_duration.rb | Loading commit data... | |
connection_fix.rb | Loading commit data... | |
cookies_serializer.rb | Loading commit data... | |
date_time_formats.rb | Loading commit data... | |
default_url_options.rb | Loading commit data... | |
devise.rb | Loading commit data... | |
devise_password_length.rb.example | Loading commit data... | |
disable_email_interceptor.rb | Loading commit data... | |
doorkeeper.rb | Loading commit data... | |
gitlab_shell_secret_token.rb | Loading commit data... | |
gitlab_workhorse_secret.rb | Loading commit data... | |
go_get.rb | Loading commit data... | |
gollum.rb | Loading commit data... | |
hamlit.rb | Loading commit data... | |
health_check.rb | Loading commit data... | |
inflections.rb | Loading commit data... | |
kaminari_config.rb | Loading commit data... | |
metrics.rb | Loading commit data... | |
mime_types.rb | Loading commit data... | |
mysql_ignore_postgresql_options.rb | Loading commit data... | |
omniauth.rb | Loading commit data... | |
postgresql_limit_fix.rb | Loading commit data... | |
postgresql_opclasses_support.rb | Loading commit data... | |
premailer.rb | Loading commit data... | |
public_key.rb | Loading commit data... | |
rack_attack.rb.example | Loading commit data... | |
rack_attack_git_basic_auth.rb | Loading commit data... | |
rack_lineprof.rb | Loading commit data... | |
relative_naming_ci_namespace.rb | Loading commit data... | |
relative_url.rb.sample | Loading commit data... | |
request_profiler.rb | Loading commit data... | |
secret_token.rb | Loading commit data... | |
sentry.rb | Loading commit data... | |
session_store.rb | Loading commit data... | |
sherlock.rb | Loading commit data... | |
sidekiq.rb | Loading commit data... | |
smtp_settings.rb.sample | Loading commit data... | |
static_files.rb | Loading commit data... | |
time_zone.rb | Loading commit data... | |
trusted_proxies.rb | Loading commit data... | |
wrap_parameters.rb | Loading commit data... |