BigW Consortium Gitlab
Correct autocomplete for values with special characters ## What does this MR do? This adds a check for any special chars in any value passed to the `DefaultOptions.beforeInsert` callback function. If special chars are found and `skipSpecialCharTest` option is `false`, it will wrap the value in quotation marks. This fixed autocompleting `~customer+` instead of `~"customer+"`. ## Are there points in the code the reviewer needs to double check? ## Why was this MR needed? ## Screenshots (if relevant) ![2016-12-03_10.37.11](/uploads/59159623638939933d23b447692775b8/2016-12-03_10.37.11.gif) ## Does this MR meet the acceptance criteria? - [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [ ] API support added - Tests - [ ] Added for this feature/bug - [ ] All builds are passing - [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [ ] Branch has no merge conflicts with `master` (if it does - rebase it please) - [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? Closes #25286, #24961 See merge request !7910
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
admin | Loading commit data... | |
atom | Loading commit data... | |
boards | Loading commit data... | |
dashboard | Loading commit data... | |
groups | Loading commit data... | |
issuables | Loading commit data... | |
issues | Loading commit data... | |
merge_requests | Loading commit data... | |
milestones | Loading commit data... | |
profiles | Loading commit data... | |
projects | Loading commit data... | |
protected_branches | Loading commit data... | |
security | Loading commit data... | |
snippets | Loading commit data... | |
tags | Loading commit data... | |
todos | Loading commit data... | |
users | Loading commit data... | |
abuse_report_spec.rb | Loading commit data... | |
calendar_spec.rb | Loading commit data... | |
ci_lint_spec.rb | Loading commit data... | |
commits_spec.rb | Loading commit data... | |
compare_spec.rb | Loading commit data... | |
container_registry_spec.rb | Loading commit data... | |
dashboard_issues_spec.rb | Loading commit data... | |
dashboard_milestones_spec.rb | Loading commit data... | |
environment_spec.rb | Loading commit data... | |
environments_spec.rb | Loading commit data... | |
expand_collapse_diffs_spec.rb | Loading commit data... | |
gitlab_flavored_markdown_spec.rb | Loading commit data... | |
global_search_spec.rb | Loading commit data... | |
groups_spec.rb | Loading commit data... | |
help_pages_spec.rb | Loading commit data... | |
issues_spec.rb | Loading commit data... | |
login_spec.rb | Loading commit data... | |
markdown_spec.rb | Loading commit data... | |
milestone_spec.rb | Loading commit data... | |
notes_on_merge_requests_spec.rb | Loading commit data... | |
participants_autocomplete_spec.rb | Loading commit data... | |
password_reset_spec.rb | Loading commit data... | |
profile_spec.rb | Loading commit data... | |
projects_spec.rb | Loading commit data... | |
protected_branches_spec.rb | Loading commit data... | |
runners_spec.rb | Loading commit data... | |
search_spec.rb | Loading commit data... | |
signup_spec.rb | Loading commit data... | |
snippets_spec.rb | Loading commit data... | |
task_lists_spec.rb | Loading commit data... | |
triggers_spec.rb | Loading commit data... | |
u2f_spec.rb | Loading commit data... | |
unsubscribe_links_spec.rb | Loading commit data... | |
users_spec.rb | Loading commit data... | |
variables_spec.rb | Loading commit data... |