BigW Consortium Gitlab
Re-implement page-specific JS in a better way. ## What does this MR do? This rebuilds the way we do page-specific JavaScript assets for a few reasons: - The current implementation does not work with Subresource Integrity (!4808) - The current implementation doesn't allow caching of libraries because each page we hook up with this system will have a separate application.js. Meaning that for every page that uses Ace Editor, we'd have to load Ace Editor plus any GitLab-specific scripts in the same file, making local caching of just Ace Editor impossible. - The current implementation is rather hacky. ## Are there points in the code the reviewer needs to double check? That Sprockets doesn't choke on this when we use precompiled assets. ## What are the relevant issue numbers? #14372 ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [x] API support added - Tests - [x] Added for this feature/bug - [x] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) cc: @jschatz1 @pavelloz Thanks to @pavelloz for his example implementation which was very useful. See merge request !4883
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
artifacts | Loading commit data... | |
badges | Loading commit data... | |
blame | Loading commit data... | |
blob | Loading commit data... | |
branches | Loading commit data... | |
builds | Loading commit data... | |
buttons | Loading commit data... | |
ci | Loading commit data... | |
commit | Loading commit data... | |
commits | Loading commit data... | |
compare | Loading commit data... | |
container_registry | Loading commit data... | |
deploy_keys | Loading commit data... | |
deployments | Loading commit data... | |
diffs | Loading commit data... | |
environments | Loading commit data... | |
find_file | Loading commit data... | |
forks | Loading commit data... | |
generic_commit_statuses | Loading commit data... | |
graphs | Loading commit data... | |
group_links | Loading commit data... | |
hooks | Loading commit data... | |
imports | Loading commit data... | |
issues | Loading commit data... | |
labels | Loading commit data... | |
merge_requests | Loading commit data... | |
milestones | Loading commit data... | |
network | Loading commit data... | |
notes | Loading commit data... | |
pipelines | Loading commit data... | |
project_members | Loading commit data... | |
protected_branches | Loading commit data... | |
refs | Loading commit data... | |
releases | Loading commit data... | |
repositories | Loading commit data... | |
runners | Loading commit data... | |
services | Loading commit data... | |
snippets | Loading commit data... | |
tags | Loading commit data... | |
tree | Loading commit data... | |
triggers | Loading commit data... | |
variables | Loading commit data... | |
wikis | Loading commit data... | |
_activity.html.haml | Loading commit data... | |
_bitbucket_import_modal.html.haml | Loading commit data... | |
_builds_settings.html.haml | Loading commit data... | |
_commit_button.html.haml | Loading commit data... | |
_errors.html.haml | Loading commit data... | |
_files.html.haml | Loading commit data... | |
_find_file_link.html.haml | Loading commit data... | |
_github_import_modal.html.haml | Loading commit data... | |
_gitlab_import_modal.html.haml | Loading commit data... | |
_home_panel.html.haml | Loading commit data... | |
_last_commit.html.haml | Loading commit data... | |
_last_push.html.haml | Loading commit data... | |
_md_preview.html.haml | Loading commit data... | |
_merge_request_settings.html.haml | Loading commit data... | |
_readme.html.haml | Loading commit data... | |
_zen.html.haml | Loading commit data... | |
activity.html.haml | Loading commit data... | |
edit.html.haml | Loading commit data... | |
empty.html.haml | Loading commit data... | |
new.html.haml | Loading commit data... | |
no_repo.html.haml | Loading commit data... | |
remove_fork.js.haml | Loading commit data... | |
show.atom.builder | Loading commit data... | |
show.html.haml | Loading commit data... | |
transfer.js.haml | Loading commit data... | |
update.js.haml | Loading commit data... |