BigW Consortium Gitlab
Re-implement page-specific JS in a better way. ## What does this MR do? This rebuilds the way we do page-specific JavaScript assets for a few reasons: - The current implementation does not work with Subresource Integrity (!4808) - The current implementation doesn't allow caching of libraries because each page we hook up with this system will have a separate application.js. Meaning that for every page that uses Ace Editor, we'd have to load Ace Editor plus any GitLab-specific scripts in the same file, making local caching of just Ace Editor impossible. - The current implementation is rather hacky. ## Are there points in the code the reviewer needs to double check? That Sprockets doesn't choke on this when we use precompiled assets. ## What are the relevant issue numbers? #14372 ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [x] API support added - Tests - [x] Added for this feature/bug - [x] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) cc: @jschatz1 @pavelloz Thanks to @pavelloz for his example implementation which was very useful. See merge request !4883
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
ci | Loading commit data... | |
header | Loading commit data... | |
nav | Loading commit data... | |
_bootlint.haml | Loading commit data... | |
_broadcast.html.haml | Loading commit data... | |
_collapse_button.html.haml | Loading commit data... | |
_flash.html.haml | Loading commit data... | |
_google_analytics.html.haml | Loading commit data... | |
_head.html.haml | Loading commit data... | |
_init_auto_complete.html.haml | Loading commit data... | |
_page.html.haml | Loading commit data... | |
_page_title.html.haml | Loading commit data... | |
_piwik.html.haml | Loading commit data... | |
_search.html.haml | Loading commit data... | |
_user_styles.html.haml | Loading commit data... | |
admin.html.haml | Loading commit data... | |
application.html.haml | Loading commit data... | |
dashboard.html.haml | Loading commit data... | |
devise.html.haml | Loading commit data... | |
devise_empty.html.haml | Loading commit data... | |
devise_mailer.html.haml | Loading commit data... | |
errors.html.haml | Loading commit data... | |
explore.html.haml | Loading commit data... | |
group.html.haml | Loading commit data... | |
group_settings.html.haml | Loading commit data... | |
help.html.haml | Loading commit data... | |
notify.html.haml | Loading commit data... | |
profile.html.haml | Loading commit data... | |
project.html.haml | Loading commit data... | |
project_settings.html.haml | Loading commit data... | |
search.html.haml | Loading commit data... | |
snippets.html.haml | Loading commit data... |