BigW Consortium Gitlab
Fix bug where pagination is still displayed despite all todos marked as done ## What does this MR do? Changes the todo `mark all as done` button callback to remove pagination and add user friendly text `"You're all done!"` so that it is consistent with what the page should look like after refreshing ## Are there points in the code the reviewer needs to double check? Shouldn't be ## Why was this MR needed? Resolve existing UI inconsistency ## Screenshots (if relevant) Before: ![8xDRiXB1TL](/uploads/479edbdedf8d468b4c5e502f36a0c19f/8xDRiXB1TL.gif) After: ![q4XDxhujPX](/uploads/3566eb538e6ad5a2d32b78351b9bc47d/q4XDxhujPX.gif) ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - Tests - [x] Added for this feature/bug - [x] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? Closes #21048 See merge request !6113
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
behaviors | Loading commit data... | |
blob | Loading commit data... | |
blob_edit | Loading commit data... | |
boards | Loading commit data... | |
commit | Loading commit data... | |
diff_notes | Loading commit data... | |
extensions | Loading commit data... | |
graphs | Loading commit data... | |
lib | Loading commit data... | |
network | Loading commit data... | |
profile | Loading commit data... | |
snippet | Loading commit data... | |
templates | Loading commit data... | |
u2f | Loading commit data... | |
users | Loading commit data... | |
LabelManager.js | Loading commit data... | |
abuse_reports.js.es6 | Loading commit data... | |
activities.js | Loading commit data... | |
admin.js | Loading commit data... | |
api.js | Loading commit data... | |
application.js | Loading commit data... | |
aside.js | Loading commit data... | |
autosave.js | Loading commit data... | |
awards_handler.js | Loading commit data... | |
breakpoints.js | Loading commit data... | |
broadcast_message.js | Loading commit data... | |
build.js | Loading commit data... | |
build_artifacts.js | Loading commit data... | |
commit.js | Loading commit data... | |
commits.js | Loading commit data... | |
compare.js | Loading commit data... | |
compare_autocomplete.js | Loading commit data... | |
confirm_danger_modal.js | Loading commit data... | |
copy_to_clipboard.js | Loading commit data... | |
create_label.js.es6 | Loading commit data... | |
diff.js | Loading commit data... | |
dispatcher.js | Loading commit data... | |
dropzone_input.js | Loading commit data... | |
due_date_select.js | Loading commit data... | |
files_comment_button.js | Loading commit data... | |
flash.js | Loading commit data... | |
gfm_auto_complete.js.es6 | Loading commit data... | |
gl_dropdown.js | Loading commit data... | |
gl_form.js | Loading commit data... | |
group_avatar.js | Loading commit data... | |
groups.js | Loading commit data... | |
groups_select.js | Loading commit data... | |
importer_status.js | Loading commit data... | |
issuable.js | Loading commit data... | |
issuable_context.js | Loading commit data... | |
issuable_form.js | Loading commit data... | |
issue.js | Loading commit data... | |
issue_status_select.js | Loading commit data... | |
issues-bulk-assignment.js | Loading commit data... | |
labels.js | Loading commit data... | |
labels_select.js | Loading commit data... | |
layout_nav.js | Loading commit data... | |
line_highlighter.js | Loading commit data... | |
logo.js | Loading commit data... | |
member_expiration_date.js | Loading commit data... | |
merge_conflict_data_provider.js.es6 | Loading commit data... | |
merge_conflict_resolver.js.es6 | Loading commit data... | |
merge_request.js | Loading commit data... | |
merge_request_tabs.js | Loading commit data... | |
merge_request_widget.js | Loading commit data... | |
merged_buttons.js | Loading commit data... | |
milestone.js | Loading commit data... | |
milestone_select.js | Loading commit data... | |
namespace_select.js | Loading commit data... | |
new_branch_form.js | Loading commit data... | |
new_commit_form.js | Loading commit data... | |
notes.js | Loading commit data... | |
notifications_dropdown.js | Loading commit data... | |
notifications_form.js | Loading commit data... | |
pager.js | Loading commit data... | |
pipeline.js.es6 | Loading commit data... | |
preview_markdown.js | Loading commit data... | |
project.js | Loading commit data... | |
project_avatar.js | Loading commit data... | |
project_find_file.js | Loading commit data... | |
project_fork.js | Loading commit data... | |
project_import.js | Loading commit data... | |
project_members.js | Loading commit data... | |
project_new.js | Loading commit data... | |
project_select.js | Loading commit data... | |
project_show.js | Loading commit data... | |
projects_list.js | Loading commit data... | |
protected_branch_access_dropdown.js.es6 | Loading commit data... | |
protected_branch_create.js.es6 | Loading commit data... | |
protected_branch_dropdown.js.es6 | Loading commit data... | |
protected_branch_edit.js.es6 | Loading commit data... | |
protected_branch_edit_list.js.es6 | Loading commit data... | |
right_sidebar.js | Loading commit data... | |
search.js | Loading commit data... | |
search_autocomplete.js | Loading commit data... | |
shortcuts.js | Loading commit data... | |
shortcuts_blob.js | Loading commit data... | |
shortcuts_dashboard_navigation.js | Loading commit data... | |
shortcuts_find_file.js | Loading commit data... | |
shortcuts_issuable.js | Loading commit data... | |
shortcuts_navigation.js | Loading commit data... | |
shortcuts_network.js | Loading commit data... | |
sidebar.js | Loading commit data... | |
single_file_diff.js | Loading commit data... | |
star.js | Loading commit data... | |
subscription.js | Loading commit data... | |
subscription_select.js | Loading commit data... | |
syntax_highlight.js | Loading commit data... | |
todos.js | Loading commit data... | |
tree.js | Loading commit data... | |
user.js | Loading commit data... | |
user_tabs.js | Loading commit data... | |
users_select.js | Loading commit data... | |
wikis.js | Loading commit data... | |
zen_mode.js | Loading commit data... |