BigW Consortium Gitlab
There is a race condition in DestroyGroupService now that projects are deleted asynchronously: 1. User attempts to delete group 2. DestroyGroupService iterates through all projects and schedules a Sidekiq job to delete each Project 3. DestroyGroupService destroys the Group, leaving all its projects without a namespace 4. Projects::DestroyService runs later but the can?(current_user, :remove_project) is `false` because the user no longer has permission to destroy projects with no namespace. 5. This leaves the project in pending_delete state with no namespace/group. Projects without a namespace or group also adds another problem: it's not possible to destroy the container registry tags, since container_registry_path_with_namespace is the wrong value. The fix is to destroy the group asynchronously and to run execute directly on Projects::DestroyService. Closes #17893
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
abuse_reports_controller.rb | Loading commit data... | |
appearances_controller.rb | Loading commit data... | |
application_controller.rb | Loading commit data... | |
application_settings_controller.rb | Loading commit data... | |
applications_controller.rb | Loading commit data... | |
background_jobs_controller.rb | Loading commit data... | |
broadcast_messages_controller.rb | Loading commit data... | |
builds_controller.rb | Loading commit data... | |
dashboard_controller.rb | Loading commit data... | |
deploy_keys_controller.rb | Loading commit data... | |
groups_controller.rb | Loading commit data... | |
health_check_controller.rb | Loading commit data... | |
hooks_controller.rb | Loading commit data... | |
identities_controller.rb | Loading commit data... | |
impersonations_controller.rb | Loading commit data... | |
keys_controller.rb | Loading commit data... | |
labels_controller.rb | Loading commit data... | |
logs_controller.rb | Loading commit data... | |
projects_controller.rb | Loading commit data... | |
requests_profiles_controller.rb | Loading commit data... | |
runner_projects_controller.rb | Loading commit data... | |
runners_controller.rb | Loading commit data... | |
services_controller.rb | Loading commit data... | |
spam_logs_controller.rb | Loading commit data... | |
system_info_controller.rb | Loading commit data... | |
users_controller.rb | Loading commit data... |