BigW Consortium Gitlab
1. It makes sense to reuse these constants since we had them duplicated in the previous enum implementation. This also simplifies our `check_access` implementation, because we can use `project.team.max_member_access` directly. 2. Use `accepts_nested_attributes_for` to create push/merge access levels. This was a bit fiddly to set up, but this simplifies our code by quite a large amount. We can even get rid of `ProtectedBranches::BaseService`. 3. Move API handling back into the API (previously in `ProtectedBranches::BaseService#translate_api_params`. 4. The protected branch services now return a `ProtectedBranch` rather than `true/false`. 5. Run `load_protected_branches` on-demand in the `create` action, to prevent it being called unneccessarily. 6. "Masters" is pre-selected as the default option for "Allowed to Push" and "Allowed to Merge". 7. These changes were based on a review from @rymai in !5081.
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
admin | Loading commit data... | |
ci | Loading commit data... | |
concerns | Loading commit data... | |
dashboard | Loading commit data... | |
explore | Loading commit data... | |
groups | Loading commit data... | |
import | Loading commit data... | |
oauth | Loading commit data... | |
profiles | Loading commit data... | |
projects | Loading commit data... | |
sherlock | Loading commit data... | |
abuse_reports_controller.rb | Loading commit data... | |
application_controller.rb | Loading commit data... | |
autocomplete_controller.rb | Loading commit data... | |
confirmations_controller.rb | Loading commit data... | |
dashboard_controller.rb | Loading commit data... | |
emojis_controller.rb | Loading commit data... | |
groups_controller.rb | Loading commit data... | |
health_check_controller.rb | Loading commit data... | |
help_controller.rb | Loading commit data... | |
invites_controller.rb | Loading commit data... | |
jwt_controller.rb | Loading commit data... | |
namespaces_controller.rb | Loading commit data... | |
notification_settings_controller.rb | Loading commit data... | |
omniauth_callbacks_controller.rb | Loading commit data... | |
passwords_controller.rb | Loading commit data... | |
profiles_controller.rb | Loading commit data... | |
projects_controller.rb | Loading commit data... | |
registrations_controller.rb | Loading commit data... | |
root_controller.rb | Loading commit data... | |
search_controller.rb | Loading commit data... | |
sent_notifications_controller.rb | Loading commit data... | |
sessions_controller.rb | Loading commit data... | |
snippets_controller.rb | Loading commit data... | |
uploads_controller.rb | Loading commit data... | |
users_controller.rb | Loading commit data... |