BigW Consortium Gitlab
Allow dots in group names to pass validation for Create Group and Edit Group forms ## What does this MR do? Allows dots within group names to pass form validation when creating or editing a group. ## Are there points in the code the reviewer needs to double check? Nope, pretty straight forward. ## Why was this MR needed? Although group names with dots are allowed, our frontend validation mistakenly invalidates them ## Screenshots (if relevant) #### Before: ![Screen_Shot_2016-11-23_at_4.55.03_PM](/uploads/006ee5f694de1c98e0df0b0ccd3807ee/Screen_Shot_2016-11-23_at_4.55.03_PM.png) #### After: ![Screen_Shot_2016-11-23_at_4.52.42_PM](/uploads/693f112fb309005b0df714b32c99f25e/Screen_Shot_2016-11-23_at_4.52.42_PM.png) ![Screen_Shot_2016-11-23_at_4.51.53_PM](/uploads/7bdb5fca92995d18a7f38d9150eb260c/Screen_Shot_2016-11-23_at_4.51.53_PM.png) ## Does this MR meet the acceptance criteria? - [ ] ~~[Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added~~ - [ ] ~~[Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)~~ - [ ] ~~API support added~~ - Tests - [ ] Added for this feature/bug - [ ] All builds are passing - [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if it does - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? Related to: #24622 Closes #24903 See merge request !7723
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
builds | Loading commit data... | |
empty_states | Loading commit data... | |
groups | Loading commit data... | |
icons | Loading commit data... | |
issuable | Loading commit data... | |
labels | Loading commit data... | |
members | Loading commit data... | |
milestones | Loading commit data... | |
notifications | Loading commit data... | |
projects | Loading commit data... | |
snippets | Loading commit data... | |
web_hooks | Loading commit data... | |
_allow_request_access.html.haml | Loading commit data... | |
_choose_group_avatar_button.html.haml | Loading commit data... | |
_clone_panel.html.haml | Loading commit data... | |
_commit_message_container.html.haml | Loading commit data... | |
_confirm_modal.html.haml | Loading commit data... | |
_event_filter.html.haml | Loading commit data... | |
_field.html.haml | Loading commit data... | |
_file_highlight.html.haml | Loading commit data... | |
_group_form.html.haml | Loading commit data... | |
_group_tips.html.haml | Loading commit data... | |
_import_form.html.haml | Loading commit data... | |
_issues.html.haml | Loading commit data... | |
_label.html.haml | Loading commit data... | |
_label_row.html.haml | Loading commit data... | |
_labels_row.html.haml | Loading commit data... | |
_logo.svg | Loading commit data... | |
_merge_requests.html.haml | Loading commit data... | |
_milestone_expired.html.haml | Loading commit data... | |
_milestones_filter.html.haml | Loading commit data... | |
_nav_scroll.html.haml | Loading commit data... | |
_new_commit_form.html.haml | Loading commit data... | |
_new_project_item_select.html.haml | Loading commit data... | |
_no_password.html.haml | Loading commit data... | |
_no_ssh.html.haml | Loading commit data... | |
_outdated_browser.html.haml | Loading commit data... | |
_project_limit.html.haml | Loading commit data... | |
_promo.html.haml | Loading commit data... | |
_ref_switcher.html.haml | Loading commit data... | |
_service_settings.html.haml | Loading commit data... | |
_show_aside.html.haml | Loading commit data... | |
_sort_dropdown.html.haml | Loading commit data... | |
_visibility_level.html.haml | Loading commit data... | |
_visibility_radios.html.haml | Loading commit data... |