BigW Consortium Gitlab
Re-implement page-specific JS in a better way. ## What does this MR do? This rebuilds the way we do page-specific JavaScript assets for a few reasons: - The current implementation does not work with Subresource Integrity (!4808) - The current implementation doesn't allow caching of libraries because each page we hook up with this system will have a separate application.js. Meaning that for every page that uses Ace Editor, we'd have to load Ace Editor plus any GitLab-specific scripts in the same file, making local caching of just Ace Editor impossible. - The current implementation is rather hacky. ## Are there points in the code the reviewer needs to double check? That Sprockets doesn't choke on this when we use precompiled assets. ## What are the relevant issue numbers? #14372 ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [x] API support added - Tests - [x] Added for this feature/bug - [x] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) cc: @jschatz1 @pavelloz Thanks to @pavelloz for his example implementation which was very useful. See merge request !4883
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
appearances_helper.rb | Loading commit data... | |
application_helper.rb | Loading commit data... | |
application_settings_helper.rb | Loading commit data... | |
auth_helper.rb | Loading commit data... | |
blob_helper.rb | Loading commit data... | |
branches_helper.rb | Loading commit data... | |
broadcast_messages_helper.rb | Loading commit data... | |
button_helper.rb | Loading commit data... | |
ci_status_helper.rb | Loading commit data... | |
commits_helper.rb | Loading commit data... | |
compare_helper.rb | Loading commit data... | |
dashboard_helper.rb | Loading commit data... | |
diff_helper.rb | Loading commit data... | |
dropdowns_helper.rb | Loading commit data... | |
emails_helper.rb | Loading commit data... | |
events_helper.rb | Loading commit data... | |
explore_helper.rb | Loading commit data... | |
external_wiki_helper.rb | Loading commit data... | |
form_helper.rb | Loading commit data... | |
git_helper.rb | Loading commit data... | |
gitlab_markdown_helper.rb | Loading commit data... | |
gitlab_routing_helper.rb | Loading commit data... | |
graph_helper.rb | Loading commit data... | |
groups_helper.rb | Loading commit data... | |
icons_helper.rb | Loading commit data... | |
import_helper.rb | Loading commit data... | |
issuables_helper.rb | Loading commit data... | |
issues_helper.rb | Loading commit data... | |
javascript_helper.rb | Loading commit data... | |
labels_helper.rb | Loading commit data... | |
members_helper.rb | Loading commit data... | |
merge_requests_helper.rb | Loading commit data... | |
milestones_helper.rb | Loading commit data... | |
namespaces_helper.rb | Loading commit data... | |
nav_helper.rb | Loading commit data... | |
notes_helper.rb | Loading commit data... | |
notifications_helper.rb | Loading commit data... | |
page_layout_helper.rb | Loading commit data... | |
preferences_helper.rb | Loading commit data... | |
projects_helper.rb | Loading commit data... | |
runners_helper.rb | Loading commit data... | |
search_helper.rb | Loading commit data... | |
selects_helper.rb | Loading commit data... | |
snippets_helper.rb | Loading commit data... | |
sorting_helper.rb | Loading commit data... | |
submodule_helper.rb | Loading commit data... | |
tab_helper.rb | Loading commit data... | |
tags_helper.rb | Loading commit data... | |
time_helper.rb | Loading commit data... | |
todos_helper.rb | Loading commit data... | |
tree_helper.rb | Loading commit data... | |
triggers_helper.rb | Loading commit data... | |
version_check_helper.rb | Loading commit data... | |
visibility_level_helper.rb | Loading commit data... | |
workhorse_helper.rb | Loading commit data... |