- 22 Aug, 2017 1 commit
-
-
Robert Speicher authored
Add `:broken_storage` metadata to examples to disable this behavior only when necessary.
-
- 17 Aug, 2017 1 commit
-
-
Grzegorz Bizon authored
`migrate!` helper triggers a migration that is under the test, so we need to revert it before each subsequent example. This means that we need to place it in `before(:each, :migration)` hook. We still want to migrate everything up *after* each *context*, so in otherwords we need to place migrate up helper in `before(:context, :migration)`.
-
- 16 Aug, 2017 2 commits
-
-
Grzegorz Bizon authored
-
Grzegorz Bizon authored
-
- 11 Aug, 2017 3 commits
-
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Nick Thomas authored
-
- 07 Aug, 2017 1 commit
-
-
Lin Jen-Shin authored
So that we could make sure migration tests could run even if geo is not setup in EE. This is because we have a model like this: ``` ruby class Geo::BaseRegistry < ActiveRecord::Base def self.connection raise 'Geo secondary database is not configured' unless Gitlab::Geo.geo_database_configured? super end end ```
-
- 02 Aug, 2017 1 commit
-
-
Lin Jen-Shin authored
Also make it easier to have mailer helper
-
- 31 Jul, 2017 1 commit
-
-
Sean McGivern authored
This was migrated to separate columns in 9.4, and now just needs to be removed for real.
-
- 28 Jul, 2017 1 commit
-
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 27 Jul, 2017 3 commits
-
-
Alexis Reigel authored
since everything (except the CurrentKeyChain method) operates on a tempoary keychain anyway we don't need this anymore.
-
Alexis Reigel authored
-
Alexis Reigel authored
-
- 24 Jul, 2017 1 commit
-
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 19 Jul, 2017 1 commit
-
-
Paweł Chojnacki authored
-
- 13 Jul, 2017 1 commit
-
-
Bob Van Landuyt authored
Otherwise some features would go untested in non-specific contexts I did need to disable the `gitlab_git_diff_size_limit_increase`-feature in some specs since we depend on diffs being expandable while the file we are testing on is smaller than the increased limit.
-
- 12 Jul, 2017 1 commit
-
-
blackst0ne authored
-
- 11 Jul, 2017 1 commit
-
-
Paul Charlton authored
-
- 07 Jul, 2017 1 commit
-
-
Douwe Maan authored
-
- 05 Jul, 2017 1 commit
-
-
Douwe Maan authored
-
- 19 Jun, 2017 1 commit
-
-
Robert Speicher authored
-
- 15 Jun, 2017 1 commit
-
-
Stan Hu authored
-
- 13 Jun, 2017 1 commit
-
-
Grzegorz Bizon authored
-
- 12 Jun, 2017 1 commit
-
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 09 Jun, 2017 1 commit
-
-
Oswaldo Ferreira authored
-
- 05 Jun, 2017 1 commit
-
-
Grzegorz Bizon authored
This makes it possible to test migration on the schema this migration was written for, without a need to specify a previous schema version manually.
-
- 02 Jun, 2017 1 commit
-
-
Pawel Chojnacki authored
+ Use NullMetrics to mock metrics when unused + Use method_missing in NullMetrics mocking + Update prometheus gem to version that correctly uses transitive dependencies + Ensure correct folders are used in Multiprocess prometheus client tests. + rename Sessions controller's metric
-
- 31 May, 2017 1 commit
-
-
Gabriel Mazetto authored
-
- 26 May, 2017 4 commits
-
-
Grzegorz Bizon authored
-
Grzegorz Bizon authored
-
Grzegorz Bizon authored
-
Grzegorz Bizon authored
-
- 25 May, 2017 1 commit
-
-
Grzegorz Bizon authored
-
- 22 May, 2017 1 commit
-
-
Oswaldo Ferreira authored
-
- 19 May, 2017 1 commit
-
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 17 May, 2017 2 commits
-
-
Yorick Peterse authored
This hides/disables some UI elements and API parameters related to nested groups when MySQL is used, since nested groups are not supported for MySQL.
-
Yorick Peterse authored
This commit introduces the usage of Common Table Expressions (CTEs) to efficiently retrieve nested group hierarchies, without having to rely on the "routes" table (which is an _incredibly_ inefficient way of getting the data). This requires a patch to ActiveRecord (found in the added initializer) to work properly as ActiveRecord doesn't support WITH statements properly out of the box. Unfortunately MySQL provides no efficient way of getting nested groups. For example, the old routes setup could easily take 5-10 seconds depending on the amount of "routes" in a database. Providing vastly different logic for both MySQL and PostgreSQL will negatively impact the development process. Because of this the various nested groups related methods return empty relations when used in combination with MySQL. For project authorizations the logic is split up into two classes: * Gitlab::ProjectAuthorizations::WithNestedGroups * Gitlab::ProjectAuthorizations::WithoutNestedGroups Both classes get the fresh project authorizations (= as they should be in the "project_authorizations" table), including nested groups if PostgreSQL is used. The logic of these two classes is quite different apart from their public interface. This complicates development a bit, but unfortunately there is no way around this. This commit also introduces Gitlab::GroupHierarchy. This class can be used to get the ancestors and descendants of a base relation, or both by using a UNION. This in turn is used by methods such as: * Namespace#ancestors * Namespace#descendants * User#all_expanded_groups Again this class relies on CTEs and thus only works on PostgreSQL. The Namespace methods will return an empty relation when MySQL is used, while User#all_expanded_groups will return only the groups a user is a direct member of. Performance wise the impact is quite large. For example, on GitLab.com Namespace#descendants used to take around 580 ms to retrieve data for a particular user. Using CTEs we are able to reduce this down to roughly 1 millisecond, returning the exact same data. == On The Fly Refreshing Refreshing of authorizations on the fly (= when users.authorized_projects_populated was not set) is removed with this commit. This simplifies the code, and ensures any queries used for authorizations are not mutated because they are executed in a Rails scope (e.g. Project.visible_to_user). This commit includes a migration to schedule refreshing authorizations for all users, ensuring all of them have their authorizations in place. Said migration schedules users in batches of 5000, with 5 minutes between every batch to smear the load around a bit. == Spec Changes This commit also introduces some changes to various specs. For example, some specs for ProjectTeam assumed that creating a personal project would _not_ lead to the owner having access, which is incorrect. Because we also no longer refresh authorizations on the fly for new users some code had to be added to the "empty_project" factory. This chunk of code ensures that the owner's permissions are refreshed after creating the project, something that is normally done in Projects::CreateService.
-
- 28 Apr, 2017 1 commit
-
-
Rémy Coutable authored
-
- 13 Apr, 2017 1 commit
-
-
Rémy Coutable authored
`rspec_profiling` will be enabled if the branch name includes `rspec-profile`. Signed-off-by: Rémy Coutable <remy@rymai.me>
-