BigW Consortium Gitlab

  1. 23 Jun, 2017 1 commit
  2. 07 Mar, 2017 1 commit
  3. 24 Jan, 2017 1 commit
  4. 31 Dec, 2016 3 commits
  5. 16 Dec, 2016 4 commits
    • View-related (and other minor) changes to !5951 based on @rymai's review. · f706a973
      Timothy Andrew authored
      - The `scopes_form` partial can be used in the `admin/applications` view
        as well
      
      - Don't allow partials to access instance variables directly. Instead, pass
        in the instance variables as local variables, and use `local_assigns.fetch`
        to assert that the variables are passed in as expected.
      
      - Change a few instances of `render :partial` to `render`
      
      - Remove an instance of `required: false` in a view, since this is the default
      
      - Inline many instances of a local variable (`ip = 'ip'`) in `auth_spec`
    • Move the scopes form/list view into a partial. · 990ae6b8
      Timothy Andrew authored
      - The list of scopes that's displayed while creating a personal access
        token is identical to the list that's displayed while creating an OAuth
        application. Extract these into a partial.
      
      - The list of scopes that's displayed while in the show page for an OAuth token
        in the profile settings and admin settings are identical. Extract these into
        a partial.
    • Implement minor changes from @dbalexandre's review. · 4d6da770
      Timothy Andrew authored
      - Mainly whitespace changes.
      
      - Require the migration adding the `scope` column to the
        `personal_access_tokens` table to have downtime, since API calls will
        fail if the new code is in place, but the migration hasn't run.
      
      - Minor refactoring - load `@scopes` in a `before_action`, since we're
        doing it in three different places.
  6. 26 Sep, 2016 1 commit
  7. 03 Jun, 2016 2 commits
  8. 22 May, 2016 1 commit
  9. 25 Apr, 2016 1 commit
  10. 19 Apr, 2016 1 commit
  11. 14 Apr, 2016 1 commit
  12. 05 Apr, 2016 1 commit
    • Standardize the way we check for and display form errors · 7a2370f7
      Robert Speicher authored
      - Some views had a "Close" button. We've removed this, because we don't
        want users accidentally hiding the validation errors and not knowing
        what needs to be fixed.
      - Some views used `li`, some used `p`, some used `span`. We've
        standardized on `li`.
      - Some views only showed the first error. We've standardized on showing
        all of them.
      - Some views added an `#error_explanation` div, which we've made
        standard.
  13. 23 Mar, 2016 1 commit
  14. 20 Mar, 2016 1 commit
  15. 13 Mar, 2016 1 commit
    • Let `oauth/applications#index` handle the `profiles#applications` route · 8f21e2ae
      Robert Speicher authored
      Previously we were doing all of kinds of code gymnastics and flash abuse
      in order to work with a Doorkeeper controller but have it _appear_ at
      the `/profile/applications` path. Fortunately we can just tell Rails to
      use a different controller to handle that route, and we get the best of
      both worlds.
  16. 04 Mar, 2016 2 commits
  17. 26 Jan, 2016 2 commits
  18. 19 Oct, 2015 1 commit
  19. 02 Jul, 2015 1 commit
  20. 15 Jun, 2015 2 commits
  21. 30 Apr, 2015 2 commits
  22. 14 Mar, 2015 1 commit
  23. 25 Dec, 2014 1 commit
  24. 24 Dec, 2014 1 commit