- 30 Nov, 2015 1 commit
-
-
Valery Sizov authored
-
- 20 Nov, 2015 1 commit
-
-
Yorick Peterse authored
When calling MergeRequest#ci_commit the code would previously raise an error if the source project no longer existed (e.g. because the user removed their fork). See #3599 for more information.
-
- 19 Nov, 2015 3 commits
-
-
Valery Sizov authored
-
Valery Sizov authored
-
Valery Sizov authored
-
- 18 Nov, 2015 7 commits
-
-
Valery Sizov authored
-
Yorick Peterse authored
These methods no longer include public groups/projects (that don't belong to the actual user) as this is handled by the various finder classes now. This also removes the need for passing extra arguments. Note that memoizing was removed _explicitly_. For whatever reason doing so messes up the users controller to a point where it claims a certain user does _not_ have access to certain groups/projects when it does have access. Existing code shouldn't be affected as these methods are only called in ways that they'd run queries anyway (e.g. a combination of "any?" and "each" which would run 2 queries regardless of memoizing).
-
Yorick Peterse authored
This method can be used to filter projects to those visible to a given user.
-
Yorick Peterse authored
These methods will be used to get a list of groups, optionally restricted to only those visible to a given user.
-
Yorick Peterse authored
This will be used to move some querying logic from the users controller to the Event model (where it belongs).
-
Yorick Peterse authored
This new setup no longer loads any IDs into memory using "pluck", instead using SQL UNIONs to merge the various datasets together. This results in greatly improved query performance as well as a reduction of memory usage. The old setup was in particular problematic when requesting the authorized projects _including_ public/internal projects as this would result in roughly 65000 project IDs being loaded into memory. These IDs would in turn be passed to other queries.
-
Yorick Peterse authored
Instead of using MAX(events.updated_at) we can simply sort the events in descending order by the "id" column and grab the first row. In other words, instead of this: SELECT max(events.updated_at) AS max_id FROM events LEFT OUTER JOIN projects ON projects.id = events.project_id LEFT OUTER JOIN namespaces ON namespaces.id = projects.namespace_id WHERE events.author_id IS NOT NULL AND events.project_id IN (13083); we can use this: SELECT events.updated_at AS max_id FROM events LEFT OUTER JOIN projects ON projects.id = events.project_id LEFT OUTER JOIN namespaces ON namespaces.id = projects.namespace_id WHERE events.author_id IS NOT NULL AND events.project_id IN (13083) ORDER BY events.id DESC LIMIT 1; This has the benefit that on PostgreSQL a backwards index scan can be used, which due to the "LIMIT 1" will at most process only a single row. This in turn greatly speeds up the process of grabbing the latest update time. This can be confirmed by looking at the query plans. The first query produces the following plan: Aggregate (cost=43779.84..43779.85 rows=1 width=12) (actual time=2142.462..2142.462 rows=1 loops=1) -> Index Scan using index_events_on_project_id on events (cost=0.43..43704.69 rows=30060 width=12) (actual time=0.033..2138.086 rows=32769 loops=1) Index Cond: (project_id = 13083) Filter: (author_id IS NOT NULL) Planning time: 1.248 ms Execution time: 2142.548 ms The second query in turn produces the following plan: Limit (cost=0.43..41.65 rows=1 width=16) (actual time=1.394..1.394 rows=1 loops=1) -> Index Scan Backward using events_pkey on events (cost=0.43..1238907.96 rows=30060 width=16) (actual time=1.394..1.394 rows=1 loops=1) Filter: ((author_id IS NOT NULL) AND (project_id = 13083)) Rows Removed by Filter: 2104 Planning time: 0.166 ms Execution time: 1.408 ms According to the above plans the 2nd query is around 1500 times faster. However, re-running the first query produces timings of around 80 ms, making the 2nd query "only" around 55 times faster.
-
- 16 Nov, 2015 2 commits
-
-
Robert Speicher authored
Closes #3026
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 13 Nov, 2015 3 commits
-
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
Kamil Trzcinski authored
-
Kamil Trzcinski authored
- Enable CI by default for all new projects
-
- 10 Nov, 2015 1 commit
-
-
Kamil Trzcinski authored
- Offloads uploading to GitLab Workhorse - Use /authorize request for fast uploading - Added backup recipes for artifacts - Support download acceleration using X-Sendfile
-
- 08 Nov, 2015 1 commit
-
-
Kamil Trzcinski authored
-
- 06 Nov, 2015 1 commit
-
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 05 Nov, 2015 3 commits
-
-
Kamil Trzcinski authored
- Add page titles to CI settings. - Fix CI admin navigation. - Remove duplicated scope. - Use monospace font for commit sha. - Add page title and header title to build page. - Proper authorization for cancel/retry builds. - Use gitlab pagination theme for builds and group members. - Don't paginate builds widget on build page. - Add badges to commit page Changes/Builds tabs. - Add "Builds" to commit Builds tab page title. - Add and use Ci::Build#retryable? method. - Add CI::Build#retried? method. - Allow all failed commit builds to be retried. - Proper authorization for cancel/retry all builds. - Remove unused param. - Use time_ago_with_tooltip where appropriate. - Tweak builds index text - Remove duplication between builds/build and commit_statuses/commit_status. - Use POST rather than GET for canceling and retrying builds. - Remove redundant URL helpers. - Add build ID to build page. - Link branch name on build page. - Move commit/:sha/ci to commit/:sha/builds.
-
Valery Sizov authored
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 03 Nov, 2015 2 commits
-
-
Robert Speicher authored
Closes #3311
-
Yorick Peterse authored
The descriptions were not accurate and one particular spec seemingly expected the wrong User row to be returned.
-
- 02 Nov, 2015 1 commit
-
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 29 Oct, 2015 6 commits
-
-
Michael Chmielewski authored
-
Michael Chmielewski authored
Fixed method to use git log via Popen as recommended, and made output match test (and thus system) expectations.
-
Michael Chmielewski authored
-
Michael Chmielewski authored
-
Mike Chmielewski authored
-
Jonathan Schoeffling authored
Include the log messages of recent commits in project-level search results, providing functionality similar to 'git log --grep'. Update repository model rspec tests to validate the output of Repository#commits_with_log_matching.
-
- 22 Oct, 2015 1 commit
-
-
Valery Sizov authored
-
- 19 Oct, 2015 1 commit
-
-
Yorick Peterse authored
This cuts down the time it takes to sort issues of a milestone by about 10x. In the previous setup the code would run a SQL query for every issue that had to be sorted. The new setup instead runs a single SQL query to update all the given issues at once. The attached benchmark used to run at around 60 iterations per second, using the new setup this hovers around 600 iterations per second. Timing wise a request to update a milestone with 40-something issues would take about 760 ms, in the new setup this only takes about 130 ms. Fixes #3066
-
- 16 Oct, 2015 2 commits
-
-
Zeger-Jan van de Weg authored
-
Robert Speicher authored
[ci skip]
-
- 15 Oct, 2015 3 commits
-
-
Kamil Trzcinski authored
-
Kamil Trzcinski authored
-
Alex Lossent authored
Password can now be specified at the same time as the new URL, and the service template admin pages now work.
-
- 14 Oct, 2015 1 commit
-
-
Valery Sizov authored
This reverts commit b4639754.
-