BigW Consortium Gitlab

  1. 16 Jun, 2016 2 commits
  2. 12 Jun, 2016 1 commit
    • Fix Error 500 when viewing a blob with binary characters after the 1024-byte mark · 0fdfd2dd
      Stan Hu authored
      Here was the problem:
      
      1. When determining whether a given blob is viewable text, gitlab_git reads the first 1024 bytes and checks with Linguist whether it is a text or binary file.
      2. If the blob is text, GitLab will attempt to display it.
      3. However, if the text has binary characters after the first 1024 bytes, then GitLab will attempt to load the entire contents, but the encoding will be ASCII-8BIT since there are binary characters.
      4. The Error 500 results when GitLab attempts to display a mix UTF-8 and ASCII-8BIT.
      
      To fix this, we load as much data as we are willing to display so that the detection will work properly. Requires
      an update to gitlab_git: gitlab-org/gitlab_git!86
      
      Closes #13826
  3. 28 Apr, 2016 1 commit
  4. 07 Mar, 2016 1 commit
  5. 19 Feb, 2016 1 commit
    • Add a `Blob` model that wraps `Gitlab::Git::Blob` · 8c454b36
      Robert Speicher authored
      This allows us to take advantage of Rails' `to_partial_path` to render
      the correct partial based on the Blob type, rather than cluttering the
      view with conditionals.
      
      It also allows (and will allow in the future) better encapsulation for
      Blob-related logic which makes sense for our Rails app but might not
      make as much sense for the core `gitlab_git` library, such as detecting
      if the blob is an SVG.