- 23 May, 2017 2 commits
-
-
Shinya Maeda authored
Squashed commit of the following: commit 43e5bba774e9e383dd55c665e82f6fcfc4ebfc4f Author: Shinya Maeda <gitlab.shinyamaeda@gmail.com> Date: Mon Apr 17 17:28:44 2017 +0900 Add fix commit 09610eebdf22ad048812bb86022504b2ad917e19 Author: Shinya Maeda <gitlab.shinyamaeda@gmail.com> Date: Mon Apr 17 17:03:49 2017 +0900 Add trace test
-
Z.J. van de Weg authored
-
- 22 May, 2017 1 commit
-
-
Felipe Artur authored
-
- 20 May, 2017 1 commit
-
-
Oswaldo Ferreira authored
-
- 19 May, 2017 4 commits
-
-
Ruben Davila authored
-
Michael Kozono authored
In order to avoid string manipulation or modify route params (to make them unambiguous for `url_for`), we are accepting a behavior change: When being redirected to the canonical path for a group, if you requested a group show path starting with `/groups/…` then you’ll now be redirected to the group at root `/…`.
-
Oswaldo Ferreira authored
-
Zeger-Jan van de Weg authored
-
- 18 May, 2017 1 commit
-
-
Oswaldo Ferreira authored
-
- 17 May, 2017 3 commits
-
-
Yorick Peterse authored
This commit introduces the usage of Common Table Expressions (CTEs) to efficiently retrieve nested group hierarchies, without having to rely on the "routes" table (which is an _incredibly_ inefficient way of getting the data). This requires a patch to ActiveRecord (found in the added initializer) to work properly as ActiveRecord doesn't support WITH statements properly out of the box. Unfortunately MySQL provides no efficient way of getting nested groups. For example, the old routes setup could easily take 5-10 seconds depending on the amount of "routes" in a database. Providing vastly different logic for both MySQL and PostgreSQL will negatively impact the development process. Because of this the various nested groups related methods return empty relations when used in combination with MySQL. For project authorizations the logic is split up into two classes: * Gitlab::ProjectAuthorizations::WithNestedGroups * Gitlab::ProjectAuthorizations::WithoutNestedGroups Both classes get the fresh project authorizations (= as they should be in the "project_authorizations" table), including nested groups if PostgreSQL is used. The logic of these two classes is quite different apart from their public interface. This complicates development a bit, but unfortunately there is no way around this. This commit also introduces Gitlab::GroupHierarchy. This class can be used to get the ancestors and descendants of a base relation, or both by using a UNION. This in turn is used by methods such as: * Namespace#ancestors * Namespace#descendants * User#all_expanded_groups Again this class relies on CTEs and thus only works on PostgreSQL. The Namespace methods will return an empty relation when MySQL is used, while User#all_expanded_groups will return only the groups a user is a direct member of. Performance wise the impact is quite large. For example, on GitLab.com Namespace#descendants used to take around 580 ms to retrieve data for a particular user. Using CTEs we are able to reduce this down to roughly 1 millisecond, returning the exact same data. == On The Fly Refreshing Refreshing of authorizations on the fly (= when users.authorized_projects_populated was not set) is removed with this commit. This simplifies the code, and ensures any queries used for authorizations are not mutated because they are executed in a Rails scope (e.g. Project.visible_to_user). This commit includes a migration to schedule refreshing authorizations for all users, ensuring all of them have their authorizations in place. Said migration schedules users in batches of 5000, with 5 minutes between every batch to smear the load around a bit. == Spec Changes This commit also introduces some changes to various specs. For example, some specs for ProjectTeam assumed that creating a personal project would _not_ lead to the owner having access, which is incorrect. Because we also no longer refresh authorizations on the fly for new users some code had to be added to the "empty_project" factory. This chunk of code ensures that the owner's permissions are refreshed after creating the project, something that is normally done in Projects::CreateService.
-
Z.J. van de Weg authored
The pipeline was quite meagre in both stages and the number of groups. This has been improved. Performance is not yet optimal, but to limit this from sliding further this slippery slope, a hard limit has been set.
-
Z.J. van de Weg authored
Fixes gitlab-org/gitlab-ce#30814
-
- 12 May, 2017 2 commits
-
-
Sean McGivern authored
I don't know why this happens exactly, but given an upstream and fork repository from a customer, both of which required GC, resolving conflicts would corrupt the fork so badly that it couldn't be cloned. This isn't a perfect fix for that case, because the MR may still need to be merged manually, but it does ensure that the repository is at least usable. My best guess is that when we generate the index for the conflict resolution (which we previously did in the target project), we obtain a reference to an OID that doesn't exist in the source, even though we already fetch the refs from the target into the source. Explicitly setting the source project as the place to get the merge index from seems to prevent repository corruption in this way.
-
Pawel Chojnacki authored
-
- 09 May, 2017 1 commit
-
-
Fatih Acet authored
-
- 08 May, 2017 2 commits
-
-
Felipe Artur authored
-
Felipe Artur authored
-
- 07 May, 2017 1 commit
-
-
Zeger-Jan van de Weg authored
-
- 06 May, 2017 1 commit
-
-
Zeger-Jan van de Weg authored
-
- 05 May, 2017 1 commit
-
-
Grzegorz Bizon authored
-
- 04 May, 2017 4 commits
-
-
Valery Sizov authored
-
Douwe Maan authored
-
Alfredo Sumaran authored
-
Mark Fletcher authored
* Regards project-level pages config - Nav link is now shown only if Pages is enabled for instance - Navigation to following controllers denied if Pages disabled: * projects/pages_controller * projects/pages_domains_controller - 'disabled' partial removed + Test for pages_controller introduced
-
- 03 May, 2017 1 commit
-
-
Grzegorz Bizon authored
-
- 02 May, 2017 2 commits
-
-
Jarka Kadlecova authored
-
Grzegorz Bizon authored
-
- 28 Apr, 2017 1 commit
-
-
Dosuken shinya authored
-
- 27 Apr, 2017 1 commit
-
-
Tiago Botelho authored
-
- 26 Apr, 2017 4 commits
-
-
Sean McGivern authored
- Ignore JS fixtures - Ignore qa directory - Rewrite concern specs to put concern name first
-
Phil Hughes authored
-
Phil Hughes authored
-
Jarka Kadlecova authored
-
- 24 Apr, 2017 3 commits
-
-
Pawel Chojnacki authored
-
Stan Hu authored
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 21 Apr, 2017 2 commits
-
-
Jacopo authored
Removed all the unnecessary include of `WaitForAjax` and `ApiHelpers` in the specs. Removed unnecessary usage of `api:true`
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 20 Apr, 2017 1 commit
-
-
Douwe Maan authored
-
- 17 Apr, 2017 1 commit
-
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-