- 07 Apr, 2017 1 commit
-
-
Adam Buckland authored
Example: for issues that are closed, the links will now show '[closed]' following the issue number. This is done as post-process after the markdown has been loaded from the cache as the status of the issue may change between the cache being populated and the content being displayed. In order to avoid N+1 queries problem when rendering notes ObjectRenderer populates the cache of referenced issuables for all notes at once, before the post processing phase. As a part of this change, the Banzai BaseParser#grouped_objects_for_nodes method has been refactored to return a Hash utilising the node itself as the key, since this was a common pattern of usage for this method.
-
- 06 Apr, 2017 1 commit
-
-
Robert Speicher authored
Remove class from SanitizationFilter whitelist See merge request !2079
-
- 15 Mar, 2017 1 commit
-
-
Mike Greiling authored
-
- 23 Feb, 2017 4 commits
-
-
Douwe Maan authored
This reverts commit e00fb2bdc2090e9cabeb1eb35a2672a882cc96e9. # Conflicts: # .rubocop.yml # .rubocop_todo.yml # lib/gitlab/ci/config/entry/global.rb # lib/gitlab/ci/config/entry/jobs.rb # spec/lib/gitlab/ci/config/entry/factory_spec.rb # spec/lib/gitlab/ci/config/entry/global_spec.rb # spec/lib/gitlab/ci/config/entry/job_spec.rb # spec/lib/gitlab/ci/status/build/factory_spec.rb # spec/lib/gitlab/incoming_email_spec.rb
-
Douwe Maan authored
This reverts commit cb10b725c8929b8b4460f89c9d96c773af39ba6b.
-
Douwe Maan authored
-
Douwe Maan authored
-
- 02 Feb, 2017 1 commit
-
-
Horacio Sanson authored
Allow rendering of PlantUML diagrams in Markdown documents using fenced blocks: ```plantuml Bob -> Sara : Hello Sara -> Bob : Go away ``` Closes: #4048
-
- 17 Jan, 2017 1 commit
-
-
Douwe Maan authored
-
- 16 Jan, 2017 2 commits
-
-
Douwe Maan authored
-
Douwe Maan authored
-
- 14 Dec, 2016 1 commit
-
-
Munken authored
-
- 08 Dec, 2016 1 commit
-
-
Munken authored
-
- 16 Oct, 2016 1 commit
-
-
Ebrahim Byagowi authored
-
- 10 Oct, 2016 1 commit
-
-
Nick Thomas authored
-
- 07 Oct, 2016 1 commit
-
-
Nick Thomas authored
This commit alters views for the following models to use the markdown cache if present: * AbuseReport * Appearance * ApplicationSetting * BroadcastMessage * Group * Issue * Label * MergeRequest * Milestone * Project At the same time, calls to `escape_once` have been moved into the `single_line` Banzai pipeline, so they can't be missed out by accident and the work is done at save, rather than render, time.
-
- 19 Jul, 2016 2 commits
-
-
Rémy Coutable authored
Also, always add a link to download videos since video playback is tricky. Also, it solves the issue with email client not supporting videos. Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Eric Hayes authored
* Registered video MIME types * Currently supporting browser-supported formats with extensions that match the mime type
-
- 10 Jul, 2016 1 commit
-
-
Douwe Maan authored
-
- 01 Jul, 2016 1 commit
-
-
Grzegorz Bizon authored
-
- 24 Jun, 2016 1 commit
-
-
Yorick Peterse authored
This commit changes the way certain documents are rendered (currently only Notes) and how documents are redacted. Previously both rendering and redacting would run on a per document basis. The result of this was that for every document we'd have to run countless queries just to figure out if we could display a set of links or not. This commit changes things around so that redacting Markdown documents is no longer tied into the html-pipeline Gem. This in turn allows it to redact multiple documents in a single pass, thus reducing the number of queries needed. In turn rendering issue/merge request notes has been adjusted to take advantage of this new setup. Instead of rendering Markdown somewhere deep down in a view the Markdown is rendered and redacted in the controller (taking the current user and all that into account). This has been done in such a way that the "markdown()" helper method can still be used on its own. This particular commit also paves the way for caching rendered HTML on object level. Right now there's an accessor method Note#note_html which is used for setting/getting the rendered HTML. Once we cache HTML on row level we can simply change this field to be a column and call a "save" whenever needed and we're pretty much done.
-
- 16 Jun, 2016 2 commits
-
-
James Lopez authored
This reverts commit 13e37a3e.
-
James Lopez authored
-
- 13 Jun, 2016 1 commit
-
-
Sean McGivern authored
Consider this command: bundle exec rails r "include GitlabMarkdownHelper puts markdown('<span>this is a span</span>', pipeline: :description) puts markdown('<span>this is a span</span>')" And the same in the opposite order: bundle exec rails r "include GitlabMarkdownHelper puts markdown('<span>this is a span</span>') puts markdown('<span>this is a span</span>', pipeline: :description)" Before this change, they would both output: <p><span>this is a span</span></p> <p>this is a span</p> That's because `span` is added to the list of whitelisted elements in the `SanitizationFilter`, but this method tries not to make the same changes multiple times. Unfortunately, `HTML::Pipeline::SanitizationFilter::LIMITED`, which is used by the `DescriptionPipeline`, uses the same Ruby objects for all of its hash values _except_ `:elements`. That means that whichever of `DescriptionPipeline` and `GfmPipeline` is called first would have `span` in its whitelisted elements, and the second wouldn't. Fix this by creating an entirely separate hash, before either pipeline is invoked.
-
- 03 Jun, 2016 2 commits
-
-
James Lopez authored
This reverts commit 3e991230.
-
James Lopez authored
# Conflicts: # app/models/project.rb
-
- 26 May, 2016 1 commit
-
-
Yorick Peterse authored
This splits the Markdown rendering and reference extraction phases into two distinct code bases. The reference extraction phase no longer relies on the html-pipeline Gem (and any related code) and allows for extracting of references from multiple HTML nodes in a single pass. This means that if you want to extract user references from 200 comments you no longer need to run 200 times N number of queries, instead only a handful of queries may be needed.
-
- 18 May, 2016 1 commit
-
-
Adam Butler authored
-
- 06 Apr, 2016 2 commits
-
-
Gabriel Mazetto authored
-
Gabriel Mazetto authored
-
- 05 Apr, 2016 1 commit
-
-
connorshea authored
Resolves #14411. See merge request !3464
-
- 01 Apr, 2016 1 commit
-
-
Gabriel Mazetto authored
-
- 24 Mar, 2016 1 commit
-
-
Robert Speicher authored
We're trying to avoid circular dependency errors.
-
- 17 Mar, 2016 3 commits
-
-
Grzegorz Bizon authored
-
Grzegorz Bizon authored
-
Grzegorz Bizon authored
-
- 04 Mar, 2016 1 commit
-
-
Robert Speicher authored
This filter will detect YAML Front Matter and convert it to an HTML table for prettier formatting.
-
- 03 Mar, 2016 1 commit
-
-
Robert Speicher authored
-
- 01 Mar, 2016 1 commit
-
-
Robert Speicher authored
-
- 23 Feb, 2016 1 commit
-
-
Robert Speicher authored
Closes #2494
-