- 12 May, 2016 3 commits
-
-
Andrei Gliga authored
-
Andrei Gliga authored
-
Andrei Gliga authored
-
- 11 May, 2016 2 commits
-
-
Sean McGivern authored
-
Connor Shea authored
Also fixes the errors caused by enabling the cop. casecmp is more performant than `.downcase` and `==`.
-
- 10 May, 2016 5 commits
-
-
Sean McGivern authored
`User#starred_projects` doesn't perform any visibility checks. This has a couple of problems: 1. It assumes a user can always view all of their starred projects in perpetuity (project not changed to private, access revoked, etc.). 2. It assumes that we'll only ever allow a user to star a project they can view. This is currently the case, but bugs happen. Add `User#viewable_starred_projects` to filter the starred projects by those the user either has explicit access to, or are public or internal. Then use that in all places where we list the user's starred projects.
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Rémy Coutable authored
- Fix naming of API::CommitStatuses - Ensure we use require_dependency instead of require - Ensure the namespace is right in lib/api/api.rb, otherwise, we might require Grape::API::Helpers which defines the `#params` method. This is to avoid requiring a file multiple times and getting an "Already initialized constant" error. Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Jacob Vosmaer authored
Robert Speicher and I believe this string gets sanitized further down the stack anyway. Doing this in a model class feels wrong.
-
Rémy Coutable authored
This reverts commit 4cc85a58, reversing changes made to 90ae445b. Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 09 May, 2016 5 commits
-
-
Jeroen van Baarsen authored
In 8278b763 the default behaviour of annotation has changes, which was causing a lot of noise in diffs. We decided in #17382 that it is better to get rid of the whole annotate gem, and instead let people look at schema.rb for the columns in a table. Fixes: #17382
-
Felipe Artur authored
-
cnam-dep authored
-
Artem Sidorenko authored
-
Stan Hu authored
If you attempt to push thousands of branches at once, the 60-second timeout will occur because GitAccess checking does a lot of work to check if the user has permission to push to a branch. This changes does two things: 1. Instead of making 1 DB query per branch push, use a memoized list of protected branches to check 2. Memoize what permissions the user has to perform on this project On a test of 10,000 branch pushes, this prevents gitlab-shell from hitting the 60-second timeout. Closes #17225
-
- 08 May, 2016 1 commit
-
-
Robert Speicher authored
-
- 07 May, 2016 1 commit
-
-
Stan Hu authored
Run ProjectDestroyWorker after pending_delete attribute has been committed to DB
-
- 06 May, 2016 4 commits
-
-
Ahmad Sherif authored
Fixes #14002
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
Takuya Noguchi authored
-
Zeger-Jan van de Weg authored
-
- 05 May, 2016 1 commit
-
-
Felipe Artur authored
-
- 04 May, 2016 3 commits
-
-
Jakub Jirutka authored
Variable `Gitlab::Application.config.secret_key_base` is set in config/initializers/secret_token.rb. It's very bad practice to use hard-coded paths inside an application and really unnecessary in this case.
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Rémy Coutable authored
Use Rugged's TagCollection#create instead of gitlab-shell's Repository#add_tag for better performance Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 03 May, 2016 2 commits
-
-
Connor Shea authored
This reverts commit 1cc614f2. It was causing the ActiveJob integration to fail, so unfortunately we'll have to add the gem again.
-
Jacob Vosmaer authored
I wanted to share what I learned trying to debug web hooks using netcat.
-
- 02 May, 2016 1 commit
-
-
Stan Hu authored
Closes #2334
-
- 30 Apr, 2016 1 commit
-
-
Gabriel Mazetto authored
-
- 29 Apr, 2016 5 commits
-
-
Yorick Peterse authored
This changes 4 things: 1. Project#protected_branches_names has been renamed to Project#protected_branch_names. 2. Project#open_branches uses a Set for the branch names as checking values in a Set is faster than checking values in a (large) Array. 3. Some redundant code in Project#open_branches has been removed. 4. Project#protected_branch_names now uses #pluck instead of #map, removing the need for loading entire DB records into memory.
-
Yorick Peterse authored
This changes Project#protected_branch? to use a query to check if a branch is protected, instead of loading all ProtectedBranch records into memory just to check if the list of names includes a given branch name.
-
Matt Oakes authored
This is a combination of 3 commits. - Update the bare repositories info/attributes if the default branch is updated - Check the diff attributes of a file before showing a diff - Update CHANGELOG
-
Arinde Eniola authored
make some changes for the checks to determine when the messages should be displayed add item to changelog and also integration test make some changes to the test make some changes
-
Paco Guzman authored
- Parameter validation as ISO8601 format
-
- 28 Apr, 2016 1 commit
-
-
Zeger-Jan van de Weg authored
-
- 27 Apr, 2016 1 commit
-
-
Grzegorz Bizon authored
This status will be returned only when there are no failed jobs that are not allowed to fail.
-
- 26 Apr, 2016 2 commits
-
-
Connor Shea authored
"CHANGELOG", "NEWS", "HISTORY", and "CHANGES" are recognized as Changelog files. Also adds relevant tests for each of these names. Resolves #14864.
-
Connor Shea authored
The extra gem isn’t necessary anymore since Rails 4.2 has ActiveJob integration. Resolves #15575.
-
- 25 Apr, 2016 2 commits
-
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-