- 13 Feb, 2018 1 commit
-
-
Yorick Peterse authored
Using Sentry, while useful, poses two problems you have to choose from: 1. All errors are reported separately, making it easy to create issues but also making it next to impossible to see other errors (due to the sheer volume of threshold errors). 2. Errors can be grouped or merged together, reducing the noise. This however also means it's (as far as I can tell) much harder to automatically create GitLab issues from Sentry for the offending controllers. Since both solutions are terrible I decided to go with a third option: not using Sentry for this at all. Instead we'll investigate using Prometheus alerts and Grafana dashboards for this, which has the added benefit of being able to more accurately measure the behaviour over time. Note that throwing errors in test environments is still enabled, and whitelisting is still necessary to prevent that from happening (and that in turn still requires that developers create issues).
-
- 12 Feb, 2018 9 commits
-
-
Stan Hu authored
-
Michael Kozono authored
-
Michael Kozono authored
-
Michael Kozono authored
-
Rubén Dávila authored
This reverts commit a58f8c32, reversing changes made to cd5d75c3.
-
Alessio Caiazza authored
In the attempt to unify file uploading at workhorse level gitlab-org/gitlab-workhorse!230 we moved to a prefix-based tempfile creation in order to avoid upload collisions. Artifacts and LFS uploads already set original_filename to workhorse provided filename This commit add the same feature to `Gitlab::Middleware::Multipart`
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Stan Hu authored
This is to fix job failures, such as https://gitlab.com/gitlab-org/gitlab-ee/-/jobs/51409392.
-
Valery Sizov authored
-
- 09 Feb, 2018 2 commits
-
-
Ahmad Sherif authored
Fixes gitlab-development-kit#321
-
Douwe Maan authored
[10.4] Fix stored XSS in code blocks
-
- 07 Feb, 2018 9 commits
-
-
Ahmad Sherif authored
Closes gitaly#985
-
Francisco Javier López authored
-
Ahmad Sherif authored
-
Zeger-Jan van de Weg authored
The refs hash is used to determine what branches and tags have a commit as head in the network graph. The previous implementation depended on Rugged#references. The problem with this implementation was that it depended on rugged, but also that it iterated over all references and thus loading more data than needed if for example the project uses CI/CD environments, Pipelines, or Merge Requests. Given only refs are checked the network cares about the GraphHelper#refs method has no need to reject those, simplifying the method. Closes gitlab-org/gitaly#880
-
Rubén Dávila authored
-
Nick Thomas authored
-
Kamil Trzciński authored
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Pawel Chojnacki authored
-
- 06 Feb, 2018 14 commits
-
-
Dylan Griffith authored
- Move the exception handling as close to the source as possible to avoid leaking Psych ahstraction - Also remove unnecessary rescue all statement from LintsController. This should not be necessary anymore since any YAML errors should all be caught by the #validation_message method.
-
Tiago Botelho authored
-
Douwe Maan authored
-
Douwe Maan authored
-
Rémy Coutable authored
Reset Project's column information in spec/lib/gitlab/background_migration/populate_merge_request_metrics_with_events_data_spec.rb Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Tiago Botelho authored
-
James Edwards-Jones authored
Uses Lfs::FileModificationHandler to coordinate LFS detection, creation of LfsObject, etc Caveats: 1. This isn't used by the multi-file editor / Web IDE 2. This isn't used on rename. We'd need to be able to download LFS files and add them to the commit if they no longer match so not as simple. 3. We only check the root .gitattributes file, so this should be improved to correctly check for nested .gitattributes files in subfolders.
-
Jarka Kadlecová authored
-
Kamil Trzciński authored
-
Tiago Botelho authored
-
Tiago Botelho authored
-
Tiago Botelho authored
-
Tiago Botelho authored
-
Shinya Maeda authored
-
- 05 Feb, 2018 3 commits
-
-
Francisco Javier López authored
-
Francisco Javier López authored
-
Joshua Lambert authored
-
- 02 Feb, 2018 2 commits
-
-
Alejandro Rodríguez authored
-
Ahmad Sherif authored
Gitlab::Git::Repository#find_branch has a similar logic. Fixes #42609
-