BigW Consortium Gitlab

  1. 20 Apr, 2017 1 commit
  2. 03 Apr, 2017 1 commit
  3. 24 Feb, 2017 1 commit
  4. 23 Feb, 2017 2 commits
    • Enable Style/WordArray · 7d4b52b2
      Douwe Maan authored
    • Fix GitAccess specs · 485ac922
      Sean McGivern authored
      These specs never ran due to incorrect indentation: the `context` blocks
      were inside the `before`.
      
      Additionally, `GitHooksService` now has to yield itself to callers, and
      `GitAccess` never appears to have had an `allowed?` method.
  5. 05 Feb, 2017 1 commit
  6. 25 Jan, 2017 1 commit
  7. 20 Dec, 2016 1 commit
  8. 08 Dec, 2016 1 commit
  9. 18 Nov, 2016 1 commit
  10. 17 Nov, 2016 1 commit
  11. 16 Nov, 2016 1 commit
  12. 11 Nov, 2016 3 commits
  13. 09 Nov, 2016 1 commit
  14. 01 Nov, 2016 1 commit
  15. 18 Oct, 2016 1 commit
  16. 20 Sep, 2016 1 commit
  17. 16 Sep, 2016 1 commit
  18. 15 Sep, 2016 3 commits
  19. 17 Aug, 2016 1 commit
  20. 04 Aug, 2016 1 commit
  21. 29 Jul, 2016 4 commits
  22. 19 Jul, 2016 1 commit
  23. 18 Jul, 2016 1 commit
  24. 13 Jul, 2016 5 commits
    • Revert "Merge branch '18193-developers-can-merge' into 'master' · 530f5158
      Robert Speicher authored
      This reverts commit 9ca633eb, reversing
      changes made to fb229bbf.
    • Appease rubocop. · 4d00ed21
      Timothy Andrew authored
    • Refactor `Gitlab::GitAccess` · 60245bbe
      Timothy Andrew authored
      1. Don't use case statements for dispatch anymore. This leads to a lot
         of duplication, and makes the logic harder to follow.
      
      2. Remove duplicated logic.
      
          - For example, the `can_push_to_branch?` exists, but we also have a
            different way of checking the same condition within `change_access_check`.
      
          - This kind of duplication is removed, and the `can_push_to_branch?`
            method is used in both places.
      
      3. Move checks returning true/false to `UserAccess`.
      
          - All public methods in `GitAccess` now return an instance of
            `GitAccessStatus`. Previously, some methods would return
            true/false as well, which was confusing.
      
          - It makes sense for these kinds of checks to be at the level of a
            user, so the `UserAccess` class was repurposed for this. The prior
            `UserAccess.allowed?` classmethod is converted into an instance
            method.
      
          - All external uses of these checks have been migrated to use the
            `UserAccess` class
      
      4. Move the "change_access_check" into a separate class.
      
          - Create the `GitAccess::ChangeAccessCheck` class to run these
            checks, which are quite substantial.
      
          - `ChangeAccessCheck` returns an instance of `GitAccessStatus` as
            well.
      
      5. Break out the boolean logic in `ChangeAccessCheck` into `if/else`
         chains - this seems more readable.
      
      6. I can understand that this might look like overkill for !4892, but I
         think this is a good opportunity to clean it up.
      
          - http://martinfowler.com/bliki/OpportunisticRefactoring.html
    • Enforce "developers can merge" during `pre-receive`. · 495db096
      Timothy Andrew authored
      1. When a merge request is being merged, save the merge commit SHA in
         the `in_progress_merge_commit_sha` database column.
      
      2. The `pre-receive` hook looks for any locked (in progress) merge
         request with `in_progress_merge_commit_sha` matching the `newrev` it
         is passed.
      
      3. If it finds a matching MR, the merge is legitimate.
      
      4. Update `git_access_spec` to test the behaviour we added here. Also
         refactored this spec a bit to make it easier to add more contexts / conditions.
    • Added "developers can merge" setting to protected branches · f0577d83
      Mathias Vestergaard authored
      - Cherry-picked from `mvestergaard:branch-protection-dev-merge`
      - https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4220
  25. 05 Jul, 2016 4 commits