- 05 Oct, 2017 1 commit
-
-
Shinya Maeda authored
-
- 29 Sep, 2017 1 commit
-
-
Phil Hughes authored
-
- 28 Sep, 2017 1 commit
-
-
Markus Koller authored
-
- 22 Sep, 2017 1 commit
-
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 18 Sep, 2017 1 commit
-
-
Felipe Artur authored
-
- 14 Sep, 2017 2 commits
-
-
Jarka Kadlecova authored
-
Jarka Kadlecova authored
-
- 07 Sep, 2017 1 commit
-
-
Ruben Davila authored
-
- 06 Sep, 2017 4 commits
-
-
Michael Kozono authored
-
Michael Kozono authored
-
Michael Kozono authored
-
Michael Kozono authored
…in Groups::UpdateService instead of only in the browser.
-
- 22 Aug, 2017 1 commit
-
-
Tiago Botelho authored
-
- 21 Aug, 2017 1 commit
-
-
Tiago Botelho authored
-
- 02 Aug, 2017 1 commit
-
-
Robert Speicher authored
-
- 01 Aug, 2017 1 commit
-
-
Robert Speicher authored
-
- 27 Jul, 2017 3 commits
-
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Rémy Coutable authored
Remove superfluous lib: true, type: redis, service: true, models: true, services: true, no_db: true, api: true Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Keifer Furzland authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 25 Jul, 2017 1 commit
-
-
Lin Jen-Shin authored
-
- 24 Jul, 2017 2 commits
-
-
Sean McGivern authored
The `members` table can have entries where `user_id: nil`, because people can invite group members by email. We never want to include those as members, because it might cause confusion with the anonymous (logged out) user.
-
Jarka Kadlecova authored
-
- 18 Jul, 2017 3 commits
-
-
Lin Jen-Shin authored
-
Lin Jen-Shin authored
-
Lin Jen-Shin authored
-
- 17 Jul, 2017 1 commit
-
-
Lin Jen-Shin authored
-
- 04 Jul, 2017 1 commit
-
-
Lin Jen-Shin authored
-
- 03 Jul, 2017 2 commits
-
-
Lin Jen-Shin authored
updating builds and updating pipelines. We check against being able to merge or push if the ref is protected.
-
Timothy Andrew authored
- Fix duplicate `prevent` declaration - Add spec for `GlobalPolicy`
-
- 27 Jun, 2017 2 commits
-
-
http://jneen.net/ authored
-
http://jneen.net/ authored
-
- 21 Jun, 2017 1 commit
-
-
Grzegorz Bizon authored
-
- 14 Jun, 2017 1 commit
-
-
Robert Speicher authored
-
- 13 Jun, 2017 1 commit
-
-
Kamil Trzcinski authored
-
- 08 Jun, 2017 3 commits
-
-
DJ Mountney authored
Fix visibility when referencing snippets See merge request !2101
-
DJ Mountney authored
Ran: - git format-patch v9.2.2..v9.2.5 --stdout > patchfile.patch - git checkout -b 9-2-5-security-patch origin/v9.2.2 - git apply patchfile.patch - git commit - [Got the sha ref for the commit] - git checkout -b upstream-9-2-security master - git cherry-pick <SHA of the patchfile commit> - [Resolved conflicts] - git cherry-pick --continue
-
DJ Mountney authored
Ran: - git format-patch v9.2.2..v9.2.5 --stdout > patchfile.patch - git checkout -b 9-2-5-security-patch origin/v9.2.2 - git apply patchfile.patch - git commit - [Got the sha ref for the commit] - git checkout -b upstream-9-2-security master - git cherry-pick <SHA of the patchfile commit> - [Resolved conflicts] - git cherry-pick --continue
-
- 05 Jun, 2017 1 commit
-
-
Sean McGivern authored
Previously, only group masters could do this. However, project reporters can manage project labels, so there doesn't seem to be any need to restrict group labels further. Also, save a query or two by getting a single GroupMember object to find out if the user is a master or not.
-
- 02 Jun, 2017 1 commit
-
-
Alexander Randa authored
-
- 17 May, 2017 1 commit
-
-
Yorick Peterse authored
This commit introduces the usage of Common Table Expressions (CTEs) to efficiently retrieve nested group hierarchies, without having to rely on the "routes" table (which is an _incredibly_ inefficient way of getting the data). This requires a patch to ActiveRecord (found in the added initializer) to work properly as ActiveRecord doesn't support WITH statements properly out of the box. Unfortunately MySQL provides no efficient way of getting nested groups. For example, the old routes setup could easily take 5-10 seconds depending on the amount of "routes" in a database. Providing vastly different logic for both MySQL and PostgreSQL will negatively impact the development process. Because of this the various nested groups related methods return empty relations when used in combination with MySQL. For project authorizations the logic is split up into two classes: * Gitlab::ProjectAuthorizations::WithNestedGroups * Gitlab::ProjectAuthorizations::WithoutNestedGroups Both classes get the fresh project authorizations (= as they should be in the "project_authorizations" table), including nested groups if PostgreSQL is used. The logic of these two classes is quite different apart from their public interface. This complicates development a bit, but unfortunately there is no way around this. This commit also introduces Gitlab::GroupHierarchy. This class can be used to get the ancestors and descendants of a base relation, or both by using a UNION. This in turn is used by methods such as: * Namespace#ancestors * Namespace#descendants * User#all_expanded_groups Again this class relies on CTEs and thus only works on PostgreSQL. The Namespace methods will return an empty relation when MySQL is used, while User#all_expanded_groups will return only the groups a user is a direct member of. Performance wise the impact is quite large. For example, on GitLab.com Namespace#descendants used to take around 580 ms to retrieve data for a particular user. Using CTEs we are able to reduce this down to roughly 1 millisecond, returning the exact same data. == On The Fly Refreshing Refreshing of authorizations on the fly (= when users.authorized_projects_populated was not set) is removed with this commit. This simplifies the code, and ensures any queries used for authorizations are not mutated because they are executed in a Rails scope (e.g. Project.visible_to_user). This commit includes a migration to schedule refreshing authorizations for all users, ensuring all of them have their authorizations in place. Said migration schedules users in batches of 5000, with 5 minutes between every batch to smear the load around a bit. == Spec Changes This commit also introduces some changes to various specs. For example, some specs for ProjectTeam assumed that creating a personal project would _not_ lead to the owner having access, which is incorrect. Because we also no longer refresh authorizations on the fly for new users some code had to be added to the "empty_project" factory. This chunk of code ensures that the owner's permissions are refreshed after creating the project, something that is normally done in Projects::CreateService.
-