BigW Consortium Gitlab

  1. 11 Nov, 2016 1 commit
  2. 10 Nov, 2016 3 commits
  3. 07 Nov, 2016 3 commits
  4. 06 Nov, 2016 1 commit
  5. 04 Nov, 2016 3 commits
  6. 31 Oct, 2016 1 commit
    • Support for post deployment migrations · 83c82411
      Yorick Peterse authored
      These are regular Rails migrations that are executed by default. A user
      can opt-out of these migrations by setting an environment variable
      during the deployment process.
      
      Fixes gitlab-org/gitlab-ce#22133
  7. 26 Oct, 2016 3 commits
  8. 24 Oct, 2016 1 commit
    • Fix reply-by-email not working due to queue name mismatch · 59ed1d3c
      Stan Hu authored
      mail_room was configured to deliver mail to the `incoming_email`
      queue while `EmailReceiveWorker` was reading the `email_receiver`
      queue. Adds a migration that repeats the work of a previous
      migration to ensure all mails that wound up in the old
      queue get processed.
      
      Closes #23689
  9. 21 Oct, 2016 3 commits
    • Re-organize queues to use for Sidekiq · 97731760
      Yorick Peterse authored
      Dumping too many jobs in the same queue (e.g. the "default" queue) is a
      dangerous setup. Jobs that take a long time to process can effectively
      block any other work from being performed given there are enough of
      these jobs.
      
      Furthermore it becomes harder to monitor the jobs as a single queue
      could contain jobs for different workers. In such a setup the only
      reliable way of getting counts per job is to iterate over all jobs in a
      queue, which is a rather time consuming process.
      
      By using separate queues for various workers we have better control over
      throughput, we can add weight to queues, and we can monitor queues
      better. Some workers still use the same queue whenever their work is
      related. For example, the various CI pipeline workers use the same
      "pipeline" queue.
      
      This commit includes a Rails migration that moves Sidekiq jobs from the
      old queues to the new ones. This migration also takes care of doing the
      inverse if ever needed. This does require downtime as otherwise new jobs
      could be scheduled in the old queues after this migration completes.
      
      This commit also includes an RSpec test that blacklists the use of the
      "default" queue and ensures cron workers use the "cronjob" queue.
      
      Fixes gitlab-org/gitlab-ce#23370
    • Fix broken label uniqueness label migration · b332931a
      Stan Hu authored
      The previous implementation of the migration failed on staging because
      the migration was attempted to remove labels from projects that did not
      actually have duplicates. This occurred because the SQL query did not
      account for the project ID when selecting the labels.
      
      To replicate the problem:
      
      1. Disable the uniqueness validation in app/models/label.rb.
      2. Create a duplicate label "bug" in project A.
      3. Create the same label in project B with label "bug".
      
      The migration will attempt to remove the label in B even if there are no duplicates.
      
      Closes #23609
    • Fix project member access levels · 168197cd
      Valery Sizov authored
  10. 19 Oct, 2016 7 commits
  11. 17 Oct, 2016 4 commits
  12. 14 Oct, 2016 2 commits
  13. 12 Oct, 2016 1 commit
  14. 10 Oct, 2016 1 commit
    • Precalculate trending projects · 237c8f66
      Yorick Peterse authored
      This commit introduces a Sidekiq worker that precalculates the list of
      trending projects on a daily basis. The resulting set is stored in a
      database table that is then queried by Project.trending.
      
      This setup means that Unicorn workers no longer _may_ have to calculate
      the list of trending projects. Furthermore it supports filtering without
      any complex caching mechanisms.
      
      The data in the "trending_projects" table is inserted in the same order
      as the project ranking. This means that getting the projects in the
      correct order is simply a matter of:
      
          SELECT projects.*
          FROM projects
          INNER JOIN trending_projects ON trending_projects.project_id = projects.id
          ORDER BY trending_projects.id ASC;
      
      Such a query will only take a few milliseconds at most (as measured on
      GitLab.com), opposed to a few seconds for the query used for calculating
      the project ranks.
      
      The migration in this commit does not require downtime and takes care of
      populating an initial list of trending projects.
  15. 07 Oct, 2016 1 commit
    • Add markdown cache columns to the database, but don't use them yet · e94cd6fd
      Nick Thomas authored
      This commit adds a number of _html columns and, with the exception of Note,
      starts updating them whenever the content of their partner fields changes.
      
      Note has a collision with the note_html attr_accessor; that will be fixed later
      
      A background worker for clearing these cache columns is also introduced - use
      `rake cache:clear` to set it off. You can clear the database or Redis caches
      separately by running `rake cache:clear:db` or `rake cache:clear:redis`,
      respectively.
  16. 06 Oct, 2016 3 commits
  17. 04 Oct, 2016 1 commit
  18. 28 Sep, 2016 1 commit
    • Allow Member.add_user to handle access requesters · ec0061a9
      Rémy Coutable authored
      Changes include:
      
      - Ensure Member.add_user is not called directly when not necessary
      - New GroupMember.add_users_to_group to have the same abstraction level as for Project
      - Refactor Member.add_user to take a source instead of an array of members
      - Fix Rubocop offenses
      - Always use Project#add_user instead of project.team.add_user
      - Factorize users addition as members in Member.add_users_to_source
      - Make access_level a keyword argument in GroupMember.add_users_to_group and ProjectMember.add_users_to_projects
      - Destroy any requester before adding them as a member
      - Improve the way we handle access requesters in Member.add_user
        Instead of removing the requester and creating a new member,
        we now simply accepts their access request. This way, they will
        receive a "access request granted" email.
      - Fix error that was previously silently ignored
      - Stop raising when access level is invalid in Member, let Rails validation do their work
      Signed-off-by: 's avatarRémy Coutable <remy@rymai.me>