BigW Consortium Gitlab

  1. 03 Jun, 2016 2 commits
  2. 01 Jun, 2016 2 commits
    • Fix note validation spec failures · 30aa6420
      Stan Hu authored
    • Refactor Participable · 580d2501
      Yorick Peterse authored
      There are several changes to this module:
      
      1. The use of an explicit stack in Participable#participants
      2. Proc behaviour has been changed
      3. Batch permissions checking
      
      == Explicit Stack
      
      Participable#participants no longer uses recursion to process "self" and
      all child objects, instead it uses an Array and processes objects in
      breadth-first order. This allows us to for example create a single
      Gitlab::ReferenceExtractor instance and pass this to any Procs. Re-using
      a ReferenceExtractor removes the need for running potentially many SQL
      queries every time a Proc is called on a new object.
      
      == Proc Behaviour Changed
      
      Previously a Proc in Participable was expected to return an Array of
      User instances. This has been changed and instead it's now expected that
      a Proc modifies the Gitlab::ReferenceExtractor passed to it. The return
      value of the Proc is ignored.
      
      == Permissions Checking
      
      The method Participable#participants uses
      Ability.users_that_can_read_project to check if the returned users have
      access to the project of "self" _without_ running multiple SQL queries
      for every user.
  3. 26 May, 2016 1 commit
  4. 09 Dec, 2015 1 commit
  5. 01 Dec, 2015 1 commit
  6. 30 Nov, 2015 1 commit
  7. 22 Jun, 2015 2 commits
  8. 26 May, 2015 2 commits
  9. 25 Apr, 2015 6 commits