- 03 Jun, 2016 2 commits
-
-
James Lopez authored
This reverts commit 3e991230.
-
James Lopez authored
# Conflicts: # app/models/project.rb
-
- 01 Jun, 2016 2 commits
-
-
Stan Hu authored
-
Yorick Peterse authored
There are several changes to this module: 1. The use of an explicit stack in Participable#participants 2. Proc behaviour has been changed 3. Batch permissions checking == Explicit Stack Participable#participants no longer uses recursion to process "self" and all child objects, instead it uses an Array and processes objects in breadth-first order. This allows us to for example create a single Gitlab::ReferenceExtractor instance and pass this to any Procs. Re-using a ReferenceExtractor removes the need for running potentially many SQL queries every time a Proc is called on a new object. == Proc Behaviour Changed Previously a Proc in Participable was expected to return an Array of User instances. This has been changed and instead it's now expected that a Proc modifies the Gitlab::ReferenceExtractor passed to it. The return value of the Proc is ignored. == Permissions Checking The method Participable#participants uses Ability.users_that_can_read_project to check if the returned users have access to the project of "self" _without_ running multiple SQL queries for every user.
-
- 26 May, 2016 1 commit
-
-
Yorick Peterse authored
This method used to call strip! on input strings which will mess with the strings if they're re-used or frozen.
-
- 09 Dec, 2015 1 commit
-
-
Douwe Maan authored
-
- 01 Dec, 2015 1 commit
-
-
Douwe Maan authored
-
- 30 Nov, 2015 1 commit
-
-
Douwe Maan authored
-
- 22 Jun, 2015 2 commits
-
-
Robert Speicher authored
These fixes were performed automatically by Rubocop's `-a` flag.
-
Robert Speicher authored
-
- 26 May, 2015 2 commits
-
-
Robert Speicher authored
We only want them shortened by the filter, which calls to_s
-
Robert Speicher authored
Now there is a single source of information for which attribute a model uses to be referenced, and its special character.
-
- 25 Apr, 2015 6 commits
-
-
Robert Speicher authored
-
Robert Speicher authored
-
Robert Speicher authored
-
Robert Speicher authored
-
Robert Speicher authored
-
Robert Speicher authored
-