BigW Consortium Gitlab

  1. 06 Jun, 2016 1 commit
  2. 01 Jun, 2016 1 commit
    • Refactor Participable · 580d2501
      Yorick Peterse authored
      There are several changes to this module:
      
      1. The use of an explicit stack in Participable#participants
      2. Proc behaviour has been changed
      3. Batch permissions checking
      
      == Explicit Stack
      
      Participable#participants no longer uses recursion to process "self" and
      all child objects, instead it uses an Array and processes objects in
      breadth-first order. This allows us to for example create a single
      Gitlab::ReferenceExtractor instance and pass this to any Procs. Re-using
      a ReferenceExtractor removes the need for running potentially many SQL
      queries every time a Proc is called on a new object.
      
      == Proc Behaviour Changed
      
      Previously a Proc in Participable was expected to return an Array of
      User instances. This has been changed and instead it's now expected that
      a Proc modifies the Gitlab::ReferenceExtractor passed to it. The return
      value of the Proc is ignored.
      
      == Permissions Checking
      
      The method Participable#participants uses
      Ability.users_that_can_read_project to check if the returned users have
      access to the project of "self" _without_ running multiple SQL queries
      for every user.
  3. 09 May, 2016 1 commit
    • Remove the annotate gem and delete old annotations · f1479b56
      Jeroen van Baarsen authored
      In 8278b763 the default behaviour of annotation
      has changes, which was causing a lot of noise in diffs. We decided in #17382
      that it is better to get rid of the whole annotate gem, and instead let people
      look at schema.rb for the columns in a table.
      
      Fixes: #17382
  4. 06 May, 2016 1 commit
  5. 20 Apr, 2016 6 commits
  6. 19 Apr, 2016 2 commits
  7. 14 Apr, 2016 1 commit
  8. 12 Apr, 2016 2 commits
    • Refactor `Issue#related_branches` · 5d88de09
      Timothy Andrew authored
      - Previously, the controller held the logic to calculate
        related branches, which was:
      
        `<branches ending with `issue.iid`> - <branches with a merge request referenced in the current issue>`
      
      - This logic belongs in the `related_branches` method, not in the
        controller. This commit makes this change.
      
      - This means that `Issue#related_branches` now needs to take a `User`.
        When we find the branches that have a merge request referenced in the
        current issue, this is limited to merge requests that the current user
        has access to.
      
      - This is not directly related to #14566, but is a related refactoring.
    • Sanitize branch names for confidential issues. · 377b59da
      Timothy Andrew authored
      - When creating new branches for confidential issues,
        prefer a branch name like `issue-15` to
        `some-sensitive-issue-title-15`.
      - The behaviour for non-confidential issues stays the same.
  9. 01 Apr, 2016 1 commit
  10. 23 Mar, 2016 1 commit
  11. 20 Mar, 2016 1 commit
  12. 19 Mar, 2016 3 commits
  13. 18 Mar, 2016 1 commit
    • \#to_branch_name now uses the iid as postfix · 70ca3370
      Zeger-Jan van de Weg authored
      Given the branch name 'mep-mep' with an iid being 1,
      the current way, master's way, would yield a branch name of
      1-mep-mep. The problem for larger projects however would be that
      a developer might forget what iid the issue was.
      
      When this developer would try to tab complete it would:
      - Or result in 20+ branches possibly
      - Or start with the wrong digit, try again with digit++
        - Would see 20 branches, repeat
      
      Thus the obvious way of solving this is letting the dev tab complete
      on the issue title, which is easier to remember.
  14. 17 Mar, 2016 4 commits
  15. 15 Mar, 2016 4 commits
  16. 22 Jan, 2016 1 commit
  17. 13 Jan, 2016 1 commit
  18. 07 Jan, 2016 2 commits
  19. 21 Dec, 2015 1 commit
  20. 15 Dec, 2015 2 commits
  21. 11 Dec, 2015 1 commit
  22. 01 Dec, 2015 1 commit
  23. 30 Nov, 2015 1 commit