- 06 Jun, 2016 1 commit
-
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 01 Jun, 2016 1 commit
-
-
Yorick Peterse authored
There are several changes to this module: 1. The use of an explicit stack in Participable#participants 2. Proc behaviour has been changed 3. Batch permissions checking == Explicit Stack Participable#participants no longer uses recursion to process "self" and all child objects, instead it uses an Array and processes objects in breadth-first order. This allows us to for example create a single Gitlab::ReferenceExtractor instance and pass this to any Procs. Re-using a ReferenceExtractor removes the need for running potentially many SQL queries every time a Proc is called on a new object. == Proc Behaviour Changed Previously a Proc in Participable was expected to return an Array of User instances. This has been changed and instead it's now expected that a Proc modifies the Gitlab::ReferenceExtractor passed to it. The return value of the Proc is ignored. == Permissions Checking The method Participable#participants uses Ability.users_that_can_read_project to check if the returned users have access to the project of "self" _without_ running multiple SQL queries for every user.
-
- 09 May, 2016 1 commit
-
-
Jeroen van Baarsen authored
In 8278b763 the default behaviour of annotation has changes, which was causing a lot of noise in diffs. We decided in #17382 that it is better to get rid of the whole annotate gem, and instead let people look at schema.rb for the columns in a table. Fixes: #17382
-
- 06 May, 2016 1 commit
-
-
Zeger-Jan van de Weg authored
-
- 20 Apr, 2016 6 commits
-
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Mehmet Beydogan authored
-
Mehmet Beydogan authored
Fix typos on sorting dropdown related to due date Remove constant array and add Structs on Issue to keep due date data to fill options
-
Mehmet Beydogan authored
Add due_date text field to sidebar issue#show Add ability sorting issues by due date ASC and DESC Add ability to filtering issues by No Due Date, Any Due Date, Due to tomorrow, Due in this week options Add handling issue due_date field for MergeRequest Update CHANGELOG Fix ambigous match for issues#show sidebar Fix SCREAMING_SNAKE_CASE offenses for due date contants Add specs for due date sorting and filtering on issues
-
- 19 Apr, 2016 2 commits
-
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Timothy Andrew authored
-
- 14 Apr, 2016 1 commit
-
-
Zeger-Jan van de Weg authored
-
- 12 Apr, 2016 2 commits
-
-
Timothy Andrew authored
- Previously, the controller held the logic to calculate related branches, which was: `<branches ending with `issue.iid`> - <branches with a merge request referenced in the current issue>` - This logic belongs in the `related_branches` method, not in the controller. This commit makes this change. - This means that `Issue#related_branches` now needs to take a `User`. When we find the branches that have a merge request referenced in the current issue, this is limited to merge requests that the current user has access to. - This is not directly related to #14566, but is a related refactoring.
-
Timothy Andrew authored
- When creating new branches for confidential issues, prefer a branch name like `issue-15` to `some-sensitive-issue-title-15`. - The behaviour for non-confidential issues stays the same.
-
- 01 Apr, 2016 1 commit
-
-
Yorick Peterse authored
These methods are called quite often in loops so by memoizing their output we can reduce timings a bit.
-
- 23 Mar, 2016 1 commit
-
-
Grzegorz Bizon authored
-
- 20 Mar, 2016 1 commit
-
-
Douwe Maan authored
-
- 19 Mar, 2016 3 commits
-
-
Yorick Peterse authored
Requesting the branch names of a repository works even when it's empty, thus there's no need to explicitly check for an empty repository. Removing this check cuts down the amount of Git operations which in turn cuts down request timings a bit. The regular expression used to compare branches was also moved out of the loop so it's created only once.
-
Zeger-Jan van de Weg authored
-
Zeger-Jan van de Weg authored
-
- 18 Mar, 2016 1 commit
-
-
Zeger-Jan van de Weg authored
Given the branch name 'mep-mep' with an iid being 1, the current way, master's way, would yield a branch name of 1-mep-mep. The problem for larger projects however would be that a developer might forget what iid the issue was. When this developer would try to tab complete it would: - Or result in 20+ branches possibly - Or start with the wrong digit, try again with digit++ - Would see 20 branches, repeat Thus the obvious way of solving this is letting the dev tab complete on the issue title, which is easier to remember.
-
- 17 Mar, 2016 4 commits
-
-
Douglas Barbosa Alexandre authored
-
Zeger-Jan van de Weg authored
Spinach was right, I was a fool..
-
Grzegorz Bizon authored
-
Grzegorz Bizon authored
-
- 15 Mar, 2016 4 commits
-
-
Zeger-Jan van de Weg authored
The feature spec now also tests the absence of the new branch button
-
Zeger-Jan van de Weg authored
-
Zeger-Jan van de Weg authored
-
Zeger-Jan van de Weg authored
-
- 22 Jan, 2016 1 commit
-
-
Valery Sizov authored
-
- 13 Jan, 2016 1 commit
-
-
Rémy Coutable authored
-
- 07 Jan, 2016 2 commits
-
-
Yorick Peterse authored
These scopes don't care about the order. Removing the explicit "ORDER BY" can speed up the queries by a little bit.
-
Yorick Peterse authored
This replaces plucking of IDs with a sub-query, saving the overhead of loading the data in Ruby and then mapping the rows to an Array of IDs. This also scales much better when dealing with a large amount of IDs that would be involved.
-
- 21 Dec, 2015 1 commit
-
-
Douwe Maan authored
-
- 15 Dec, 2015 2 commits
-
-
Douwe Maan authored
-
Douwe Maan authored
-
- 11 Dec, 2015 1 commit
-
-
Greg Smethells authored
-
- 01 Dec, 2015 1 commit
-
-
Douwe Maan authored
-
- 30 Nov, 2015 1 commit
-
-
Douwe Maan authored
-