- 18 Aug, 2017 1 commit
-
-
Douwe Maan authored
-
- 17 Aug, 2017 4 commits
-
-
Douwe Maan authored
-
Douwe Maan authored
-
Nick Thomas authored
-
Nick Thomas authored
-
- 16 Aug, 2017 2 commits
-
-
http://jneen.net/ authored
-
Douwe Maan authored
-
- 15 Aug, 2017 2 commits
-
-
Robert Speicher authored
-
vanadium23 authored
-
- 14 Aug, 2017 4 commits
-
-
Robert Speicher authored
An upcoming update to rubocop-gitlab-security added additional violations.
-
Yorick Peterse authored
The number of forks of a project doesn't change very frequently and running a COUNT(*) every time this information is requested can be quite expensive. We also end up running such a COUNT(*) query at least twice on the homepage of a project. By caching this data and refreshing it when necessary we can reduce project homepage loading times by around 60 milliseconds (based on the timings of https://gitlab.com/gitlab-org/gitlab-ce).
-
Lin Jen-Shin authored
So that we could limit the access to Repository#fetch_ref See: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13416#note_37487433
-
Nick Thomas authored
-
- 11 Aug, 2017 10 commits
-
-
http://jneen.net/ authored
-
http://jneen.net/ authored
since we're just adding them as a member, the permission may still return false.
-
http://jneen.net/ authored
-
http://jneen.net/ authored
since this is for user invites and the like.
-
http://jneen.net/ authored
-
http://jneen.net/ authored
-
Robert Speicher authored
This attribute is since validated against `DynamicPathValidator`, which has strict requirements for the characters allowed, and should no longer need to be sanitized in a callback before saving. This has additional benefits in our test suite, where every creation of a `User` record was calling `Sanitize.clean` on a username value that was always clean, since we're the ones generating it.
-
Robin Bobbitt authored
-
Yorick Peterse authored
Caching of BroadcastMessage instances has been changed so a cache stays valid as long as the default cache expiration time permits, instead of the cache being expired after 1 minute. When modifying broadcast messages the cache is flushed automatically. To remove the need for performing sequence scans on the "broadcast_messages" table we also add an index on (starts_at, ends_at, id), permitting PostgreSQL to use an index scan to get all necessary data. Finally this commit adds a few NOT NULL constraints to the table to match the Rails validations. Fixes gitlab-org/gitlab-ce#31706
-
Lin Jen-Shin authored
-
- 10 Aug, 2017 6 commits
-
-
Lin Jen-Shin authored
Also fix a few tests
-
Yorick Peterse authored
This changes various controllers to use the new EventCollection class for retrieving events. This class uses a JOIN LATERAL query on PostgreSQL to retrieve queries in a more efficient way, while falling back to a simpler / less efficient query for MySQL. The EventCollection class also includes a limit on the number of events to display to prevent malicious users from cycling through all events, as doing so could put a lot of pressure on the database. JOIN LATERAL is only supported on PostgreSQL starting with version 9.3.0 and as such this optimisation is only used when using PostgreSQL 9.3 or newer.
-
Yorick Peterse authored
This commit migrates events data in such a way that push events are stored much more efficiently. This is done by creating a shadow table called "events_for_migration", and a table called "push_event_payloads" which is used for storing push data of push events. The background migration in this commit will copy events from the "events" table into the "events_for_migration" table, push events in will also have a row created in "push_event_payloads". This approach allows us to reclaim space in the next release by simply swapping the "events" and "events_for_migration" tables, then dropping the old events (now "events_for_migration") table. The new table structure is also optimised for storage space, and does not include the unused "title" column nor the "data" column (since this data is moved to "push_event_payloads"). == Newly Created Events Newly created events are inserted into both "events" and "events_for_migration", both using the exact same primary key value. The table "push_event_payloads" in turn has a foreign key to the _shadow_ table. This removes the need for recreating and validating the foreign key after swapping the tables. Since the shadow table also has a foreign key to "projects.id" we also don't have to worry about orphaned rows. This approach however does require some additional storage as we're duplicating a portion of the events data for at least 1 release. The exact amount is hard to estimate, but for GitLab.com this is expected to be between 10 and 20 GB at most. The background migration in this commit deliberately does _not_ update the "events" table as doing so would put a lot of pressure on PostgreSQL's auto vacuuming system. == Supporting Both Old And New Events Application code has also been adjusted to support push events using both the old and new data formats. This is done by creating a PushEvent class which extends the regular Event class. Using Rails' Single Table Inheritance system we can ensure the right class is used for the right data, which in this case is based on the value of `events.action`. To support displaying old and new data at the same time the PushEvent class re-defines a few methods of the Event class, falling back to their original implementations for push events in the old format. Once all existing events have been migrated the various push event related methods can be removed from the Event model, and the calls to `super` can be removed from the methods in the PushEvent model. The UI and event atom feed have also been slightly changed to better handle this new setup, fortunately only a few changes were necessary to make this work. == API Changes The API only displays push data of events in the new format. Supporting both formats in the API is a bit more difficult compared to the UI. Since the old push data was not really well documented (apart from one example that used an incorrect "action" nmae) I decided that supporting both was not worth the effort, especially since events will be migrated in a few days _and_ new events are created in the correct format.
-
Lin Jen-Shin authored
so that we don't have to fetch it for non-forks
-
Yorick Peterse authored
This caches the result of Appearance.first in a similar fashion to how ApplicationSetting instances are cached. We also add some NOT NULL constraints to the table and correct the timestamp types. Fixes gitlab-org/gitlab-ce#36066, fixes gitlab-org/gitlab-ce#31698
-
Lin Jen-Shin authored
Feedback: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13416#note_37193731 So we just try a cheaper way to detect it if it works or not
-
- 09 Aug, 2017 5 commits
-
-
Michael Kozono authored
-
Lin Jen-Shin authored
-
Lin Jen-Shin authored
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
blackst0ne authored
-
- 08 Aug, 2017 6 commits
-
-
Michael Kozono authored
-
Michael Kozono authored
-
Brian Neel authored
-
Alejandro Rodríguez authored
-
Alejandro Rodríguez authored
This helps keep the abstraction layers simpler, and also keep the interface of those methods consistent, in case of implementation changes.
-
Alejandro Rodríguez authored
-