- 05 Jul, 2016 7 commits
-
-
Patricio Cano authored
-
Patricio Cano authored
-
Patricio Cano authored
-
Patricio Cano authored
-
Patricio Cano authored
-
Patricio Cano authored
Rename ENV['PROTOCOL'] to ENV['GL_PROTOCOL'] to conform to what GitLab Shell expects and make the `protocol` param in `GitAccess` mandatory.
-
Patricio Cano authored
-
- 09 May, 2016 1 commit
-
-
Stan Hu authored
If you attempt to push thousands of branches at once, the 60-second timeout will occur because GitAccess checking does a lot of work to check if the user has permission to push to a branch. This changes does two things: 1. Instead of making 1 DB query per branch push, use a memoized list of protected branches to check 2. Memoize what permissions the user has to perform on this project On a test of 10,000 branch pushes, this prevents gitlab-shell from hitting the 60-second timeout. Closes #17225
-
- 05 May, 2016 2 commits
-
-
Yorick Peterse authored
Previously this method would directly receive the output of tag_name(). This method could either return a String or nil. In the previous setup this would somehow magically work but because Rugged::TagCollection#[] doesn't accept nil values it started to fail. To work around this the elsif in change_access_check() assigns the result of tag_name() to a local and then _only_ calls protected_tag?() if the tag name is not nil. The extra parenthesis are put in place to ensure that things are parsed correctly, without these the code would be parsed as follows: elsif tag_ref = (tag_name(ref) && protected_tag(tag_ref)) During runtime this would basically resolve to: elsif tag_ref = (tag_name(ref) && protected_tag(nil)) This is because when you refer to the variable you're assigning _in_ the assignment Ruby returns nil instead of raising an error.
-
Yorick Peterse authored
This removes the need for retrieving the entire list of tags just to check if a specific one exists.
-
- 16 Nov, 2015 1 commit
-
-
Marin Jankovski authored
-
- 13 May, 2015 2 commits
-
-
Douwe Maan authored
-
Douwe Maan authored
-
- 25 Mar, 2015 1 commit
-
-
Dmitriy Zaporozhets authored
-
- 24 Mar, 2015 1 commit
-
-
Douwe Maan authored
-
- 10 Mar, 2015 1 commit
-
-
Douwe Maan authored
-
- 18 Feb, 2015 1 commit
-
-
Douwe Maan authored
-
- 03 Feb, 2015 2 commits
-
-
Dmitriy Zaporozhets authored
-
Dmitriy Zaporozhets authored
-
- 29 Jan, 2015 1 commit
-
-
Dmitriy Zaporozhets authored
-
- 21 Jan, 2015 1 commit
-
-
Valery Sizov authored
-
- 26 Dec, 2014 3 commits
-
-
Marin Jankovski authored
-
Marin Jankovski authored
-
Marin Jankovski authored
-
- 05 Dec, 2014 1 commit
-
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 02 Dec, 2014 1 commit
-
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 01 Dec, 2014 1 commit
-
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 18 Nov, 2014 1 commit
-
-
Valery Sizov authored
Conflicts: lib/gitlab/git_access.rb spec/lib/gitlab/git_access_spec.rb
-
- 03 Nov, 2014 1 commit
-
-
Ciro Santilli authored
commit starts with 7 zeros.
-
- 07 Oct, 2014 1 commit
-
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 23 Sep, 2014 1 commit
-
-
Jacob Vosmaer authored
-
- 01 Sep, 2014 1 commit
-
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 30 May, 2014 1 commit
-
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 22 May, 2014 1 commit
-
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 15 May, 2014 1 commit
-
-
Jacob Vosmaer authored
-
- 14 May, 2014 1 commit
-
-
Jacob Vosmaer authored
-
- 03 Apr, 2014 1 commit
-
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 25 Mar, 2014 1 commit
-
-
Steven Thonus authored
-
- 21 Mar, 2014 1 commit
-
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 20 Mar, 2014 1 commit
-
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-