- 19 Jul, 2016 2 commits
-
-
Annabel Dunstone authored
-
Annabel Dunstone authored
-
- 18 Jul, 2016 3 commits
-
-
Paco Guzman authored
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Rémy Coutable authored
This reverts commit 530f5158. See !4892. Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 15 Jul, 2016 2 commits
-
-
Douwe Maan authored
This reverts merge request !4970
-
http://jneen.net/ authored
-
- 14 Jul, 2016 4 commits
-
-
http://jneen.net/ authored
the <pre><code> wrapping is *always* used by the helper, and *never* by anywhere else, so pull the wrapping into the helper
-
http://jneen.net/ authored
-
Sean McGivern authored
permissions/permissions just links to user/permissions since https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5210
-
Timothy Andrew authored
1. Only on supported Chrome versions 2. Mainly, this lets us simplify the javascript-based U2F check to `window.u2f`, where `window.u2f` can either be loaded from the GitLab server (for Chrome) or from the Firefox extension. 3. This is a better way to provide browser detection for U2F.
-
- 13 Jul, 2016 3 commits
-
-
Robert Speicher authored
This reverts commit 9ca633eb, reversing changes made to fb229bbf.
-
Phil Hughes authored
-
Timothy Andrew authored
1. Don't use case statements for dispatch anymore. This leads to a lot of duplication, and makes the logic harder to follow. 2. Remove duplicated logic. - For example, the `can_push_to_branch?` exists, but we also have a different way of checking the same condition within `change_access_check`. - This kind of duplication is removed, and the `can_push_to_branch?` method is used in both places. 3. Move checks returning true/false to `UserAccess`. - All public methods in `GitAccess` now return an instance of `GitAccessStatus`. Previously, some methods would return true/false as well, which was confusing. - It makes sense for these kinds of checks to be at the level of a user, so the `UserAccess` class was repurposed for this. The prior `UserAccess.allowed?` classmethod is converted into an instance method. - All external uses of these checks have been migrated to use the `UserAccess` class 4. Move the "change_access_check" into a separate class. - Create the `GitAccess::ChangeAccessCheck` class to run these checks, which are quite substantial. - `ChangeAccessCheck` returns an instance of `GitAccessStatus` as well. 5. Break out the boolean logic in `ChangeAccessCheck` into `if/else` chains - this seems more readable. 6. I can understand that this might look like overkill for !4892, but I think this is a good opportunity to clean it up. - http://martinfowler.com/bliki/OpportunisticRefactoring.html
-
- 12 Jul, 2016 6 commits
-
-
Annabel Dunstone authored
-
Annabel Dunstone authored
-
Sean McGivern authored
-
Paco Guzman authored
-
Phil Hughes authored
Closes #12797
-
Phil Hughes authored
Closes #13771
-
- 11 Jul, 2016 4 commits
-
-
Connor Shea authored
-
winniehell authored
-
Sean McGivern authored
-
Phil Hughes authored
-
- 08 Jul, 2016 7 commits
-
-
Sean McGivern authored
-
Sean McGivern authored
1. Move render method to a concern, not a helper. 2. Let DiffHelper#diff_options automatically add the path option. 3. Move more instance var definitions to before filters.
-
Sean McGivern authored
-
Sean McGivern authored
Other diffs (those that are too large to render anyway, image diffs, diffs suppressed by .gitattributes) should be rendered immediately.
-
Sean McGivern authored
With the option to expand and collapse individual diffs, these aren't needed any more.
-
Sean McGivern authored
When rendering a list of diff files, skip those where the diff is over 10 KB and provide an endpoint to render individually instead.
-
Robert Speicher authored
This reverts commit bf2a86b7.
-
- 07 Jul, 2016 7 commits
-
-
Douwe Maan authored
-
Robert Speicher authored
This reverts commit 68155ee7, reversing changes made to 7ebd011e.
-
Douwe Maan authored
-
Annabel Dunstone authored
-
Alfredo Sumaran authored
-
Paco Guzman authored
We just need to get merge requests closes issues when we’re going to show them
-
Phil Hughes authored
-
- 06 Jul, 2016 2 commits
-
-
Douwe Maan authored
-
Douwe Maan authored
-