BigW Consortium Gitlab

  1. 02 Aug, 2017 1 commit
  2. 27 Jul, 2017 2 commits
  3. 11 Jul, 2017 1 commit
  4. 07 Jul, 2017 1 commit
  5. 06 Jul, 2017 1 commit
  6. 05 Jul, 2017 1 commit
  7. 29 Jun, 2017 1 commit
  8. 19 Jun, 2017 1 commit
  9. 22 May, 2017 1 commit
  10. 17 May, 2017 1 commit
    • Use CTEs for nested groups and authorizations · ac382b56
      Yorick Peterse authored
      This commit introduces the usage of Common Table Expressions (CTEs) to
      efficiently retrieve nested group hierarchies, without having to rely on
      the "routes" table (which is an _incredibly_ inefficient way of getting
      the data). This requires a patch to ActiveRecord (found in the added
      initializer) to work properly as ActiveRecord doesn't support WITH
      statements properly out of the box.
      
      Unfortunately MySQL provides no efficient way of getting nested groups.
      For example, the old routes setup could easily take 5-10 seconds
      depending on the amount of "routes" in a database. Providing vastly
      different logic for both MySQL and PostgreSQL will negatively impact the
      development process. Because of this the various nested groups related
      methods return empty relations when used in combination with MySQL.
      
      For project authorizations the logic is split up into two classes:
      
      * Gitlab::ProjectAuthorizations::WithNestedGroups
      * Gitlab::ProjectAuthorizations::WithoutNestedGroups
      
      Both classes get the fresh project authorizations (= as they should be
      in the "project_authorizations" table), including nested groups if
      PostgreSQL is used. The logic of these two classes is quite different
      apart from their public interface. This complicates development a bit,
      but unfortunately there is no way around this.
      
      This commit also introduces Gitlab::GroupHierarchy. This class can be
      used to get the ancestors and descendants of a base relation, or both by
      using a UNION. This in turn is used by methods such as:
      
      * Namespace#ancestors
      * Namespace#descendants
      * User#all_expanded_groups
      
      Again this class relies on CTEs and thus only works on PostgreSQL. The
      Namespace methods will return an empty relation when MySQL is used,
      while User#all_expanded_groups will return only the groups a user is a
      direct member of.
      
      Performance wise the impact is quite large. For example, on GitLab.com
      Namespace#descendants used to take around 580 ms to retrieve data for a
      particular user. Using CTEs we are able to reduce this down to roughly 1
      millisecond, returning the exact same data.
      
      == On The Fly Refreshing
      
      Refreshing of authorizations on the fly (= when
      users.authorized_projects_populated was not set) is removed with this
      commit. This simplifies the code, and ensures any queries used for
      authorizations are not mutated because they are executed in a Rails
      scope (e.g. Project.visible_to_user).
      
      This commit includes a migration to schedule refreshing authorizations
      for all users, ensuring all of them have their authorizations in place.
      Said migration schedules users in batches of 5000, with 5 minutes
      between every batch to smear the load around a bit.
      
      == Spec Changes
      
      This commit also introduces some changes to various specs. For example,
      some specs for ProjectTeam assumed that creating a personal project
      would _not_ lead to the owner having access, which is incorrect. Because
      we also no longer refresh authorizations on the fly for new users some
      code had to be added to the "empty_project" factory. This chunk of code
      ensures that the owner's permissions are refreshed after creating the
      project, something that is normally done in Projects::CreateService.
  11. 09 May, 2017 1 commit
    • Add :redis keyword to some specs clear state of trackable attributes · ab7c9033
      Toon Claes authored
      The specs that rely on a correct value of the trackable attributes, should
      include the `:redis` keyword in the spec to ensure the state is reset between
      various specs.
      
      The trackable attributes being:
      
      - sign_in_count      : Increased every time a sign in is made (by form, openid, oauth)
      - current_sign_in_at : A timestamp updated when the user signs in
      - last_sign_in_at    : Holds the timestamp of the previous sign in
      - current_sign_in_ip : The remote ip updated when the user sign in
      - last_sign_in_ip    : Holds the remote ip of the previous sign in
      
      The limiting of writing trackable attributes was introduced in
      gitlab-org/gitlab-ce!11053.
  12. 21 Apr, 2017 2 commits
  13. 17 Apr, 2017 1 commit
  14. 23 Mar, 2017 1 commit
  15. 08 Mar, 2017 1 commit
  16. 23 Feb, 2017 1 commit
  17. 06 Feb, 2017 2 commits
  18. 05 Jan, 2017 1 commit
  19. 03 Jan, 2017 4 commits
  20. 20 Dec, 2016 1 commit
  21. 16 Dec, 2016 4 commits
  22. 09 Dec, 2016 1 commit
  23. 07 Dec, 2016 1 commit
  24. 02 Dec, 2016 1 commit
  25. 26 Nov, 2016 1 commit
  26. 11 Nov, 2016 1 commit
  27. 28 Sep, 2016 1 commit
    • Allow Member.add_user to handle access requesters · ec0061a9
      Rémy Coutable authored
      Changes include:
      
      - Ensure Member.add_user is not called directly when not necessary
      - New GroupMember.add_users_to_group to have the same abstraction level as for Project
      - Refactor Member.add_user to take a source instead of an array of members
      - Fix Rubocop offenses
      - Always use Project#add_user instead of project.team.add_user
      - Factorize users addition as members in Member.add_users_to_source
      - Make access_level a keyword argument in GroupMember.add_users_to_group and ProjectMember.add_users_to_projects
      - Destroy any requester before adding them as a member
      - Improve the way we handle access requesters in Member.add_user
        Instead of removing the requester and creating a new member,
        we now simply accepts their access request. This way, they will
        receive a "access request granted" email.
      - Fix error that was previously silently ignored
      - Stop raising when access level is invalid in Member, let Rails validation do their work
      Signed-off-by: 's avatarRémy Coutable <remy@rymai.me>
  28. 13 Sep, 2016 4 commits