- 15 Aug, 2017 2 commits
-
-
Robert Speicher authored
-
Felipe Artur authored
-
- 14 Aug, 2017 3 commits
-
-
Yorick Peterse authored
The number of forks of a project doesn't change very frequently and running a COUNT(*) every time this information is requested can be quite expensive. We also end up running such a COUNT(*) query at least twice on the homepage of a project. By caching this data and refreshing it when necessary we can reduce project homepage loading times by around 60 milliseconds (based on the timings of https://gitlab.com/gitlab-org/gitlab-ce).
-
Lin Jen-Shin authored
So that we could limit the access to Repository#fetch_ref See: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13416#note_37487433
-
Lin Jen-Shin authored
-
- 11 Aug, 2017 4 commits
-
-
Robin Bobbitt authored
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Lin Jen-Shin authored
-
- 10 Aug, 2017 5 commits
-
-
Robert Speicher authored
-
Yorick Peterse authored
This commit migrates events data in such a way that push events are stored much more efficiently. This is done by creating a shadow table called "events_for_migration", and a table called "push_event_payloads" which is used for storing push data of push events. The background migration in this commit will copy events from the "events" table into the "events_for_migration" table, push events in will also have a row created in "push_event_payloads". This approach allows us to reclaim space in the next release by simply swapping the "events" and "events_for_migration" tables, then dropping the old events (now "events_for_migration") table. The new table structure is also optimised for storage space, and does not include the unused "title" column nor the "data" column (since this data is moved to "push_event_payloads"). == Newly Created Events Newly created events are inserted into both "events" and "events_for_migration", both using the exact same primary key value. The table "push_event_payloads" in turn has a foreign key to the _shadow_ table. This removes the need for recreating and validating the foreign key after swapping the tables. Since the shadow table also has a foreign key to "projects.id" we also don't have to worry about orphaned rows. This approach however does require some additional storage as we're duplicating a portion of the events data for at least 1 release. The exact amount is hard to estimate, but for GitLab.com this is expected to be between 10 and 20 GB at most. The background migration in this commit deliberately does _not_ update the "events" table as doing so would put a lot of pressure on PostgreSQL's auto vacuuming system. == Supporting Both Old And New Events Application code has also been adjusted to support push events using both the old and new data formats. This is done by creating a PushEvent class which extends the regular Event class. Using Rails' Single Table Inheritance system we can ensure the right class is used for the right data, which in this case is based on the value of `events.action`. To support displaying old and new data at the same time the PushEvent class re-defines a few methods of the Event class, falling back to their original implementations for push events in the old format. Once all existing events have been migrated the various push event related methods can be removed from the Event model, and the calls to `super` can be removed from the methods in the PushEvent model. The UI and event atom feed have also been slightly changed to better handle this new setup, fortunately only a few changes were necessary to make this work. == API Changes The API only displays push data of events in the new format. Supporting both formats in the API is a bit more difficult compared to the UI. Since the old push data was not really well documented (apart from one example that used an incorrect "action" nmae) I decided that supporting both was not worth the effort, especially since events will be migrated in a few days _and_ new events are created in the correct format.
-
Lin Jen-Shin authored
so that we don't have to fetch it for non-forks
-
Jacopo authored
Added test to API commits in order to handle cases for authenticated/unauthenticated user in a private and public project.
-
Rémy Coutable authored
Also improves the `create_templates` transient attribute and use `project.project_feature.update_columns` instead of `project.project_feature.update_attributes!` since it's faster. Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 09 Aug, 2017 2 commits
-
-
Lin Jen-Shin authored
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 08 Aug, 2017 4 commits
-
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
sue445 authored
-
Rémy Coutable authored
Fix the /projects/:id/repository/commits endpoint to handle dots in the ref name when the project full path contains a `/` Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Rémy Coutable authored
Fix the /projects/:id/repository/tags endpoint to handle dots in the tag name when the project full path contains a `/` Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 04 Aug, 2017 1 commit
-
-
Bob Van Landuyt authored
-
- 03 Aug, 2017 3 commits
-
-
Toon Claes authored
To investigate gitlab-org/gitlab-ce#31599
-
Lin Jen-Shin authored
`:mailer` is needed to pick it easily, while `type: :mailer` is needed for picking it automatically for tests located in spec/mailers/*_spec.rb It's a bit complicated in spec/services/notification_service_spec.rb but we'll leave it alone for now.
-
Tony authored
-
- 02 Aug, 2017 2 commits
-
-
Robert Speicher authored
-
Eric authored
-
- 01 Aug, 2017 4 commits
-
-
Robert Speicher authored
-
Lin Jen-Shin (godfat) authored
-
Gabriel Mazetto authored
-
Gabriel Mazetto authored
-
- 31 Jul, 2017 1 commit
-
-
Sean McGivern authored
This was migrated to separate columns in 9.4, and now just needs to be removed for real.
-
- 28 Jul, 2017 5 commits
-
-
Richard Clamp authored
-
Yorick Peterse authored
Having two states that essentially mean the same thing is very much like having a boolean "true" and boolean "mostly-true": it's rather silly. This commit merges the "reopened" state into the "opened" state while taking care of system notes still showing messages along the lines of "Alice reopened this issue". A big benefit from having only two states (opened and closed) is that indexing and querying becomes simpler and more performant. For example, to get all the opened queries we no longer have to query both states: SELECT * FROM issues WHERE project_id = 2 AND state IN ('opened', 'reopened'); Instead we can query a single state directly, which can be much faster: SELECT * FROM issues WHERE project_id = 2 AND state = 'opened'; Further, only having two states makes indexing easier as we will only ever filter (and thus scan an index) using a single value. Partial indexes could help but aren't supported on MySQL, complicating the development process and not being helpful for MySQL.
-
Shinya Maeda authored
-
Shinya Maeda authored
-
Shinya Maeda authored
-
- 27 Jul, 2017 4 commits
-
-
Toon Claes authored
This matches the behavior of the /issues endpoint.
-
Toon Claes authored
And add support for additional query parameters: - `author_id`: Returns merge requests created by the given user `id` - `assignee_id`: Returns merge requests assigned to the given user `id` - `scope`: Return merge requests for the given scope: `created-by-me`, `assigned-to-me` or `all`
-
Rémy Coutable authored
Remove superfluous lib: true, type: redis, service: true, models: true, services: true, no_db: true, api: true Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Rémy Coutable authored
Fix the /projects/:id/repository/branches endpoint to handle dots in the branch name when the project full patch contains a `/` Signed-off-by: Rémy Coutable <remy@rymai.me>
-