BigW Consortium Gitlab

  1. 28 Apr, 2017 3 commits
  2. 05 Apr, 2017 1 commit
  3. 07 Mar, 2017 1 commit
  4. 01 Mar, 2017 1 commit
    • Add RuboCop cop for custom error classes · 8dd097a9
      Sean McGivern authored
      From the Ruby style guide:
      
          # bad
          class FooError < StandardError
          end
      
          # okish
          class FooError < StandardError; end
      
          # good
          FooError = Class.new(StandardError)
      
      This cop does that, but only for error classes (classes where the
      superclass ends in 'Error'). We have empty controllers and models, which
      are perfectly valid empty classes.
  5. 23 Feb, 2017 5 commits
  6. 10 Feb, 2017 1 commit
    • Enforce use of add_concurrent_foreign_key · 766060bc
      Yorick Peterse authored
      This adds a Rubocop rule to enforce the use of
      add_concurrent_foreign_key instead of the regular add_foreign_key
      method. This cop has been disabled for existing migrations so we don't
      need to change those.
  7. 09 Feb, 2017 1 commit
  8. 08 Feb, 2017 2 commits
  9. 31 Jan, 2017 1 commit
  10. 29 Jun, 2016 1 commit
    • Added RuboCop cops for checking DB migrations · c740445a
      Yorick Peterse authored
      There are currently two cops for this:
      
      * Migration/AddIndex: checks if indexes are added concurrently
      * Migration/ColumnWithDefault: checks if columns with default values are
        added in a concurrent manner
      
      Both cops are fairly simple and make no attempt at correcting the code
      as this is quite hard to do (e.g. modifications may need to be applied
      in various places in the same file). They however should provide enough
      to catch people ignoring the comments in generated migrations telling
      them to use add_concurrent_index or add_column_with_default.