- 28 Nov, 2017 1 commit
-
-
Sean McGivern authored
The st_commits and st_diffs columns on merge_request_diffs historically held the YAML-serialised data for a merge request diff, in a variety of formats. Since 9.5, these have been migrated in the background to two new tables: merge_request_diff_commits and merge_request_diff_files. That has the advantage that we can actually query the data (for instance, to find out how many commits we've stored), and that it can't be in a variety of formats, but must match the new schema. This is the final step of that journey, where we drop those columns and remove all references to them. This is a breaking change to the importer, because we can no longer import diffs created in the old format, and we cannot guarantee the export will be in the new format unless it was generated after this commit.
-
- 25 Nov, 2017 1 commit
-
-
David Muckle authored
-
- 24 Nov, 2017 1 commit
-
-
Christiaan Van den Poel authored
-
- 22 Nov, 2017 2 commits
-
-
Achilleas Pipinellis authored
-
Vitaliy @blackst0ne Klachkov authored
-
- 21 Nov, 2017 1 commit
-
-
Victor Wu authored
-
- 20 Nov, 2017 2 commits
-
-
Grzegorz Bizon authored
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 19 Nov, 2017 1 commit
-
-
Elan Ruusamäe authored
-
- 18 Nov, 2017 1 commit
-
-
Stan Hu authored
This was causing a docs lint failure in https://gitlab.com/gitlab-org/gitlab-ee/-/jobs/40901316.
-
- 16 Nov, 2017 6 commits
-
-
Achilleas Pipinellis authored
-
Achilleas Pipinellis authored
-
Achilleas Pipinellis authored
-
Achilleas Pipinellis authored
-
Achilleas Pipinellis authored
-
James Ramsay authored
The option to choose readme only as a users default project view was restored in !14900
-
- 14 Nov, 2017 1 commit
-
-
Chế Tiệp Chân Khoa authored
-
- 12 Nov, 2017 1 commit
-
-
Joshua Lambert authored
-
- 10 Nov, 2017 1 commit
-
-
Mark Fletcher authored
-
- 07 Nov, 2017 4 commits
-
-
Yorick Peterse authored
Prior to this MR there were two GitHub related importers: * Github::Import: the main importer used for GitHub projects * Gitlab::GithubImport: importer that's somewhat confusingly used for importing Gitea projects (apparently they have a compatible API) This MR renames the Gitea importer to Gitlab::LegacyGithubImport and introduces a new GitHub importer in the Gitlab::GithubImport namespace. This new GitHub importer uses Sidekiq for importing multiple resources in parallel, though it also has the ability to import data sequentially should this be necessary. The new code is spread across the following directories: * lib/gitlab/github_import: this directory contains most of the importer code such as the classes used for importing resources. * app/workers/gitlab/github_import: this directory contains the Sidekiq workers, most of which simply use the code from the directory above. * app/workers/concerns/gitlab/github_import: this directory provides a few modules that are included in every GitHub importer worker. == Stages The import work is divided into separate stages, with each stage importing a specific set of data. Stages will schedule the work that needs to be performed, followed by scheduling a job for the "AdvanceStageWorker" worker. This worker will periodically check if all work is completed and schedule the next stage if this is the case. If work is not yet completed this worker will reschedule itself. Using this approach we don't have to block threads by calling `sleep()`, as doing so for large projects could block the thread from doing any work for many hours. == Retrying Work Workers will reschedule themselves whenever necessary. For example, hitting the GitHub API's rate limit will result in jobs rescheduling themselves. These jobs are not processed until the rate limit has been reset. == User Lookups Part of the importing process involves looking up user details in the GitHub API so we can map them to GitLab users. The old importer used an in-memory cache, but this obviously doesn't work when the work is spread across different threads. The new importer uses a Redis cache and makes sure we only perform API/database calls if absolutely necessary. Frequently used keys are refreshed, and lookup misses are also cached; removing the need for performing API/database calls if we know we don't have the data we're looking for. == Performance & Models The new importer in various places uses raw INSERT statements (as generated by `Gitlab::Database.bulk_insert`) instead of using Rails models. This allows us to bypass any validations and callbacks, drastically reducing the number of SQL queries and Gitaly RPC calls necessary to import projects. To ensure the code produces valid data the corresponding tests check if the produced rows are valid according to the model validation rules.
-
Chenjerai Katanda authored
-
Victor Wu authored
-
Victor Wu authored
-
- 06 Nov, 2017 2 commits
-
-
Eric Eastwood authored
-
Shinya Maeda authored
-
- 03 Nov, 2017 1 commit
-
-
Eric Eastwood authored
-
- 02 Nov, 2017 6 commits
-
-
Pawel Chojnacki authored
-
Pawel Chojnacki authored
-
Eric Eastwood authored
Prompted to add this note from https://gitlab.com/gitlab-org/gitlab-ce/issues/34102#note_45522526
-
Douwe Maan authored
-
Douwe Maan authored
-
Alexander Randa authored
-
- 01 Nov, 2017 1 commit
-
-
Cindy Pallares 🦉 authored
Add information on duplicate or multiple triggers caused by a slow response time.
-
- 31 Oct, 2017 1 commit
-
-
Felipe Artur authored
-
- 30 Oct, 2017 1 commit
-
-
Jacopo authored
Pipeline hook data now includes the project_id
-
- 27 Oct, 2017 1 commit
-
-
Nick Brown authored
Already mentioned in the list above this one.
-
- 24 Oct, 2017 1 commit
-
-
Lyle Kozloff authored
-
- 23 Oct, 2017 3 commits
-
-
Connor Shea authored
-
Mark Fletcher authored
-
Mark Fletcher authored
-