Whenever we already deal with a User object, let's use the more specific
method avatar_icon_for_user.

When we don't use the original `ApplicationHelper#avatar_icon` anymore, we
can just remove it (and its specs).

Closes #42800.

Group MR numbers on issue show page by project and namespace

Closes #26466

See merge request gitlab-org/gitlab-ce!8494

Closes #26466.

Fix artifact creation in CI/CD QA spec

See merge request gitlab-org/gitlab-ce!17078

Port of EE-translations

See merge request gitlab-org/gitlab-ce!17081

Resolve "PrepareUntrackedUploads PostgreSQL syntax error"

Closes #42881

See merge request gitlab-org/gitlab-ce!17019

Resolve "Can't close issue through buttons in the textarea on mobile"

Closes #42923

See merge request gitlab-org/gitlab-ce!17043

Disable caching of tables for migration spec that drops a temporary table

See merge request gitlab-org/gitlab-ce!16965

Fix Error 500s creating merge requests with external issue tracker

Closes #43193

See merge request gitlab-org/gitlab-ce!17073

Cleanup new branch/merge request form in issues

Closes #41938

See merge request gitlab-org/gitlab-ce!16854

* master: (25 commits)
  Addressed mr observations
  Clean new Flash() and stop disabling no-new (eslint) when possible
  Disable query limiting warnings for now on GitLab.com
  Revert "Merge branch 'rd-40552-gitlab-should-check-if-keys-are-valid-before-saving' into 'master'"
  Fix warning messages for promoting labels and milestones
  Fixed missing js selector for the realtime pipelines commit comp
  Honour workhorse provided file name
  Create an empty wiki when there is no wiki in the gitlab export bundle
  Revert and remove header_title line from labels issue
  Fixed bug with param config
  changed params passed to from a string to an object
  Move IssuableTimeTracker vue component
  Fix breadcrumb on labels page for groups
  Convert groups_select ajax to use axios
  Default CI variables to unprotected
  make sure there is a dependency on Gitlab::CurrentSettings is
  Make GITLAB_FEATURES in build_spec compatible with EE
  Update jquery.waitforimages & use npm version
  Fixed typo, updated test, and removed commented code
  Replaced use of $.get with axios.get and updated tests
  ...

New Crowdin translations

See merge request gitlab-org/gitlab-ee!4481

When JIRA or Redmine were enabled and the branch name did not match the
matching regular expression, the `issue_iid` would be `nil`, preventing
users from creating merge requests.

Closes #43193

Updated katex library

Closes #43032

See merge request gitlab-org/gitlab-ce!15864

Clean new Flash() and stop disabling no-new (eslint) when possible

Closes #42732

See merge request gitlab-org/gitlab-ce!17060

Disable query limiting warnings for now on GitLab.com

See merge request gitlab-org/gitlab-ce!17067

Honour workhorse provided file name

See merge request gitlab-org/gitlab-ce!17059

Fix warning messages for promoting labels and milestones

Closes #42900

See merge request gitlab-org/gitlab-ce!17063

Merge branch 'rd-43185-revert-sanitize-extra-blank-spaces-used-when-uploading-a-ssh-key' into 'master'

Revert "Merge branch 'rd-40552-gitlab-should-check-if-keys-are-valid-before-saving' into 'master'"

See merge request gitlab-org/gitlab-ce!17062

To finish migrating untracked files to uploads for installations that were affected by https://gitlab.com/gitlab-org/gitlab-ce/issues/42881

Or just to delete the temp table if it is empty and left behind.

Fixed missing js selector for the realtime pipelines commit component

See merge request gitlab-org/gitlab-ce!17061

Convert groups_select ajax to use axios

See merge request gitlab-org/gitlab-ce!17041

This reverts commit a58f8c32, reversing
changes made to cd5d75c3.

Add loading button for better UX

In the attempt to unify file uploading at workhorse level gitlab-org/gitlab-workhorse!230
we moved to a prefix-based tempfile creation in order to avoid upload collisions.

Artifacts and LFS uploads already set original_filename to workhorse provided filename

This commit add the same feature to `Gitlab::Middleware::Multipart`

Make GITLAB_FEATURES in build_spec compatible with EE

Closes #40994

See merge request gitlab-org/gitlab-ce!17023

Fix a transient failure in db/post_migrate/20170717111152_cleanup_move_system_upload_folder_symlink.rb where symlink already exists
Signed-off-by: Rémy Coutable <remy@rymai.me>

We do that because  it's using factories and it's not worth it to get rid of them.
Signed-off-by: Rémy Coutable <remy@rymai.me>