- 05 Jul, 2016 1 commit
-
-
Timothy Andrew authored
1. The main implementation is in the `ProtectedBranch` model. The wildcard is converted to a Regex and compared. This has been tested thoroughly. - While `Project#protected_branch?` is the main entry point, `project#open_branches` and `project#developers_can_push_to_protected_branch?` have also been modified to work with wildcard protected branches. - The regex is memoized (within the `ProtectedBranch` instance) 2. Improve the performance of `Project#protected_branch?` - This method is called from `Project#open_branches` once _per branch_ in the project, to check if that branch is protected or not. - Before, `#protected_branch?` was making a database call every time it was invoked (in the above case, that amounts to once per branch), which is expensive. - This commit caches the list of protected branches in memory, which reduces the number of database calls down to 1. - A downside to this approach is that `#protected_branch?` _could_ return a stale value (due to the caching), but this is an acceptable tradeoff. 3. Remove the (now) unused `Project#protected_branch_names` method. - This was previously used to check for protected branch status.
-
- 03 Jun, 2016 2 commits
-
-
James Lopez authored
This reverts commit 3e991230.
-
James Lopez authored
# Conflicts: # app/models/project.rb
-
- 09 May, 2016 1 commit
-
-
Jeroen van Baarsen authored
In 8278b763 the default behaviour of annotation has changes, which was causing a lot of noise in diffs. We decided in #17382 that it is better to get rid of the whole annotate gem, and instead let people look at schema.rb for the columns in a table. Fixes: #17382
-
- 09 Dec, 2015 1 commit
-
-
Douwe Maan authored
-
- 12 Feb, 2015 1 commit
-
-
Jeroen van Baarsen authored
Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>
-
- 22 Jan, 2015 1 commit
-
-
Dmitriy Zaporozhets authored
-
- 26 Jun, 2014 1 commit
-
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 09 Apr, 2014 1 commit
-
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 05 Feb, 2013 1 commit
-
-
Dmitriy Zaporozhets authored
-
- 05 Jan, 2013 1 commit
-
-
Dmitriy Zaporozhets authored
-
- 04 Jan, 2013 1 commit
-
-
Dmitriy Zaporozhets authored
-
- 19 Nov, 2012 1 commit
-
-
Dmitriy Zaporozhets authored
-
- 09 Oct, 2012 2 commits
-
-
Dmitriy Zaporozhets authored
-
Andrey Kumanyaev authored
-
- 26 Sep, 2012 1 commit
-
-
Nihad Abbasov authored
-
- 02 Sep, 2012 1 commit
-
-
Sytse Sijbrandij authored
Merge branch 'master' into non-interactive-aws-install Conflicts: doc/installation.md Fix merge mess in installation.md
-
- 29 Aug, 2012 2 commits
-
-
Robert Speicher authored
-
Robert Speicher authored
-
- 10 Aug, 2012 1 commit
-
-
Robert Speicher authored
Didn't bother with files in db/, config/, or features/
-
- 02 Aug, 2012 1 commit
-
-
randx authored
-
- 26 Jun, 2012 1 commit
-
-
randx authored
-
- 26 May, 2012 1 commit
-
-
randx authored
-
- 10 May, 2012 1 commit
-
-
Robb Kidd authored
-
- 15 Feb, 2012 1 commit
-
-
Dmitriy Zaporozhets authored
ProtectedBranches model, Master permission for repo\n Allow push to protected branch for masters only
-