- 07 Dec, 2017 1 commit
-
-
Shinya Maeda authored
-
- 06 Dec, 2017 6 commits
-
-
Shinya Maeda authored
-
Shinya Maeda authored
-
Shinya Maeda authored
-
Shinya Maeda authored
-
Shinya Maeda authored
Use Class.new(StandardError) instead of custom extended error class. Bring back specified_dependencies?.
-
Shinya Maeda authored
-
- 05 Dec, 2017 1 commit
-
-
Kamil Trzcinski authored
-
- 03 Dec, 2017 11 commits
-
-
Kamil Trzcinski authored
-
Kamil Trzcinski authored
-
Kamil Trzcinski authored
-
Kamil Trzcinski authored
-
Kamil Trzcinski authored
This reverts commit 714082e65304ae2ec5c5400c59a68ab63e724aa9.
-
Kamil Trzcinski authored
-
Kamil Trzcinski authored
-
Zeger-Jan van de Weg authored
-
Kamil Trzcinski authored
-
Zeger-Jan van de Weg authored
Two things at ones, as there was no clean way to seperate the commit and give me feedback from the tests. But the model Artifact is now JobArtifact, and the table does not have a type anymore, but the metadata is now its own model: Ci::JobArtifactMetadata.
-
Zeger-Jan van de Weg authored
To allow jobs/builds to have multiple artifacts, and to start seperating concerns from Ci::Build a new model is created: Ci::Artifact. Changes include the updating of the ArtifactUploader to adapt to a slightly different interface. The uploader expects to be initialized with a `Ci::Build`. Futher a migration with the minimal fields, the needed foreign keys and an index. Last, the way this works is by prepending a module to Ci::Build so we can basically override behaviour but if needed use `super` to get the original behaviour.
-
- 27 Nov, 2017 1 commit
-
-
Kamil Trzcinski authored
-
- 23 Nov, 2017 1 commit
-
-
Sean McGivern authored
Compared to the merge_request_diff association: 1. It's simpler to query. The query uses a foreign key to the merge_request_diffs table, so no ordering is necessary. 2. It's faster for preloading. The merge_request_diff association has to load every diff for the MRs in the set, then discard all but the most recent for each. This association means that Rails can just query for N diffs from N MRs. 3. It's more complicated to update. This is a bidirectional foreign key, so we need to update two tables when adding a diff record. This also means we need to handle this as a special case when importing a GitLab project. There is some juggling with this association in the merge request model: * `MergeRequest#latest_merge_request_diff` is _always_ the latest diff. * `MergeRequest#merge_request_diff` reuses `MergeRequest#latest_merge_request_diff` unless: * Arguments are passed. These are typically to force-reload the association. * It doesn't exist. That means we might be trying to implicitly create a diff. This only seems to happen in specs. * The association is already loaded. This is important for the reasons explained in the comment, which I'll reiterate here: if we a) load a non-latest diff, then b) get its `merge_request`, then c) get that MR's `merge_request_diff`, we should get the diff we loaded in c), even though that's not the latest diff. Basically, `MergeRequest#merge_request_diff` is the latest diff in most cases, but not quite all.
-
- 16 Nov, 2017 1 commit
-
-
Jacopo authored
Adds a rubocop rule (with autocorrect) to ensure line break after guard clauses.
-
- 06 Nov, 2017 2 commits
-
-
Shinya Maeda authored
-
Shinya Maeda authored
-
- 06 Oct, 2017 1 commit
-
-
Alessio Caiazza authored
-
- 05 Oct, 2017 1 commit
-
-
Alessio Caiazza authored
-
- 03 Oct, 2017 1 commit
-
-
Alessio Caiazza authored
-
- 12 Sep, 2017 1 commit
-
-
Maxim Rydkin authored
-
- 06 Sep, 2017 5 commits
-
-
Kamil Trzcinski authored
-
Shinya Maeda authored
-
Shinya Maeda authored
-
Shinya Maeda authored
-
James Lopez authored
-
- 05 Sep, 2017 3 commits
-
-
James Lopez authored
-
Shinya Maeda authored
-
Shinya Maeda authored
-
- 04 Sep, 2017 2 commits
-
-
Shinya Maeda authored
-
Shinya Maeda authored
-
- 03 Sep, 2017 2 commits
-
-
Shinya Maeda authored
-
Shinya Maeda authored
-