BigW Consortium Gitlab

  1. 14 Sep, 2017 1 commit
  2. 20 Jul, 2017 1 commit
  3. 06 Jul, 2017 4 commits
    • Implement review comments for !11963 from @adamniedzielski. · 8fa08ea3
      Timothy Andrew authored
      - Change double quotes to single quotes.
      - Why is `OmniAuth.config.full_host` being reassigned in the integration test?
      - Use `map` over `map!` to avoid `dup` in the `gitlab:info` rake task
      - Other minor changes
    • Add integration tests around OAuth login. · e936db96
      Timothy Andrew authored
      - There was previously a test for `saml` login in `login_spec`, but this didn't
        seem to be passing. A lot of things didn't seem right here, and I suspect that
        this test hasn't been running. I'll investigate this further.
      
      - It took almost a whole working day to figure out this line:
      
          OmniAuth.config.full_host = ->(request) { request['REQUEST_URI'].sub(request['REQUEST_PATH'], '') }
      
        As always, it's obvious in retrospect, but it took some digging to figure out
        tests were failing and returning 404s during the callback phase.
      
      - Test all OAuth providers - github, twitter, bitbucket, gitlab, google, and facebook
    • Implement "remember me" for OAuth-based login. · 633793cf
      Timothy Andrew authored
      - Pass a `remember_me` query parameter along with the initial OAuth request, and
        pick this parameter up during the omniauth callback from
        request.env['omniauth.params']`.
      
      - For 2FA-based login, copy the `remember_me` param from `omniauth.params` to
        `params`, which the 2FA process will pick up.
      
      - For non-2FA-based login, simply call the `remember_me` devise method to set
        the session cookie.
  4. 05 Jul, 2017 1 commit
  5. 03 Jul, 2017 4 commits
    • Implement review comments for !11963 from @adamniedzielski. · 4c34374d
      Timothy Andrew authored
      - Change double quotes to single quotes.
      - Why is `OmniAuth.config.full_host` being reassigned in the integration test?
      - Use `map` over `map!` to avoid `dup` in the `gitlab:info` rake task
      - Other minor changes
    • Add integration tests around OAuth login. · dd926401
      Timothy Andrew authored
      - There was previously a test for `saml` login in `login_spec`, but this didn't
        seem to be passing. A lot of things didn't seem right here, and I suspect that
        this test hasn't been running. I'll investigate this further.
      
      - It took almost a whole working day to figure out this line:
      
          OmniAuth.config.full_host = ->(request) { request['REQUEST_URI'].sub(request['REQUEST_PATH'], '') }
      
        As always, it's obvious in retrospect, but it took some digging to figure out
        tests were failing and returning 404s during the callback phase.
      
      - Test all OAuth providers - github, twitter, bitbucket, gitlab, google, and facebook
    • Implement "remember me" for OAuth-based login. · 5b649ac6
      Timothy Andrew authored
      - Pass a `remember_me` query parameter along with the initial OAuth request, and
        pick this parameter up during the omniauth callback from
        request.env['omniauth.params']`
      
      - For 2FA-based login, copy the `remember_me` param from `omniauth.params` to
        `params`, which the 2FA process will pick up.
      
      - For non-2FA-based login, simply call the `remember_me` devise method to set
        the session cookie.
  6. 02 Feb, 2017 1 commit
  7. 31 Dec, 2016 1 commit
  8. 15 Oct, 2016 2 commits
  9. 03 Aug, 2016 2 commits
  10. 03 Jun, 2016 2 commits
  11. 12 May, 2016 1 commit
  12. 23 Jul, 2015 1 commit
  13. 24 Apr, 2015 1 commit
  14. 31 Mar, 2015 1 commit
  15. 22 Mar, 2015 1 commit
  16. 14 Feb, 2015 1 commit