BigW Consortium Gitlab

  1. 22 Dec, 2017 1 commit
  2. 13 Dec, 2017 1 commit
    • Make discussion mail References all notes in the discussion · f55aaca5
      Toon Claes authored
      When a note is part of a discussion, the email sent out will be
      `In-Reply-To` the previous note in that discussion. It also
      `References` all the previous notes in that discussion, and the
      original issue.
      
      Closes gitlab-org/gitlab-ce#36054.
  3. 01 Dec, 2017 1 commit
  4. 13 Nov, 2017 1 commit
  5. 09 Oct, 2017 1 commit
  6. 23 Sep, 2017 1 commit
  7. 01 Sep, 2017 2 commits
  8. 10 Aug, 2017 1 commit
  9. 02 Aug, 2017 1 commit
  10. 27 Jul, 2017 1 commit
  11. 05 Jul, 2017 1 commit
  12. 21 Jun, 2017 1 commit
  13. 14 Jun, 2017 1 commit
  14. 25 May, 2017 1 commit
  15. 04 May, 2017 1 commit
  16. 01 May, 2017 1 commit
  17. 26 Apr, 2017 1 commit
  18. 06 Apr, 2017 1 commit
  19. 05 Apr, 2017 5 commits
  20. 03 Apr, 2017 1 commit
  21. 27 Mar, 2017 1 commit
  22. 21 Mar, 2017 2 commits
  23. 17 Mar, 2017 2 commits
  24. 14 Mar, 2017 1 commit
  25. 23 Feb, 2017 2 commits
  26. 28 Nov, 2016 3 commits
  27. 25 Nov, 2016 4 commits
    • Clean up rubocop complaint · c0931722
      hhoopes authored
    • Add keyword arguments to truncated_diff method · a761c59a
      hhoopes authored
      * Added keyword arguments to truncated_diff_lines method to allow for using highlighting or not (html templates vs. text)
      * Tweaked templates for consistency and format appropriateness
    • Change diff highlight/truncate for reusability · f928dba9
      hhoopes authored
      Previously the `truncated_diff_lines` method for outputting a discussion diff took in already highlighted lines, which meant it wasn't reuseable for truncating ANY lines. In the way it was used, it also meant that for any email truncation, the whole diff was being highlighted before being truncated, meaning wasted time highlighting lines that wouldn't even be used (granted, they were being memoized, so perhaps this wasn't that great of an issue). I refactored truncation away from highlighting, in order to truncate formatted diffs for text templates in email, using `>`s to designate each line, but otherwise retaining the parsing already done to create `diff_lines`.
      
      Additionally, while notes on merge requests or commits had already been tested, there was no existing test for notes on a diff on an MR or commit. Added mailer tests for such, and a unit test for truncating diff lines.
    • Add new template to handle both commit & mr notes · 24070bac
      hhoopes authored
      Currently comments on commits and merge requests do not require merge request- or commit-specific information, but can use the same template. Rather than change the method which calls the template, I opted to keep the templates separate and create a new template to highlight their identicality, while preserving the option to distinguish them from each other in the future.
      
      Also removed some of the inconsistencies between text and html email versions.
      
      Still needed is a text-only version of git diffs and testing.