BigW Consortium Gitlab

  1. 30 Jun, 2017 1 commit
  2. 21 Jun, 2017 1 commit
  3. 14 Jun, 2017 2 commits
  4. 09 Jun, 2017 1 commit
  5. 08 Jun, 2017 3 commits
    • Merge branch '25934-project-snippet-vis' into 'security-9-2' · ae6adf16
      DJ Mountney authored
      Fix visibility when referencing snippets
      
      See merge request !2101
    • Bring in security changes from the 9.2.5 release · 565ead61
      DJ Mountney authored
      Ran:
       - git format-patch v9.2.2..v9.2.5 --stdout > patchfile.patch
       - git checkout -b 9-2-5-security-patch origin/v9.2.2
       - git apply patchfile.patch
       - git commit
       - [Got the sha ref for the commit]
       - git checkout -b upstream-9-2-security master
       - git cherry-pick <SHA of the patchfile commit>
       - [Resolved conflicts]
       - git cherry-pick --continue
    • Bring in security changes from the 9.2.5 release · 1d1363e2
      DJ Mountney authored
      Ran:
       - git format-patch v9.2.2..v9.2.5 --stdout > patchfile.patch
       - git checkout -b 9-2-5-security-patch origin/v9.2.2
       - git apply patchfile.patch
       - git commit
       - [Got the sha ref for the commit]
       - git checkout -b upstream-9-2-security master
       - git cherry-pick <SHA of the patchfile commit>
       - [Resolved conflicts]
       - git cherry-pick --continue
  6. 30 May, 2017 1 commit
    • Fix /unsubscribe slash command creating extra todos · 172932ee
      Sean McGivern authored
      The /unsubscribe slash command means that we check if the current user is
      subscribed to the issuable without having an explicit subscription. That means
      that we use the UserParser to find references to them in the notes.
      
      The UserParser (and all parsers inheriting from BaseParser) use RequestStore to
      cache ActiveRecord objects, so that we don't need to load the User object each
      time, if we're parsing references a bunch of times in the same request.
      
      However, it was always returning _all_ of the previously cached items, not just
      the ones matching the IDs passed. This would mean that we did two runs through
      with UserParser if you were mentioned in a comment, and then mentioned someone
      else in your comment while using /unsubscribe:
      
      1. Because /unsubscribe was used, we see if you were mentioned in any comments.
      2. Because you mentioned someone, we find them - but we would also get back your
         user, even if you didn't mention yourself. This would have the effect of
         creating a mention or directly addressed todo for yourself incorrectly.
      
      The fix is simple: only return values from the cache matching the IDs passed.
  7. 15 Apr, 2017 1 commit
  8. 07 Apr, 2017 1 commit
    • Add indication for closed or merged issuables in GFM · ace833b3
      Adam Buckland authored
      Example: for issues that are closed, the links will now show '[closed]'
      following the issue number. This is done as post-process after the markdown has
      been loaded from the cache as the status of the issue may change between
      the cache being populated and the content being displayed.
      
      In order to avoid N+1 queries problem when rendering notes ObjectRenderer
      populates the cache of referenced issuables for all notes at once,
      before the post processing phase.
      
      As a part of this change, the Banzai BaseParser#grouped_objects_for_nodes
      method has been refactored to return a Hash utilising the node itself as the
      key, since this was a common pattern of usage for this method.
  9. 23 Feb, 2017 2 commits
  10. 25 Jan, 2017 1 commit
  11. 29 Dec, 2016 1 commit
  12. 09 Nov, 2016 1 commit
  13. 30 Aug, 2016 1 commit
  14. 29 Jul, 2016 1 commit
    • Method for returning issues readable by a user · 002ad215
      Yorick Peterse authored
      The method Ability.issues_readable_by_user takes a list of users and an
      optional user and returns an Array of issues readable by said user. This
      method in turn is used by
      Banzai::ReferenceParser::IssueParser#nodes_visible_to_user so this
      method no longer needs to get all the available abilities just to check
      if a user has the "read_issue" ability.
      
      To test this I benchmarked an issue with 222 comments on my development
      environment. Using these changes the time spent in nodes_visible_to_user
      was reduced from around 120 ms to around 40 ms.
  15. 08 Jul, 2016 1 commit
  16. 03 Jun, 2016 2 commits
  17. 26 May, 2016 1 commit
    • Split Markdown rendering & reference gathering · 86166d28
      Yorick Peterse authored
      This splits the Markdown rendering and reference extraction phases into
      two distinct code bases. The reference extraction phase no longer relies
      on the html-pipeline Gem (and any related code) and allows for
      extracting of references from multiple HTML nodes in a single pass. This
      means that if you want to extract user references from 200 comments you
      no longer need to run 200 times N number of queries, instead only a
      handful of queries may be needed.