- 25 Jan, 2017 1 commit
-
-
Yorick Peterse authored
There were two cases that could be problematic: 1. Because sometimes AuthorizedProjectsWorker would be scheduled in a transaction it was possible for a job to run/complete before a COMMIT; resulting in it either producing an error, or producing no new data. 2. When scheduling jobs the code would not wait until completion. This could lead to a user creating a project and then immediately trying to push to it. Usually this will work fine, but given enough load it might take a few seconds before a user has access. The first one is problematic, the second one is mostly just annoying (but annoying enough to warrant a solution). This commit changes two things to deal with this: 1. Sidekiq scheduling now takes places after a COMMIT, this is ensured by scheduling using Rails' after_commit hook instead of doing so in an arbitrary method. 2. When scheduling jobs the calling thread now waits for all jobs to complete. Solution 2 requires tracking of job completions. Sidekiq provides a way to find a job by its ID, but this involves scanning over the entire queue; something that is very in-efficient for large queues. As such a more efficient solution is necessary. There are two main Gems that can do this in a more efficient manner: * sidekiq-status * sidekiq_status No, this is not a joke. Both Gems do a similar thing (but slightly different), and the only difference in their name is a dash vs an underscore. Both Gems however provide far more than just checking if a job has been completed, and both have their problems. sidekiq-status does not appear to be actively maintained, with the last release being in 2015. It also has some issues during testing as API calls are not stubbed in any way. sidekiq_status on the other hand does not appear to be very popular, and introduces a similar amount of code. Because of this I opted to write a simple home grown solution. After all, all we need is storing a job ID somewhere so we can efficiently look it up; we don't need extra web UIs (as provided by sidekiq-status) or complex APIs to update progress, etc. This is where Gitlab::SidekiqStatus comes in handy. This namespace contains some code used for tracking, removing, and looking up job IDs; all without having to scan over an entire queue. Data is removed explicitly, but also expires automatically just in case. Using this API we can now schedule jobs in a fork-join like manner: we schedule the jobs in Sidekiq, process them in parallel, then wait for completion. By using Sidekiq we can leverage all the benefits such as being able to scale across multiple cores and hosts, retrying failed jobs, etc. The one downside is that we need to make sure we can deal with unexpected increases in job processing timings. To deal with this the class Gitlab::JobWaiter (used for waiting for jobs to complete) will only wait a number of seconds (30 by default). Once this timeout is reached it will simply return. For GitLab.com almost all AuthorizedProjectWorker jobs complete in seconds, only very rarely do we spike to job timings of around a minute. These in turn seem to be the result of external factors (e.g. deploys), in which case a user is most likely not able to use the system anyway. In short, this new solution should ensure that jobs are processed properly and that in almost all cases a user has access to their resources whenever they need to have access.
-
- 25 Nov, 2016 1 commit
-
-
Yorick Peterse authored
When I proposed using serializable transactions I was hoping we would be able to refresh data of individual users concurrently. Unfortunately upon closer inspection it was revealed this was not the case. This could result in a lot of queries failing due to serialization errors, overloading the database in the process (given enough workers trying to update the target table). To work around this we're now using a Redis lease that is cancelled upon completion. This ensures we can update the data of different users concurrently without overloading the database. The code will try to obtain the lease until it succeeds, waiting at least 1 second between retries. This is necessary as we may otherwise end up _not_ updating the data which is not an option.
-
- 18 Nov, 2016 1 commit
-
-
Ahmad Sherif authored
Closes #23150
-
- 23 Sep, 2016 1 commit
-
-
Grzegorz Bizon authored
-
- 28 Jul, 2016 1 commit
-
-
Z.J. van de Weg authored
[ci skip]
-
- 06 Oct, 2015 1 commit
-
-
Stan Hu authored
-
- 05 Oct, 2015 1 commit
-
-
Stan Hu authored
Seed-Fu runs this entire fixture in a transaction, so the `after_commit` hook won't run until after the fixture is loaded. That is too late since the Sidekiq::Testing block has already exited. Force clearing the `after_commit` queue to ensure the job is run now. See: gitlab-org/gitlab-development-kit#58
-
- 17 Jul, 2015 1 commit
-
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 20 May, 2015 1 commit
-
-
Robert Speicher authored
Adds a version requirement which it didn't have before, at 2.0.0. This version has breaking API changes in that the namespace is now `FFaker` instead of `Faker`.
-
- 10 Nov, 2014 1 commit
-
-
Dmitriy Zaporozhets authored
This reverts commit a9fadce3.
-
- 26 Oct, 2014 1 commit
-
-
Ciro Santilli authored
-
- 27 Sep, 2014 1 commit
-
-
Ciro Santilli authored
-
- 10 Sep, 2014 2 commits
-
-
Sytse Sijbrandij authored
-
Jacob Vosmaer authored
The repository was removed from github.com/gitlabhq.
-
- 11 Aug, 2014 1 commit
-
-
Dmitriy Zaporozhets authored
* Improt projects inline so after seeds you have repos * Fix merge request seeds * Add comment seeds to both issues and merge requests * Remove some projects from seeds to increase speed Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 05 May, 2014 1 commit
-
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 15 Mar, 2014 1 commit
-
-
Dmitriy Zaporozhets authored
Return execution of observers in seeds. Mute email sending to letter opening in you browser. Added `rake dev` task to reset db and add seeds. Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 28 Feb, 2014 1 commit
-
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 25 Feb, 2014 1 commit
-
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 23 Jan, 2014 1 commit
-
-
Marin Jankovski authored
-
- 19 Jan, 2014 1 commit
-
-
skv authored
-
- 17 Oct, 2013 1 commit
-
-
Dmitriy Zaporozhets authored
-
- 20 Jun, 2013 1 commit
-
-
Dmitriy Zaporozhets authored
-
- 09 Feb, 2013 1 commit
-
-
Dmitriy Zaporozhets authored
-
- 05 Jan, 2013 1 commit
-
-
Dmitriy Zaporozhets authored
-
- 27 Dec, 2012 1 commit
-
-
Dmitriy Zaporozhets authored
-
- 11 Dec, 2012 1 commit
-
-
Dmitriy Zaporozhets authored
-
- 21 Nov, 2012 1 commit
-
-
Dmitriy Zaporozhets authored
Project -> update repo only on create and destroy. Fixtures Updated with namespaces. Fixed moving repo
-
- 23 Nov, 2012 1 commit
-
-
Dmitriy Zaporozhets authored
-
- 13 Nov, 2012 1 commit
-
-
Dmitriy Zaporozhets authored
-
- 15 Dec, 2011 1 commit
-
-
Dmitriy Zaporozhets authored
-
- 04 Dec, 2011 1 commit
-
-
Dmitriy Zaporozhets authored
-