- 23 Nov, 2016 1 commit
-
-
Valery Sizov authored
-
- 10 Nov, 2016 1 commit
-
-
gfyoung authored
-
- 07 Apr, 2016 1 commit
-
-
Felipe Artur authored
-
- 05 Apr, 2016 3 commits
-
-
Felipe Artur authored
-
Felipe Artur authored
-
Felipe Artur authored
-
- 23 Mar, 2016 1 commit
-
-
Rémy Coutable authored
-
- 20 Mar, 2016 1 commit
-
-
Douwe Maan authored
-
- 05 Dec, 2015 1 commit
-
-
Stan Hu authored
Two issues: 1. The constraints in the resources were incorrect. Here's what it was before: ``` group_milestone GET /groups/:group_id/milestones/:id(.:format) groups/milestones#show {:id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/} ``` In this case, id is actually the title of the milestone, which can be anything at the moment. After: ``` group_milestone GET /groups/:group_id/milestones/:id(.:format) groups/milestones#show {:id=>/[^\/]+/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/} ``` 2. `parameterize` would strip all Unicode characters, leaving a blank string. Rails would report something like: ActionView::Template::Error (No route matches {:action=>"show", :controller=>"groups/milestones", :group_id=>#<Group id: 48, name: "ops-dev", path: "ops-dev", owner_id: nil, created_at: "2015-11-15 08:55:30", updated_at: "2015-12-02 06:23:26", type: "Group", description: "", avatar: "sha1.c71e73d51af1865c1bbbf6208e10044d46c9bb93.png", public: false>, :id=>"", :title=>"肯定不是中文的问题"} missing required keys: [:id]): This change uses the babosa library to create a better slug, which surprisingly isn't actually used by the global milestone controllers. Instead, they use the title passed as a query string for some reason. Closes https://github.com/gitlabhq/gitlabhq/issues/9881 Fix constraints
-
- 16 Nov, 2015 3 commits
-
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 30 Apr, 2015 1 commit
-
-
Douwe Maan authored
-
- 20 Apr, 2015 1 commit
-
-
Jeroen van Baarsen authored
Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>
-
- 14 Apr, 2015 1 commit
-
-
Douwe Maan authored
-
- 12 Mar, 2015 1 commit
-
-
Dmitriy Zaporozhets authored
-
- 03 Mar, 2015 1 commit
-
-
Douwe Maan authored
-
- 04 Jul, 2014 1 commit
-
-
Marin Jankovski authored
-
- 30 Jun, 2014 12 commits
-
-
Marin Jankovski authored
-
Marin Jankovski authored
Show all issues and merge requests that could be considered opened or closed, includes reopened and merged.
-
Marin Jankovski authored
-
Marin Jankovski authored
-
Marin Jankovski authored
-
Marin Jankovski authored
-
Marin Jankovski authored
-
Marin Jankovski authored
-
Marin Jankovski authored
-
Marin Jankovski authored
-
Marin Jankovski authored
-
Marin Jankovski authored
-