- 06 Mar, 2017 1 commit
-
-
Tiago Botelho authored
-
- 01 Mar, 2017 1 commit
-
-
Tiago Botelho authored
-
- 28 Feb, 2017 3 commits
-
-
Tiago Botelho authored
-
Tiago Botelho authored
refactors documentation and personal access tokens form to not allow admins to generate non impersionation tokens
-
Simon Vocella authored
-
- 14 Feb, 2017 1 commit
-
-
Phil Hughes authored
-
- 09 Feb, 2017 1 commit
-
-
Phil Hughes authored
In an effort to tackle #18437 this removes 2 of the jQuery UI plugins. Highlight & autocomplete, both used once in our code. Highlight was just removed easily, autocomplete was replaced with GL dropdown
-
- 06 Feb, 2017 3 commits
-
-
Phil Hughes authored
-
Phil Hughes authored
-
Phil Hughes authored
Part of #18437 to remove jQuery UI. This removes the datepicker
-
- 13 Jan, 2017 1 commit
-
-
victorwu authored
-
- 16 Dec, 2016 3 commits
-
-
Timothy Andrew authored
- The `scopes_form` partial can be used in the `admin/applications` view as well - Don't allow partials to access instance variables directly. Instead, pass in the instance variables as local variables, and use `local_assigns.fetch` to assert that the variables are passed in as expected. - Change a few instances of `render :partial` to `render` - Remove an instance of `required: false` in a view, since this is the default - Inline many instances of a local variable (`ip = 'ip'`) in `auth_spec`
-
Timothy Andrew authored
- The list of scopes that's displayed while creating a personal access token is identical to the list that's displayed while creating an OAuth application. Extract these into a partial. - The list of scopes that's displayed while in the show page for an OAuth token in the profile settings and admin settings are identical. Extract these into a partial.
-
Timothy Andrew authored
-
- 17 Aug, 2016 1 commit
-
-
Patricio Cano authored
-
- 16 Aug, 2016 2 commits
-
-
Patricio Cano authored
-
Patricio Cano authored
-
- 30 Jun, 2016 1 commit
-
-
Connor Shea authored
-
- 16 Jun, 2016 1 commit
-
-
Timothy Andrew authored
- Extract a duplicated `redirect_to` - Fix a typo: "token", not "certificate" - Have the "Expires at" datepicker be attached to a text field, not inline - Have both private tokens and personal access tokens verified in a single "authenticate_from_private_token" method, both in the application and API. Move relevant logic to `User#find_by_personal_access_token` - Remove unnecessary constants relating to API auth. We don't need a separate constant for personal access tokens since the param is the same as for private tokens.
-
- 10 Jun, 2016 1 commit
-
-
Timothy Andrew authored
- Just use a link for the clipboard button. Having a non-clickable container (that looks like a button) is confusing. - Use `text-danger` for the "you won't be able to access it again" message. - Highlight the created token so people know to look there.
-
- 09 Jun, 2016 1 commit
-
-
Timothy Andrew authored
- No hardcoded colors in any SCSS file except `variables.scss` - Don't allow choosing a date in the past - Use the same table as in the "Applications" tab - The button should say "Create Personal Access Token" - Float the revoke button to the right of the table cell - Change the revocation message to be more explicit. - Date shouldn't look selected on page load - Don't use a panel for the created token - Use a normal flash for "Your new personal access token has been created" - Show the input (with the token) below it full width. - Put the "Make sure you save it - you won't be able to access it again." message near the input - Have the created token's input highlight all on single click
-
- 03 Jun, 2016 2 commits
-
-
Timothy Andrew authored
-
Timothy Andrew authored
- No "Actions" label necessary - `%td` can be moved out of `if/else` - Page header should be "Profile Settings", not "Personal Access Tokens" - "You don't have any tokens" message should be styled consistently
-
- 02 Jun, 2016 1 commit
-
-
Timothy Andrew authored
-
- 01 Jun, 2016 1 commit
-
-
Timothy Andrew authored
- Use the `:personal_access_token` param root instead of `personal_access_token_params`, because we aren't using the `personal_access_token` param for authentication anymore (we're using `private_token` instead). - Use `build` to instantiate a `PersonalAccessToken` - Use better-formatted dates
-
- 11 May, 2016 1 commit
-
-
Timothy Andrew authored
- Spaces around `{` and `}` in HAML. - Typo in CHANGELOG. - Remove i18n.
-
- 28 Apr, 2016 10 commits
-
-
Timothy Andrew authored
- Use `TokenAuthenticatable` to generate the personal access token - Remove a check for `authenticity_token` in application controller; this should've been `authentication_token`, maybe, and doesn't make any sense now. - Have the datepicker appear inline
-
Timothy Andrew authored
-
Timothy Andrew authored
- In the personal access tokens page. - Also fix the z-index so it doesn't appear below the token text fields.
-
Timothy Andrew authored
-
Timothy Andrew authored
- Can't use `personal_access_token` anymore, because the contents of that param are assumed to be a token string, and authenticated against.
-
Timothy Andrew authored
-
Timothy Andrew authored
- Show the count for each section in parens - Remove the `revoked?` check, because everything in the active section is guaranteed to not be revoked.
-
Timothy Andrew authored
-
Timothy Andrew authored
-
Timothy Andrew authored
-