- 30 Nov, 2016 2 commits
-
-
Robert Schilling authored
-
Robert Schilling authored
-
- 29 Nov, 2016 3 commits
-
-
Grzegorz Bizon authored
-
Douwe Maan authored
Replace issue access checks with use of IssuableFinder Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867 ## Which fixes are in this MR?
- Potentially untested - No test coverage - Test coverage of some sort exists (a test failed when error raised) - Test coverage of return value (a test failed when nil used) - Permissions check tested ### Issue lookup with access check Using `visible_to_user` likely makes these security issues too. See [Code smells](#code-smells). - [x] app/finders/notes_finder.rb:15 [`visible_to_user`] - [x] app/views/layouts/nav/_project.html.haml:73 [`visible_to_user`] [`.count`] - [x] app/services/merge_requests/build_service.rb:84 [`issue.try(:confidential?)`] - [x] lib/api/issues.rb:112 [`visible_to_user`] - CHANGELOG: Prevented API returning issues set to 'Only team members' to everyone - [x] lib/api/helpers.rb:126 [`can?(current_user, :read_issue, issue)`] Maybe here too? - [x] lib/gitlab/search_results.rb:53 [`visible_to_user`] ### Previous discussions - [ ] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#b2ff264eddf9819d7693c14ae213d941494fe2b3_128_126 - [ ] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#7b6375270d22f880bdcb085e47b519b426a5c6c7_87_87 See merge request !2031 -
Douwe Maan authored
Fix label creation non members Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/23416 See merge request !2006
-
- 28 Nov, 2016 1 commit
-
-
Robert Schilling authored
-
- 25 Nov, 2016 1 commit
-
-
Z.J. van de Weg authored
The coverage wasn't exposed yet, now it is but only for detailed requests to save queries on the database.
-
- 24 Nov, 2016 5 commits
-
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Robert Schilling authored
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 23 Nov, 2016 3 commits
-
-
Robert Schilling authored
-
Robert Schilling authored
-
Valery Sizov authored
-
- 22 Nov, 2016 3 commits
-
-
Robert Schilling authored
-
Robert Schilling authored
-
Semyon Pupkov authored
-
- 21 Nov, 2016 3 commits
-
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Robert Schilling authored
-
Robert Schilling authored
-
- 18 Nov, 2016 5 commits
-
-
Ido Leibovich authored
Add a new endpoint in the new API for creating a new pipeline, and return the details of that pipeline.
-
Z.J. van de Weg authored
This prevents leakage of project names on an endpoint which is unauthenticated and thus open to the world.
-
Z.J. van de Weg authored
-
Robert Schilling authored
-
Z.J. van de Weg authored
-
- 17 Nov, 2016 6 commits
-
-
Z.J. van de Weg authored
-
Z.J. van de Weg authored
[ci skip]
-
Kamil Trzcinski authored
-
Sean McGivern authored
Allow `order_by` and `sort` parameters to `/api/v3/groups.json`. At present, only ordering by name and path is supported, and the default sort is name ascending (alphabetical order).
-
Douglas Barbosa Alexandre authored
-
Douglas Barbosa Alexandre authored
-
- 16 Nov, 2016 2 commits
-
-
Nick Thomas authored
gitlab-shell v3.6.6 would give project paths like so: * namespace/project gitlab-shell v4.0.0 can give project paths like so: * /namespace1/namespace2/project * /namespace/project * /path/to/repository/storage/namespace1/namespace2/project * /path/to/repository/storage/namespace/project
-
Adam Niedzielski authored
-
- 15 Nov, 2016 4 commits
-
-
Robert Schilling authored
-
Dmitry Poray authored
-
Robert Schilling authored
-
Robert Schilling authored
-
- 14 Nov, 2016 2 commits
-
-
Francesco Coda Zabetta authored
-
Francesco Coda Zabetta authored
-