- 10 Aug, 2017 1 commit
-
-
Yorick Peterse authored
This commit migrates events data in such a way that push events are stored much more efficiently. This is done by creating a shadow table called "events_for_migration", and a table called "push_event_payloads" which is used for storing push data of push events. The background migration in this commit will copy events from the "events" table into the "events_for_migration" table, push events in will also have a row created in "push_event_payloads". This approach allows us to reclaim space in the next release by simply swapping the "events" and "events_for_migration" tables, then dropping the old events (now "events_for_migration") table. The new table structure is also optimised for storage space, and does not include the unused "title" column nor the "data" column (since this data is moved to "push_event_payloads"). == Newly Created Events Newly created events are inserted into both "events" and "events_for_migration", both using the exact same primary key value. The table "push_event_payloads" in turn has a foreign key to the _shadow_ table. This removes the need for recreating and validating the foreign key after swapping the tables. Since the shadow table also has a foreign key to "projects.id" we also don't have to worry about orphaned rows. This approach however does require some additional storage as we're duplicating a portion of the events data for at least 1 release. The exact amount is hard to estimate, but for GitLab.com this is expected to be between 10 and 20 GB at most. The background migration in this commit deliberately does _not_ update the "events" table as doing so would put a lot of pressure on PostgreSQL's auto vacuuming system. == Supporting Both Old And New Events Application code has also been adjusted to support push events using both the old and new data formats. This is done by creating a PushEvent class which extends the regular Event class. Using Rails' Single Table Inheritance system we can ensure the right class is used for the right data, which in this case is based on the value of `events.action`. To support displaying old and new data at the same time the PushEvent class re-defines a few methods of the Event class, falling back to their original implementations for push events in the old format. Once all existing events have been migrated the various push event related methods can be removed from the Event model, and the calls to `super` can be removed from the methods in the PushEvent model. The UI and event atom feed have also been slightly changed to better handle this new setup, fortunately only a few changes were necessary to make this work. == API Changes The API only displays push data of events in the new format. Supporting both formats in the API is a bit more difficult compared to the UI. Since the old push data was not really well documented (apart from one example that used an incorrect "action" nmae) I decided that supporting both was not worth the effort, especially since events will be migrated in a few days _and_ new events are created in the correct format.
-
- 09 Aug, 2017 1 commit
-
-
Simon Knox authored
-
- 02 Aug, 2017 2 commits
-
-
Robert Speicher authored
-
Robert Speicher authored
-
- 28 Jul, 2017 1 commit
-
-
Phil Hughes authored
-
- 17 Jul, 2017 1 commit
-
-
Alexander Randa authored
-
- 07 Jul, 2017 1 commit
-
-
Tim Zallmann authored
-
- 05 Jul, 2017 2 commits
-
-
Douwe Maan authored
-
Alexander Randa authored
-
- 29 Jun, 2017 1 commit
-
-
Bryce Johnson authored
This commit moves the rendering of the button back to the server, and shows/hides it using opacity rather than display. It also removes the transform applied to the button on hover (scale). Previously, both of these factors automatically triggered a reflow, which creates a performance bottleneck on pages with larger DOM size. MR: !12103
-
- 26 Jun, 2017 1 commit
-
-
Alexander Randa authored
-
- 07 Jun, 2017 1 commit
-
-
Luke "Jared" Bennett authored
-
- 25 May, 2017 1 commit
-
-
Phil Hughes authored
-
- 22 May, 2017 1 commit
-
-
Oswaldo Ferreira authored
-
- 17 May, 2017 2 commits
-
-
Douwe Maan authored
-
Lin Jen-Shin authored
Rename other URL generators admin_builds_path -> admin_jobs_path Fix tests and more renaming Fix more tests Also change build_id to job_id in the controller
-
- 16 May, 2017 1 commit
-
-
Tim Zallmann authored
-
- 09 May, 2017 1 commit
-
-
Fatih Acet authored
-
- 05 May, 2017 1 commit
-
-
Kushal Pandya authored
-
- 27 Apr, 2017 1 commit
-
-
Douwe Maan authored
-
- 26 Apr, 2017 1 commit
-
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 19 Apr, 2017 1 commit
-
-
Robert Speicher authored
-
- 07 Apr, 2017 2 commits
-
-
Annabel Dunstone Gray authored
-
Bob Van Landuyt authored
-
- 06 Apr, 2017 2 commits
-
-
Jose Ivan Vargas Lopez authored
-
Kamil Trzciński authored
-
- 05 Apr, 2017 1 commit
-
-
Luke "Jared" Bennett authored
-
- 03 Apr, 2017 1 commit
-
-
Annabel Dunstone Gray authored
-
- 25 Mar, 2017 1 commit
-
-
Eric Eastwood authored
Some discussion, https://gitlab.slack.com/archives/C0GQHHPGW/p1490398531185144 -> MR to fix failing emoji test: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10230
-
- 08 Mar, 2017 1 commit
-
-
Jose Ivan Vargas authored
-
- 06 Mar, 2017 1 commit
-
-
Kushal Pandya authored
-
- 04 Mar, 2017 1 commit
-
-
Dmitriy Zaporozhets authored
Project name "Internal" is too generic and can lead to false positive/negative when there is a visibility filter on the page. So we ensure we check for project inside list holder css class. Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 02 Mar, 2017 1 commit
-
-
Kushal Pandya authored
-
- 23 Feb, 2017 1 commit
-
-
Douwe Maan authored
-
- 16 Feb, 2017 1 commit
-
-
Grzegorz Bizon authored
-
- 03 Feb, 2017 1 commit
-
-
Filipa Lacerda authored
Rename Build to Job Replace "Builds" by "Jobs" and fix broken specs Replace "Builds" by "Jobs" Fix broken spinach test Fix broken test Remove `˙` at the beginning of the file Fix broken spinach test Fix broken tests Changes after review
-
- 31 Jan, 2017 1 commit
-
-
Kamil Trzcinski authored
-
- 18 Jan, 2017 1 commit
-
-
Jose Ivan Vargas authored
Added a test for the integrations controller
-
- 17 Jan, 2017 1 commit
-
-
Robert Speicher authored
-
- 26 Dec, 2016 1 commit
-