BigW Consortium Gitlab

  1. 11 Aug, 2016 1 commit
    • Fix bug where destroying a namespace would not always destroy projects · cb8a425b
      Stan Hu authored
      There is a race condition in DestroyGroupService now that projects are deleted asynchronously:
      
      1. User attempts to delete group
      2. DestroyGroupService iterates through all projects and schedules a Sidekiq job to delete each Project
      3. DestroyGroupService destroys the Group, leaving all its projects without a namespace
      4. Projects::DestroyService runs later but the can?(current_user,
         :remove_project) is `false` because the user no longer has permission to
         destroy projects with no namespace.
      5. This leaves the project in pending_delete state with no namespace/group.
      
      Projects without a namespace or group also adds another problem: it's not possible to destroy the container
      registry tags, since container_registry_path_with_namespace is the wrong value.
      
      The fix is to destroy the group asynchronously and to run execute directly on Projects::DestroyService.
      
      Closes #17893
  2. 09 Jun, 2016 1 commit
    • Enable RuboCop for migrations · 98bb435f
      Sean McGivern authored
      Migrations shouldn't fail RuboCop checks - especially lint checks, such
      as the nested method check. To avoid changing code in existing
      migrations, add the magic comment to the top of each of them to skip
      that file.
  3. 21 Jun, 2014 1 commit
  4. 07 Apr, 2014 2 commits