- 18 Aug, 2017 2 commits
-
-
Sean McGivern authored
Guess the modes based on the following: 1. If the file didn't exist, it's zero. 2. If the diff contains 'Subproject commit', it might be a submodule, so 0600. 3. Otherwise, it's 0644. This isn't perfect, but it doesn't have to be - it won't change file modes in the repository.
-
Andrew Newdigate authored
-
- 17 Aug, 2017 5 commits
-
-
Jarka Kadlecova authored
-
Alejandro Rodríguez authored
-
Tiago Botelho authored
Backports EE mirror stuck handling feature (https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2628) to CE
-
Jacob Vosmaer authored
-
Felipe Artur authored
-
- 16 Aug, 2017 1 commit
-
-
Douwe Maan authored
-
- 15 Aug, 2017 7 commits
-
-
Robert Speicher authored
-
Robert Speicher authored
The `Rails` object was not always available in all tasks that require Redis access, such as `mail_room`, so the constant pointing to the configuration path was never defined, but we still attempted to access it in `config_file_name`, resulting in a `NameError` exception. Further, there was no benefit to defining these paths in a constant to begin with -- they're only accessed in one place, and it was within the class where they were being defined. We can just provide them at run-time instead. Further _still_, we were calling `File.expand_path` on the absolute path returned by `Rails.root.join`, which was rather pointless.
-
Robert Speicher authored
-
Nick Thomas authored
-
Jacob Vosmaer authored
-
Z.J. van de Weg authored
Related to !13108. Mostly this is just running the rake task and changing the task a bit to catch cases like the project already existing or so. The rake task moves archives to the vendor/project_template directory, which are checked in too.
-
vanadium23 authored
-
- 14 Aug, 2017 4 commits
-
-
Robert Speicher authored
An upcoming update to rubocop-gitlab-security added additional violations.
-
Alexis Reigel authored
-
Alexis Reigel authored
setting of the gpg home directory is not thread safe, as the directoy gets stored on the class. if multiple threads change the directory at the same time, one of the threads will be working in the wrong directory.
-
Jacob Vosmaer authored
-
- 11 Aug, 2017 5 commits
-
-
Ahmad Sherif authored
-
Bob Van Landuyt authored
Update the markdown unconditionally since the move might have been done before, but the markdown not updated.
-
Robert Speicher authored
Also marks a few things as uncovered, and removes an unused class.
-
Sean McGivern authored
Not all diffs in st_diffs had the too_large attribute set at all, but the column is non-nullable. Explicitly cast to boolean to avoid that problem.
-
Alexis Reigel authored
-
- 10 Aug, 2017 5 commits
-
-
James Edwards-Jones authored
Ensure user and hostnames begin with an alnum character in UrlBlocker See merge request !2138
-
James Edwards-Jones authored
Fix file disclosure via hidden symlinks using the project import (9.3) See merge request !2164
-
Yorick Peterse authored
This changes various controllers to use the new EventCollection class for retrieving events. This class uses a JOIN LATERAL query on PostgreSQL to retrieve queries in a more efficient way, while falling back to a simpler / less efficient query for MySQL. The EventCollection class also includes a limit on the number of events to display to prevent malicious users from cycling through all events, as doing so could put a lot of pressure on the database. JOIN LATERAL is only supported on PostgreSQL starting with version 9.3.0 and as such this optimisation is only used when using PostgreSQL 9.3 or newer.
-
Yorick Peterse authored
This commit migrates events data in such a way that push events are stored much more efficiently. This is done by creating a shadow table called "events_for_migration", and a table called "push_event_payloads" which is used for storing push data of push events. The background migration in this commit will copy events from the "events" table into the "events_for_migration" table, push events in will also have a row created in "push_event_payloads". This approach allows us to reclaim space in the next release by simply swapping the "events" and "events_for_migration" tables, then dropping the old events (now "events_for_migration") table. The new table structure is also optimised for storage space, and does not include the unused "title" column nor the "data" column (since this data is moved to "push_event_payloads"). == Newly Created Events Newly created events are inserted into both "events" and "events_for_migration", both using the exact same primary key value. The table "push_event_payloads" in turn has a foreign key to the _shadow_ table. This removes the need for recreating and validating the foreign key after swapping the tables. Since the shadow table also has a foreign key to "projects.id" we also don't have to worry about orphaned rows. This approach however does require some additional storage as we're duplicating a portion of the events data for at least 1 release. The exact amount is hard to estimate, but for GitLab.com this is expected to be between 10 and 20 GB at most. The background migration in this commit deliberately does _not_ update the "events" table as doing so would put a lot of pressure on PostgreSQL's auto vacuuming system. == Supporting Both Old And New Events Application code has also been adjusted to support push events using both the old and new data formats. This is done by creating a PushEvent class which extends the regular Event class. Using Rails' Single Table Inheritance system we can ensure the right class is used for the right data, which in this case is based on the value of `events.action`. To support displaying old and new data at the same time the PushEvent class re-defines a few methods of the Event class, falling back to their original implementations for push events in the old format. Once all existing events have been migrated the various push event related methods can be removed from the Event model, and the calls to `super` can be removed from the methods in the PushEvent model. The UI and event atom feed have also been slightly changed to better handle this new setup, fortunately only a few changes were necessary to make this work. == API Changes The API only displays push data of events in the new format. Supporting both formats in the API is a bit more difficult compared to the UI. Since the old push data was not really well documented (apart from one example that used an incorrect "action" nmae) I decided that supporting both was not worth the effort, especially since events will be migrated in a few days _and_ new events are created in the correct format.
-
Kim "BKC" Carlbäcker authored
-
- 09 Aug, 2017 4 commits
-
-
Jacob Vosmaer authored
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Jacob Vosmaer authored
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 08 Aug, 2017 5 commits
-
-
Brian Neel authored
-
Lin Jen-Shin authored
It is recommended that we set this to 50: https://gitlab.com/gitlab-org/gitlab-ce/issues/35098#note_35036746 In this particular issue, the confidence was 42 for Shift JIS, but in fact that's encoded in UTF-8 just with a single bad character. In this case, we shouldn't try to treat it as Shift JIS, but just treat it as UTF-8 and remove invalid bytes. Treating it like Shift JIS would corrupt the whole data. Unfortunately, the diff which would cause this could not be disclosed therefore we can't use it as a test example.
-
Alejandro Rodríguez authored
-
Alejandro Rodríguez authored
This helps keep the abstraction layers simpler, and also keep the interface of those methods consistent, in case of implementation changes.
-
Alejandro Rodríguez authored
-
- 07 Aug, 2017 2 commits
-
-
Oswaldo Ferreira authored
-