- 13 May, 2016 3 commits
-
-
James Lopez authored
-
James Lopez authored
-
James Lopez authored
-
- 12 May, 2016 5 commits
-
-
James Lopez authored
-
James Lopez authored
-
James Lopez authored
-
James Lopez authored
-
James Lopez authored
-
- 11 May, 2016 3 commits
-
-
James Lopez authored
-
James Lopez authored
-
James Lopez authored
-
- 10 May, 2016 2 commits
-
-
James Lopez authored
added better error handling. Also refactored some of the code and fixed a few issues in project_tree_saver
-
James Lopez authored
-
- 09 May, 2016 7 commits
-
-
James Lopez authored
-
James Lopez authored
-
James Lopez authored
-
James Lopez authored
-
James Lopez authored
-
James Lopez authored
-
Stan Hu authored
If you attempt to push thousands of branches at once, the 60-second timeout will occur because GitAccess checking does a lot of work to check if the user has permission to push to a branch. This changes does two things: 1. Instead of making 1 DB query per branch push, use a memoized list of protected branches to check 2. Memoize what permissions the user has to perform on this project On a test of 10,000 branch pushes, this prevents gitlab-shell from hitting the 60-second timeout. Closes #17225
-
- 07 May, 2016 1 commit
-
-
Stan Hu authored
Use a custom Loofah scrubber since sanitize 2.x transformers are inadequate to handle case-sensitive SVG attributes. sanitize parses documents as HTML instead of XML, which causes all SVG attribute names (e.g. viewBox) to be downcased. * SVG element list: https://www.w3.org/TR/SVG/eltindex.html * SVG attribute list: https://www.w3.org/TR/SVG/attindex.html Closes #14555
-
- 06 May, 2016 5 commits
-
-
James Lopez authored
-
James Lopez authored
-
James Lopez authored
-
James Lopez authored
-
Zeger-Jan van de Weg authored
[ci skip]
-
- 05 May, 2016 11 commits
-
-
Yorick Peterse authored
Previously this method would directly receive the output of tag_name(). This method could either return a String or nil. In the previous setup this would somehow magically work but because Rugged::TagCollection#[] doesn't accept nil values it started to fail. To work around this the elsif in change_access_check() assigns the result of tag_name() to a local and then _only_ calls protected_tag?() if the tag name is not nil. The extra parenthesis are put in place to ensure that things are parsed correctly, without these the code would be parsed as follows: elsif tag_ref = (tag_name(ref) && protected_tag(tag_ref)) During runtime this would basically resolve to: elsif tag_ref = (tag_name(ref) && protected_tag(nil)) This is because when you refer to the variable you're assigning _in_ the assignment Ruby returns nil instead of raising an error.
-
Yorick Peterse authored
This removes the need for retrieving the entire list of tags just to check if a specific one exists.
-
James Lopez authored
-
Douglas Barbosa Alexandre authored
Pull Request Review Comments are comments on a portion of the unified diff.
-
James Lopez authored
-
James Lopez authored
-
James Lopez authored
-
James Lopez authored
-
James Lopez authored
-
James Lopez authored
-
James Lopez authored
-
- 04 May, 2016 3 commits
-
-
James Lopez authored
refactored some namespace stuff and fixed project tree restorer spec. also removing controller so that it belongs to the UI MR
-
Rémy Coutable authored
Use Rugged's TagCollection#create instead of gitlab-shell's Repository#add_tag for better performance Signed-off-by: Rémy Coutable <remy@rymai.me>
-
James Lopez authored
-