BigW Consortium Gitlab

  1. 14 Jan, 2017 1 commit
  2. 16 Dec, 2016 11 commits
    • Add GitLab host to 2FA QR and manual info · 55f224e4
      Drew Blessing authored
      The two factor authentication account string only had the user's
      email address. This led to ambiguous entries in two factor
      code generating apps. This adds the GitLab host to the account
      string in the standard format (according to Google). No matter
      the code generator this change disambiguates the entry.
    • Pass variables from deployment project services to CI runner · c945a0a7
      Adam Niedzielski authored
      This commit introduces the concept of deployment variables - variables
      that are collected from deployment services and passed to CI runner
      during a deployment build.
      Deployment services specify the variables by overriding
      "predefined_variables" method.
      
      This commit also configures variables for KubernetesService
    • Convert AccessTokenValidationService into a class. · b303948f
      Timothy Andrew authored
      - Previously, AccessTokenValidationService was a module, and all its  public
      methods accepted a token. It makes sense to convert it to a class which accepts
      a token during initialization.
      
      - Also rename the `sufficient_scope?` method to `include_any_scope?`
      
      - Based on feedback from @rymai
    • View-related (and other minor) changes to !5951 based on @rymai's review. · f706a973
      Timothy Andrew authored
      - The `scopes_form` partial can be used in the `admin/applications` view
        as well
      
      - Don't allow partials to access instance variables directly. Instead, pass
        in the instance variables as local variables, and use `local_assigns.fetch`
        to assert that the variables are passed in as expected.
      
      - Change a few instances of `render :partial` to `render`
      
      - Remove an instance of `required: false` in a view, since this is the default
      
      - Inline many instances of a local variable (`ip = 'ip'`) in `auth_spec`
    • Move the scopes form/list view into a partial. · 990ae6b8
      Timothy Andrew authored
      - The list of scopes that's displayed while creating a personal access
        token is identical to the list that's displayed while creating an OAuth
        application. Extract these into a partial.
      
      - The list of scopes that's displayed while in the show page for an OAuth token
        in the profile settings and admin settings are identical. Extract these into
        a partial.
    • Implement minor changes from @dbalexandre's review. · 4d6da770
      Timothy Andrew authored
      - Mainly whitespace changes.
      
      - Require the migration adding the `scope` column to the
        `personal_access_tokens` table to have downtime, since API calls will
        fail if the new code is in place, but the migration hasn't run.
      
      - Minor refactoring - load `@scopes` in a `before_action`, since we're
        doing it in three different places.
    • Calls to the API are checked for scope. · 7fa06ed5
      Timothy Andrew authored
      - Move the `Oauth2::AccessTokenValidationService` class to
        `AccessTokenValidationService`, since it is now being used for
        personal access token validation as well.
      
      - Each API endpoint declares the scopes it accepts (if any). Currently,
        the top level API module declares the `api` scope, and the `Users` API
        module declares the `read_user` scope (for GET requests).
      
      - Move the `find_user_by_private_token` from the API `Helpers` module to
        the `APIGuard` module, to avoid littering `Helpers` with more
        auth-related methods to support `find_user_by_private_token`
    • Ensure issuable state changes only fire webhooks once · 9f97fa4d
      Mark Fletcher authored
      * Webhooks for close and reopen events now fired in respective services only
      * Prevents generic 'update' webhooks firing too
  3. 15 Dec, 2016 20 commits
  4. 14 Dec, 2016 8 commits