BigW Consortium Gitlab

  1. 28 Nov, 2016 3 commits
  2. 25 Nov, 2016 5 commits
    • Clean up rubocop complaint · c0931722
      hhoopes authored
    • Add keyword arguments to truncated_diff method · a761c59a
      hhoopes authored
      * Added keyword arguments to truncated_diff_lines method to allow for using highlighting or not (html templates vs. text)
      * Tweaked templates for consistency and format appropriateness
    • Change diff highlight/truncate for reusability · f928dba9
      hhoopes authored
      Previously the `truncated_diff_lines` method for outputting a discussion diff took in already highlighted lines, which meant it wasn't reuseable for truncating ANY lines. In the way it was used, it also meant that for any email truncation, the whole diff was being highlighted before being truncated, meaning wasted time highlighting lines that wouldn't even be used (granted, they were being memoized, so perhaps this wasn't that great of an issue). I refactored truncation away from highlighting, in order to truncate formatted diffs for text templates in email, using `>`s to designate each line, but otherwise retaining the parsing already done to create `diff_lines`.
      
      Additionally, while notes on merge requests or commits had already been tested, there was no existing test for notes on a diff on an MR or commit. Added mailer tests for such, and a unit test for truncating diff lines.
    • Add new template to handle both commit & mr notes · 24070bac
      hhoopes authored
      Currently comments on commits and merge requests do not require merge request- or commit-specific information, but can use the same template. Rather than change the method which calls the template, I opted to keep the templates separate and create a new template to highlight their identicality, while preserving the option to distinguish them from each other in the future.
      
      Also removed some of the inconsistencies between text and html email versions.
      
      Still needed is a text-only version of git diffs and testing.
    • Add diff hunks to notification emails on MR · 38ed96e9
      hhoopes authored
      Added diff hunks to notification emails of messages on merge requests. This
      provides code context to the note. Uses existing template for formatting
      a diff for email (from repository push notifications).
  3. 18 Nov, 2016 1 commit
    • Use `Gitlab.config.gitlab.host` over `'localhost'` · 9c4e0d64
      Lin Jen-Shin authored
      This would fix long standing failures running tests on
      my development machine, which set `Gitlab.config.gitlab.host`
      to another host because it's not my local computer. Now I
      finally cannot withstand it and decided to fix them once and
      for all.
  4. 11 Nov, 2016 1 commit
  5. 22 Oct, 2016 1 commit
  6. 17 Oct, 2016 1 commit
  7. 11 Oct, 2016 1 commit
  8. 03 Oct, 2016 7 commits
  9. 28 Sep, 2016 1 commit
    • Allow Member.add_user to handle access requesters · ec0061a9
      Rémy Coutable authored
      Changes include:
      
      - Ensure Member.add_user is not called directly when not necessary
      - New GroupMember.add_users_to_group to have the same abstraction level as for Project
      - Refactor Member.add_user to take a source instead of an array of members
      - Fix Rubocop offenses
      - Always use Project#add_user instead of project.team.add_user
      - Factorize users addition as members in Member.add_users_to_source
      - Make access_level a keyword argument in GroupMember.add_users_to_group and ProjectMember.add_users_to_projects
      - Destroy any requester before adding them as a member
      - Improve the way we handle access requesters in Member.add_user
        Instead of removing the requester and creating a new member,
        we now simply accepts their access request. This way, they will
        receive a "access request granted" email.
      - Fix error that was previously silently ignored
      - Stop raising when access level is invalid in Member, let Rails validation do their work
      Signed-off-by: 's avatarRémy Coutable <remy@rymai.me>
  10. 26 Sep, 2016 1 commit
  11. 22 Sep, 2016 1 commit
  12. 20 Sep, 2016 1 commit
  13. 12 Aug, 2016 1 commit
  14. 09 Aug, 2016 1 commit
  15. 03 Aug, 2016 1 commit
  16. 02 Aug, 2016 1 commit
  17. 22 Jul, 2016 1 commit
  18. 06 Jul, 2016 1 commit
  19. 01 Jul, 2016 2 commits
  20. 20 Jun, 2016 1 commit
  21. 17 Jun, 2016 1 commit
  22. 16 Jun, 2016 2 commits
  23. 14 Jun, 2016 3 commits
  24. 03 Jun, 2016 1 commit