BigW Consortium Gitlab

  1. 09 Jun, 2016 28 commits
    • Fixed tests · 7c88141b
      Phil Hughes authored
    • CHANGELOG · be7b67d2
      Phil Hughes authored
    • Improved the UX of issue & milestone date picker · cc971f03
      Phil Hughes authored
      Closes #18198
    • Merge branch 'note-edit-background-color' into 'master' · 787b73f5
      Jacob Schatz authored
      Edit form background color on highlighted note
      
      ## What does this MR do?
      
      Added white background to edit form when in a highlighted note
      
      ## What are the relevant issue numbers?
      
      Closes #18101 
      
      ## Screenshots (if relevant)
      
      ![Screen_Shot_2016-06-02_at_11.24.20](/uploads/c7c7fe710aa74d86152a109560fd0ebe/Screen_Shot_2016-06-02_at_11.24.20.png)
      
      See merge request !4435
    • Merge branch 'toggling-task-should-not-generate-todo' into 'master' · a458211b
      Robert Speicher authored
      Toggling a task in a description with mentions doesn't creates a Todo
      
      When user toggle a task list item in a description with a mention it
      does not create an unnecessary Todo for that mention.
      
      Closes #14116
      
      See merge request !4568
    • Merge branch 'button-focus-state' into 'master' · d64517c3
      Jacob Schatz authored
      Blur button tags when pressed to remove the focus state.
      
      ## Before 
      
      ![pemnD5exKl](/uploads/333155bf4a6c43715f3fc04d8f5aa35e/pemnD5exKl.gif)
      
      
      ## After
      
      ![dCPvSwsuWp](/uploads/9bcfbe59ac8de51e9d2c3edcb3d13ff3/dCPvSwsuWp.gif)
      
      See merge request !4418
    • Merge branch 'labels-ui-fix' into 'master' · d7e8adea
      Jacob Schatz authored
      Updated labels UI
      
      - Fixed alignment issues
      - Added dropdown to mobile to make the options look nicer & to save space
      
      ![Screen_Shot_2016-05-25_at_09.42.46](/uploads/ff59abd2310725965b388a62c6c1f2af/Screen_Shot_2016-05-25_at_09.42.46.png)
      
      Closes #14227
      
      See merge request !4273
    • Update CHANGELOG · 0098468d
      Douglas Barbosa Alexandre authored
    • Merge branch '17562-filter-issues-is-only-visible-when-user-is-logged-in' into 'master' · ae126c55
      Jacob Schatz authored
      #17562 Fixes issues list filter only visible when user is logged in
      
      ## What does this MR do?
      
      1. Moves the issue/MR list search form out of the `if current_user` conditional, allowing guests to view the field.
      
      2.  Adds some margin to the search form, this is because in mobile view for guest users, the field was not supported by the RSS button and the New Issue button and would drop to meet the list.
      
      ## Are there points in the code the reviewer needs to double check?
      
      Are there any views where the `margin-bottom: 12px` will affect the styling?
      
      ## Why was this MR needed?
      
      Guest user UX. Nothing feels better than increasing intangible value!
      
      ## What are the relevant issue numbers?
      
      Fixes #17562.
      
      ## Screenshots (if relevant)
      
      ![Screen_Shot_2016-05-16_at_23.48.06](/uploads/cf0f0c48287517ac3e83b204b4ee09b2/Screen_Shot_2016-05-16_at_23.48.06.png)
      
      /cc @jschatz1 
      
      **UPDATE:**
      
      ![Screen_Shot_2016-05-20_at_16.13.22](/uploads/eb854838a514d0d54d0f13bde1636b8a/Screen_Shot_2016-05-20_at_16.13.22.png)
      
      See merge request !4171
    • Merge branch 'rs-fix-ldap-2fa-login' into 'master' · 8138f340
      Robert Speicher authored
      Fix 2FA-based login for LDAP users
      
      The OTP input form is shared by both LDAP and standard logins, but when
      coming from an LDAP-based form, the form parameters aren't nested in a
      Hash based on the `resource_name` value.
      
      Now we check for a nested `remember_me` parameter and use that if it
      exists, or fall back to the non-nested parameters if it doesn't.
      
      Somewhat confusingly, the OTP input form _does_ nest parameters under
      the `resource_name`, regardless of what type of login we're coming from,
      so that allows everything else to work as normal.
      
      Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/18185
      
      See merge request !4493
    • Merge branch 'fix-changelog' into 'master' · 95de1c1a
      Jacob Schatz authored
      Update CHANGELOG
      
      Fixes wrong changelog entry for !4175
      
      See merge request !4548
    • Update CHANGELOG · cda68e92
      Alfredo Sumaran authored
    • Fixed failing label subscribe test · b0a80f69
      Phil Hughes authored
    • Tests update · 8e8ec82d
      Phil Hughes authored
    • Updated subscribe icon · 9830f9a2
      Phil Hughes authored
    • Fixed failing tests · 051dc1d2
      Phil Hughes authored
    • Updated labels UI · e7ca709a
      Phil Hughes authored
      Closes #14227
    • Merge branch 'fix-git-http-routing' into 'master' · 3803b380
      Douwe Maan authored
      Ensure only IDs ending in .git perform git actions
      
      ## What does this MR do?
      
      Rails's routing is pretty strange. Previously, `GET /namespace/project/info/refs` would go to the Git HTTP controller (if the redirect for that case was taken out).
      
      ## Are there points in the code the reviewer needs to double check?
      
      The specs fail if the redirect is moved to above the Git HTTP routes, removed altogether, or the Git HTTP constraints are changed. But there might still be missing cases.
      
      ## Why was this MR needed?
      
      The master build and HTTP cloning were both broken.
      
      ## What are the relevant issue numbers?
      
      Closes #18376.
      
      ## Screenshots (if relevant)
      
      Nope.
      
      ## Does this MR meet the acceptance criteria?
      
      - [x] [not needed] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
      - [x] [not needed] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
      - [ ] (not needed) API support added
      - [ ] Tests
        - [x] Added for this feature/bug
        - [ ] All builds are passing
      - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
      - [ ] Branch has no merge conflicts with `master` (if you do - rebase it please)
      - [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
      
      See merge request !4558
    • Add test for getting info/refs from repo · bf63964b
      Sean McGivern authored
    • Ensure only IDs ending in .git perform git actions · df5fb28a
      Sean McGivern authored
      It doesn't seem possible to set constraints based on format for project
      IDs ending in .git, so set the constraint on the ID and ensure the
      format is nil to avoid the case where the project ID is something like
      project.git.foo.
    • Merge branch 'saml-ldap-link-flow' into 'master' · 30ee4ea6
      Douwe Maan authored
      Adjust the SAML control flow to allow LDAP identities to be added to an existing SAML user.
      
      ## What does this MR do?
      
      It correctly lets an existing SAML user to add their LDAP identity automatically at login.
      
      ## Why was this MR needed?
      
      A customer had issues with the `auto_link_ldap_user` feature. The flow was not working if there was an account with a SAML identity, but no LDAP identity. GitLab would pick up the correct LDAP person, but due to the order of the flow, that LDAP person was never associated with the user.
      
      ## What are the relevant issue numbers?
      
      Fixes #17346 
      
      /cc @dblessing @balameb @stanhu 
      
      See merge request !4498
    • Merge branch 'make-omniauth-tests-to-not-modify-global-state' into 'master' · 1e4db9ed
      Yorick Peterse authored
      Make Omniauth providers specs to not modify global configuration
      
      See merge request !4534
    • Merge branch '18019-fix-wiki-linking' into 'master' · 3d72cb89
      Rémy Coutable authored
      Fix wiki linking behavior for markdown wiki pages
      
      Related to #18019 
      
      - As per the documentation in !4372 
      
      ## TODO
      - [ ] !4432 Have wiki linking behave as per the documentation
          - [x] Move `WikiLinkFilter` specs to the pipeline level
          - [x] Verify current behavior on wiki `show` page
          - [x] Fix current behavior on wiki `show` page
          - [x] Verify current behaviour on wiki preview
          - [x] Fix current behaviour on wiki preview
              - [x] Rewrite all links and get preview links working
              - [x] Make sure all links are on-par with the wiki `show` page
              - [x] TDD `WikiLinkFilter` and get it working
              - [x] Hook `WikiLinkFilter` up
          - [x] Fix tests 
              - [x] Fix `markdown_spec`
              - [x] Fix `wiki` spinach feature
              - [x] Wait for [build](https://gitlab.com/gitlab-org/gitlab-ce/commit/4f50dd2/builds) to pass
              - [x] Make sure all wiki-related pages are working as expected (history, all pages, etc.)
          - [x] Test in different ruby versions
          - [x] GitLab instances hosted on a relative URL
          - [x] Non-markdown rendering formats?
              - [x] RDoc
              - [x] ASCIIDoc
              - [x] Create issues to fix things for RDoc and ASCIIDoc
          - [x] Gauge performance impact
          - [x] Refactor
          - [x] Re-organize commits
          - [x] Make sure [build](https://gitlab.com/gitlab-org/gitlab-ce/commit/f860e9a8dcabe7d5f160c32fc549807c98baa4a1/builds) passes
          - [x] Respond to @rymai's comments
              - [x] `class WikiLinkFilter < HTML::Pipeline::Filter`
              - [x] blank line after guard clause
              - [x] keyword arguments for `wiki` and `slug`
              - [x] invert the condition
              - [x] inline `user` in spec
              - [x] Make sure spec names are not out of date
              - [x] Comment for each rewrite rule
          - [x] Add CHANGELOG entry
          - [x] Reorganize commits
          - [x] Make sure [build](https://gitlab.com/gitlab-org/gitlab-ce/commit/19b91e749a6320d12fb299d33f1f6440777e0e26/builds) passes
          - [ ] Wait for merge
      
      See merge request !4432
    • Add #18019 to the CHANGELOG. · 19b91e74
      Timothy Andrew authored
    • Hook up the updated `WikiLinkFilter` to the wiki controllers. · e6b1d166
      Timothy Andrew authored
      - Need to pass in a `page_slug` to the filter, so it can rewrite based
        on the current page (all links are rewritten to the level of the app root).
      - The earlier `markdown_preview` endpoint was at the level of the wiki.
        We need to know the current page (for rewriting, as above), so this
        commit moves the endpoint to the level of a wiki page.
      - Fix all tests
    • Implement the correct linking behaviour in `WikiLinkFilter`. · 8e71c19a
      Timothy Andrew authored
      Original Comments
      =================
      
      - Linking behaves as per rules documented here:
        https://gitlab.com/gitlab-org/gitlab-ce/blob/16568-document-wiki-linking-behavior/doc/markdown/wiki.md
      - All links (to other wiki pages) are rewritten to be at the level of
        the app root. We can't use links relative to the current
        page ('./foo', 'foo', '../foo'), because they won't work in the
        markdown preview, where the current page is suffixed with `/edit`
      - Move existing `WikiLinkFilter` specs to `WikiPipeline` spec. It makes
        sense to run these tests on the combined output of the pipeline,
        rather than a single filter, since we can catch issues with
        conflicting filters.
      - Add more tests to cover the new linking
      
      @rymai's Review
      ===============
      
      - Classes nested under `WikiLinkFilter` should declare `WikiLinkFilter`'s
        inherit, so nothing changes if the nested class is loaded first.
      - Add a blank line after a guard clause
      - Use keyword arguments for the `Rewriter` constructor
      - Invert a condition - use `if` instead of `unless`
      - Inline a `let` in `WikiPipeline` spec - it was only used in a single place
      - Change out of date spec names
      - Add a comment for every rewrite rule in `Rewriter`
    • Merge branch 'fix-award-emoji-hidden' into 'master' · 13fd88fa
      Jacob Schatz authored
      Shows award emoji for comments to all users who are logged in.
      
      ## What does this MR do?
      Fixes the award emoji picker not showing up for users who weren't able to edit another user's comment.
      
      ## Screenshots (if relevant)
      Before:
      
      ![Screen_Shot_2016-06-08_at_5.18.04_PM](/uploads/a8b40ba319481f53d55de055d84649b9/Screen_Shot_2016-06-08_at_5.18.04_PM.png)
      
      After (logged in):
      ![Screen_Shot_2016-06-08_at_5.16.16_PM](/uploads/535edcca6fbdd8834beda39399f85384/Screen_Shot_2016-06-08_at_5.16.16_PM.png)
      
      After (logged out):
      ![Screen_Shot_2016-06-08_at_5.15.08_PM](/uploads/7f0dff751714c7d20f78b56893cacd59/Screen_Shot_2016-06-08_at_5.15.08_PM.png)
      
      cc: @fatihacet 
      
      See merge request !4547
  2. 08 Jun, 2016 12 commits
    • Merge branch 'mention-loading-indicator' into 'master' · f5818baf
      Jacob Schatz authored
      Show loading indicator for autocomplete
      
      ![autocomplete](/uploads/397df34689aeb5f4cbca99aea209c8cf/autocomplete.gif)
      
      Closes #15435
      
      See merge request !4182
    • Merge branch '17284-Edit-form-does-not-cancel-correctly' into 'master' · e382f130
      Jacob Schatz authored
      #17284 Edit form does not cancel correctly
      
      ## What does this MR do?
      
      Replaces the markdown textarea with the currently saved note text when the note edit is cancelled.
      
      ## Are there points in the code the reviewer needs to double check?
      
      No
      
      ## Why was this MR needed?
      
      Allows the user to revert back to the original note text, as expected, using cancel.
      
      ## What are the relevant issue numbers?
      
      Fixes #17284.
      
      ## Screenshots
      
      ![17284](/uploads/c3598de6f8e70d52275ef25907d92d42/17284.gif)
      
      See merge request !4175
    • Merge branch 'nav-scroll-bug' into 'master' · cc54b74a
      Jacob Schatz authored
      Side nav scrolls if content height taller than screen
      
      ## What does this MR do?
      Header logo is now fixed at top; put back scrolling functionality in side nav
      
      ## Screenshots (if relevant)
      <img src="/uploads/e1d1b60c296c39c61d7fe7da22b6c52d/scroll.gif" width="600px">
      
      See merge request !4513
    • Merge branch 'git-http-no-authenticity-token' into 'master' · 5d66e0e0
      Robert Speicher authored
      Disable CSRF protection when serving Git HTTP clients
      
      Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/18331
      
      See merge request !4538
    • Merge branch '17240-svg' into 'master' · 0001a0cf
      Jacob Schatz authored
      Add new icons in left sidebar and layout nav
      
      Closes #17609    
      Closes #17240    
      Closes #17321    
      
      ![Screen_Shot_2016-06-02_at_8.47.38_AM](/uploads/f254fe81cba65cbdeb8e5720f0b2fc19/Screen_Shot_2016-06-02_at_8.47.38_AM.png)
      ![Screen_Shot_2016-06-02_at_8.53.33_AM](/uploads/2c27284f0a4916fe447794d9b663c4df/Screen_Shot_2016-06-02_at_8.53.33_AM.png)
      
      @skyruler I couldn't find the icons for `Projects`, `Merge Requests`, `Snippets`, or `Help` in the design repo. Do you have them available somewhere?
      
      See merge request !4268
    • Merge branch '18333-layout-bug' into 'master' · 8578f401
      Jacob Schatz authored
      Use container helper instead of hard coded container
      
      ## What does this MR do?
      Add `container_class` helper class to fix layout bug
      
      ## What are the relevant issue numbers?
      #18333 
      ## Screenshots (if relevant)
      Fixed:    
      ![Screen_Shot_2016-06-08_at_2.03.38_PM](/uploads/6e7575d711efb8eaf6ba641907b2d607/Screen_Shot_2016-06-08_at_2.03.38_PM.png)
      Fluid:     
      ![Screen_Shot_2016-06-08_at_2.03.56_PM](/uploads/33d3f73781ca9ed129f853abfe9feb4b/Screen_Shot_2016-06-08_at_2.03.56_PM.png)
      
      See merge request !4543
    • Fix activity SVG · a280116a
      Annabel Dunstone authored
    • Merge branch 'dropdown-link-lineheight' into 'master' · b4812e2e
      Jacob Schatz authored
      Fixed dropdown link line-height
      
      ## What does this MR do?
      
      Fixes line-height issue on dropdown menu links
      
      ## Why was this MR needed?
      
      The line-height of some dropdown links were taking the parent, most noticeable the commit header
      
      ## Screenshots (if relevant)
      
      Before:
      
      ![Screen_Shot_2016-06-08_at_12.26.13](/uploads/51d6bbb4d727da0e3f27d715d6556d4f/Screen_Shot_2016-06-08_at_12.26.13.png)
      
      After:
      
      ![Screen_Shot_2016-06-08_at_12.25.03](/uploads/2dcbfaa67982500eef42cfe4247cd54d/Screen_Shot_2016-06-08_at_12.25.03.png)
      
      See merge request !4531
    • Merge branch 'dz-improve-ui-consistency' into 'master' · 2268c6c7
      Jacob Schatz authored
      Improve ui consistency
      
      * Decline idea of using gray buttons actively in UI
      * remove icons from some buttons that already has text
      * standardizes margin between buttons 
      
      
      First step in https://gitlab.com/gitlab-org/gitlab-ce/issues/18324 
      
      See merge request !4533
    • Merge branch '14098-customize-after-sign-up-path' into 'master' · 18f5cca2
      Robert Speicher authored
      Allow custom text on 'almost there' page
      
      Add a new application setting, after_sign_up_text. This is text to be
      rendered as Markdown and shown on the 'almost there' page after a user
      signs up, but before they've confirmed their account.
      
      Closes #14098.
      
      See merge request !4098