- 27 Jan, 2017 1 commit
-
-
Nick Thomas authored
-
- 25 Jan, 2017 1 commit
-
-
Yorick Peterse authored
There were two cases that could be problematic: 1. Because sometimes AuthorizedProjectsWorker would be scheduled in a transaction it was possible for a job to run/complete before a COMMIT; resulting in it either producing an error, or producing no new data. 2. When scheduling jobs the code would not wait until completion. This could lead to a user creating a project and then immediately trying to push to it. Usually this will work fine, but given enough load it might take a few seconds before a user has access. The first one is problematic, the second one is mostly just annoying (but annoying enough to warrant a solution). This commit changes two things to deal with this: 1. Sidekiq scheduling now takes places after a COMMIT, this is ensured by scheduling using Rails' after_commit hook instead of doing so in an arbitrary method. 2. When scheduling jobs the calling thread now waits for all jobs to complete. Solution 2 requires tracking of job completions. Sidekiq provides a way to find a job by its ID, but this involves scanning over the entire queue; something that is very in-efficient for large queues. As such a more efficient solution is necessary. There are two main Gems that can do this in a more efficient manner: * sidekiq-status * sidekiq_status No, this is not a joke. Both Gems do a similar thing (but slightly different), and the only difference in their name is a dash vs an underscore. Both Gems however provide far more than just checking if a job has been completed, and both have their problems. sidekiq-status does not appear to be actively maintained, with the last release being in 2015. It also has some issues during testing as API calls are not stubbed in any way. sidekiq_status on the other hand does not appear to be very popular, and introduces a similar amount of code. Because of this I opted to write a simple home grown solution. After all, all we need is storing a job ID somewhere so we can efficiently look it up; we don't need extra web UIs (as provided by sidekiq-status) or complex APIs to update progress, etc. This is where Gitlab::SidekiqStatus comes in handy. This namespace contains some code used for tracking, removing, and looking up job IDs; all without having to scan over an entire queue. Data is removed explicitly, but also expires automatically just in case. Using this API we can now schedule jobs in a fork-join like manner: we schedule the jobs in Sidekiq, process them in parallel, then wait for completion. By using Sidekiq we can leverage all the benefits such as being able to scale across multiple cores and hosts, retrying failed jobs, etc. The one downside is that we need to make sure we can deal with unexpected increases in job processing timings. To deal with this the class Gitlab::JobWaiter (used for waiting for jobs to complete) will only wait a number of seconds (30 by default). Once this timeout is reached it will simply return. For GitLab.com almost all AuthorizedProjectWorker jobs complete in seconds, only very rarely do we spike to job timings of around a minute. These in turn seem to be the result of external factors (e.g. deploys), in which case a user is most likely not able to use the system anyway. In short, this new solution should ensure that jobs are processed properly and that in almost all cases a user has access to their resources whenever they need to have access.
-
- 23 Jan, 2017 1 commit
-
-
Grzegorz Bizon authored
This reverts commit c2093486, reversing changes made to 4b7ec44b.
-
- 21 Jan, 2017 1 commit
-
-
Grzegorz Bizon authored
This reverts merge request !8573
-
- 15 Jan, 2017 1 commit
-
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 01 Dec, 2016 2 commits
-
-
Yorick Peterse authored
By passing commit data to this worker we remove the need for querying the Git repository for every job. This in turn reduces the time spent processing each job. The migration included migrates jobs from the old format to the new format. For this to work properly it requires downtime as otherwise workers may start producing errors until they're using a newer version of the worker code.
-
Robert Speicher authored
-
- 09 Nov, 2016 1 commit
-
-
Grzegorz Bizon authored
-
- 08 Nov, 2016 1 commit
-
-
Valery Sizov authored
-
- 28 Oct, 2016 1 commit
-
-
winniehell authored
-
- 25 Oct, 2016 1 commit
-
-
Yorick Peterse authored
This changes ProjectCacheWorker.perform_async so it only schedules a job when no lease for the given project is present. This ensures we don't end up scheduling hundreds of jobs when they won't be executed anyway.
-
- 12 Oct, 2016 1 commit
-
-
Yorick Peterse authored
This reverts merge request !6730
-
- 06 Oct, 2016 1 commit
-
-
Nick Thomas authored
-
- 28 Sep, 2016 1 commit
-
-
Connor Shea authored
This fixes an issue with Rails 5 and brings us up-to-date with the latest Devise release. This also replaces the deprecated Devise::TestHelpers with Devise::Test::ControllerHelpers. Changelog: https://github.com/plataformatec/devise/blob/v4.2.0/CHANGELOG.md#420---2016-07-01
-
- 19 Aug, 2016 1 commit
-
- 09 Aug, 2016 1 commit
-
-
Stan Hu authored
This is in preparation to address the DB load caused by the counting in gitlab-com/infrastructure#303.
-
- 21 Jul, 2016 5 commits
-
-
Grzegorz Bizon authored
-
Kamil Trzcinski authored
-
Kamil Trzcinski authored
-
Kamil Trzcinski authored
-
Kamil Trzcinski authored
-
- 12 Jul, 2016 2 commits
-
-
Lin Jen-Shin authored
It turns out they are different: builds.success.latest.first and builds.latest.success.first If we put success first, that latest would also filter via success, and which is what we want here.
-
Lin Jen-Shin authored
-
- 07 Jul, 2016 2 commits
-
-
Patricio Cano authored
-
Patricio Cano authored
-
- 04 Jul, 2016 1 commit
-
-
Patricio Cano authored
-
- 30 Jun, 2016 1 commit
-
-
Z.J. van de Weg authored
-
- 08 Jun, 2016 1 commit
-
-
Kamil Trzcinski authored
-
- 07 Jun, 2016 1 commit
-
-
Kamil Trzcinski authored
-
- 03 Jun, 2016 3 commits
-
-
Kamil Trzcinski authored
-
Kamil Trzcinski authored
-
Kamil Trzcinski authored
-
- 16 May, 2016 1 commit
-
-
James Lopez authored
-
- 05 May, 2016 1 commit
-
-
James Lopez authored
-
- 04 May, 2016 1 commit
-
-
James Lopez authored
refactored some namespace stuff and fixed project tree restorer spec. also removing controller so that it belongs to the UI MR
-
- 01 May, 2016 1 commit
-
-
Connor Shea authored
This allows the removal of the monkey patch from this commit: 47ff1c56 It'll also make it slightly easier to upgrade to 3.5.0 later. Changelog: https://github.com/rspec/rspec-rails/blob/master/Changelog.md#340--2015-11-11
-
- 30 Mar, 2016 1 commit
-
-
Grzegorz Bizon authored
-
- 29 Mar, 2016 1 commit
-
-
Grzegorz Bizon authored
-
- 15 Mar, 2016 1 commit
-
-
Timothy Andrew authored
1. Allow subscribing (the current user) to a label - Refactor the `Subscription` coffeescript class - The main change is that it accepts a container, and conducts all DOM queries within its scope. We need this because the labels page has multiple instances of `Subscription` on the same page. 2. Creating an issue or MR with labels notifies users subscribed to those labels - Label `has_many` subscribers through subscriptions. 3. Adding a label to an issue or MR notifies users subscribed to those labels - This only applies to subscribers of the label that has just been added, not all labels for the issue.
-
- 10 Mar, 2016 1 commit
-
-
Yorick Peterse authored
The rationale for this can be found in https://gitlab.com/gitlab-org/gitlab-ce/issues/13718 but in short the benchmark suite no longer serves a good purpose now that we have proper production monitoring in place. Fixes gitlab-org/gitlab-ce#13718
-